fix: review follow-ups — version bump, Slack alert setup, DRY helper

- Bump version 0.3.1 → 0.3.2 (pyproject.toml, plugin.json, marketplace.json)
- Add Slack alert setup section to release-branch-config.md (channel
  creation, incoming webhook, Vault secret configuration)
- Add Slack setup step to commission-release.md workflow
- Standardize placeholder casing to {version} in release-branch-config.md
- Clarify releases.latest.release field description
- Extract _first_versions() helper in analyze_coverage.py to DRY up
  the repeated api_data.get('data', [])[0] pattern
- Clarify decommission-release.md: generated jobs removed by make update
- Decommission workflow now runs make update — the previous 'Do NOT run
  make update' guidance was incorrect; make update correctly removes
  generated job files for deleted configs, matching commission behavior

Assisted-by: OpenCode

Author: zdrapela

.claude-plugin/marketplace.json

@@ -5,14 +5,14 @@
   },
   "metadata": {
     "description": "Orchestrator skill for RHDH plugin development - onboard, update, and maintain plugins in the Extensions Catalog",
-    "version": "0.3.1"
+    "version": "0.3.2"
   },
   "plugins": [
     {
       "name": "rhdh",
       "source": "./",
       "description": "Skills for RHDH plugin lifecycle management",
-      "version": "0.3.1",
+      "version": "0.3.2",
       "strict": true
     }
   ]

.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "rhdh",
   "description": "All-in-one toolkit for Red Hat Developer Hub (RHDH). Covers plugin development, overlay management, environment setup, version compatibility, CI/CD, and RHDH ecosystem navigation.",
-  "version": "0.3.1",
+  "version": "0.3.2",
   "author": {
     "name": "RHDH Store Manager"
   },

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "rhdh-skill"
-version = "0.3.1"
+version = "0.3.2"
 description = "Claude Code skill for RHDH plugin development"
 readme = "README.md"
 license = "Apache-2.0"

skills/prow/references/release-branch-config.md

@@ -4,12 +4,12 @@ Shared definitions for commissioning and decommissioning RHDH release branch CI
 
 ## File Paths
 
-For a given release version `{VERSION}` (e.g. `1.10`):
+For a given release version `{version}` (e.g. `1.10`):
 
 | File | Path |
 |------|------|
-| **CI config** | `ci-operator/config/redhat-developer/rhdh/redhat-developer-rhdh-release-{VERSION}.yaml` |
-| **Generated jobs** | `ci-operator/jobs/redhat-developer/rhdh/redhat-developer-rhdh-release-{VERSION}-*.yaml` |
+| **CI config** | `ci-operator/config/redhat-developer/rhdh/redhat-developer-rhdh-release-{version}.yaml` |
+| **Generated jobs** | `ci-operator/jobs/redhat-developer/rhdh/redhat-developer-rhdh-release-{version}-*.yaml` |
 | **Branch protection** | `core-services/prow/02_config/redhat-developer/rhdh/_prowconfig.yaml` |
 
 ## Branch Protection
@@ -18,7 +18,7 @@ Each release branch has an entry under `branch-protection.orgs.redhat-developer.
 
 When commissioning, **read the latest existing release branch entry** from `_prowconfig.yaml` and copy its structure (keys, contexts, settings). Do not hardcode the block — the required status check contexts and protection settings change over time.
 
-When decommissioning, remove the entire `release-{VERSION}:` block, preserving indentation and formatting of surrounding entries.
+When decommissioning, remove the entire `release-{version}:` block, preserving indentation and formatting of surrounding entries.
 
 ## Release Branch vs Main Differences
 
@@ -30,7 +30,7 @@ When creating a release branch config from `main` or another release branch, **r
 | **Cron schedule** | Read the latest release branch config to see the current schedule pattern. Release branches use a different schedule than `main` to spread load |
 | **Cleanup jobs** | Compare `main` with the latest release branch. Jobs present in `main` but absent from all release branches are main-only — remove them |
 | **Presubmit tests** | Compare `main` with the latest release branch. Note differences in `always_run`, `max_concurrency`, and other settings — apply the release branch pattern |
-| **`zz_generated_metadata.branch`** | Set to `release-{VERSION}` |
+| **`zz_generated_metadata.branch`** | Set to `release-{version}` |
 
 Version-specific settings to verify with the user:
 
@@ -39,9 +39,24 @@ Version-specific settings to verify with the user:
 | **OCP versions** | Read the source config's `e2e-ocp-v4-*-helm-nightly` entries. Ask the user which OCP versions to include for the new branch |
 | **K8s version** (`MAPT_KUBERNETES_VERSION`) | Read from the source config. Ask the user if it should change |
 | **OSD version** | Read from the source config. Ask the user if it should change |
-| **`releases.latest.release`** | Compare `channel` and `version` between main and release branches |
+| **`releases.latest.release`** | OCP release payload used by ci-operator (`channel` + `version`). Compare main and release branches — typically the same, but may differ if the release branch targets an older OCP |
 | **`build_root` tag** | Read from the source config. Ask the user if it should change |
 
+## Slack Alert Setup
+
+Each release branch needs its own Slack channel and webhook for E2E alert notifications. There are two alert mechanisms:
+
+1. **Prow `reporter_config`** — configured per-test in the CI config YAML (`reporter_config.channel`). Set to `#rhdh-e2e-alerts-{X}-{Y}` (dots replaced with hyphens). This fires on infrastructure-level errors.
+
+2. **`rhdh-send-alert` step** — uses a Slack incoming webhook URL from the Vault secret `rhdh-send-alert` (namespace `test-credentials`). The script auto-detects the release version from `JOB_NAME` and looks for a versioned key `SLACK_ALERTS_WEBHOOK_URL_{X}_{Y}` (dots replaced with underscores), falling back to the default `SLACK_ALERTS_WEBHOOK_URL`.
+
+### Setup steps
+
+1. **Create Slack channel** `#rhdh-e2e-alerts-{X}-{Y}` in the [Nightly Test Alerts Slack app](https://api.slack.com/apps/A08U4AP1YTY/incoming-webhooks)
+2. **Create incoming webhook** for the new channel in the same Slack app
+3. **Add webhook URL to Vault** secret `rhdh-send-alert` as key `SLACK_ALERTS_WEBHOOK_URL_{X}_{Y}`
+4. **Set `reporter_config.channel`** to `#rhdh-e2e-alerts-{X}-{Y}` on every nightly test entry in the CI config
+
 ## Post-Change Step
 
 After modifying any CI config files, always run:

skills/prow/scripts/analyze_coverage.py

@@ -56,6 +56,12 @@ def _fetch_lifecycle_json(script_name):
     return None
 
 
+def _first_versions(api_data):
+    """Extract versions list from the first entry of API response data."""
+    data = api_data.get("data", [])
+    return data[0].get("versions", []) if data else []
+
+
 def _fetch_api(product_name):
     """Fetch lifecycle data directly from the Red Hat API (fallback)."""
     url = f"{LIFECYCLE_API_URL}?name={urllib.parse.quote_plus(product_name)}"
@@ -81,8 +87,7 @@ def _get_rhdh_lifecycle():
     api_data = _fetch_api("Red Hat Developer Hub")
     if not api_data:
         return []
-    data = api_data.get("data", [])
-    versions_raw = data[0].get("versions", []) if data else []
+    versions_raw = _first_versions(api_data)
     results = []
     for ver in versions_raw:
         ocp_compat = ver.get("openshift_compatibility", "")
@@ -119,8 +124,7 @@ def _is_date(val):
     def _to_date(val):
         return val[:10] if _is_date(val) else None
 
-    data = api_data.get("data", [])
-    versions = data[0].get("versions", []) if data else []
+    versions = _first_versions(api_data)
     versions = [v for v in versions if re.match(r"^\d+\.\d+$", v.get("name", ""))]
     versions = [v for v in versions if int(v["name"].split(".")[0]) >= 4]
 
@@ -153,7 +157,7 @@ def _to_date(val):
                     if end and end >= today:
                         current_phase = pname
                         break
-                    elif not _is_date(end_raw) and end_raw not in ("N/A", "", None):
+                    elif end is None or (not _is_date(end_raw) and end_raw not in ("N/A", "")):
                         current_phase = pname
                         break
             if current_phase != "End of life":

skills/prow/workflows/commission-release.md

@@ -18,7 +18,7 @@ Read `../references/release-branch-config.md` for file paths, templates, and rel
 3. **Copy and adjust the CI config**:
    - Copy the source file to `redhat-developer-rhdh-release-{version}.yaml`
    - Read both the `main` config and the latest existing release branch config to understand the current patterns
-   - Apply all structural adjustments described in `references/release-branch-config.md` — compare main vs release branch to determine what to change (Slack channel, cron schedule, cleanup jobs, presubmit settings)
+   - Apply all structural adjustments described in `../references/release-branch-config.md` — compare main vs release branch to determine what to change (Slack channel, cron schedule, cleanup jobs, presubmit settings)
    - Set `zz_generated_metadata.branch` to `release-{version}`
 
 4. **Confirm version-specific settings** with the user:
@@ -28,14 +28,19 @@ Read `../references/release-branch-config.md` for file paths, templates, and rel
    - `build_root` tag
    - If copying from the latest release branch, these are often unchanged
 
-5. **Add branch protection** to `_prowconfig.yaml`:
+5. **Set up Slack alerts** (see `../references/release-branch-config.md` > Slack Alert Setup):
+   - Create Slack channel `#rhdh-e2e-alerts-{X}-{Y}` and incoming webhook
+   - Add webhook URL to Vault secret `rhdh-send-alert` as key `SLACK_ALERTS_WEBHOOK_URL_{X}_{Y}`
+   - Set `reporter_config.channel` to `#rhdh-e2e-alerts-{X}-{Y}` on every nightly test entry in the CI config
+
+6. **Add branch protection** to `_prowconfig.yaml`:
    - Read the latest existing release branch entry from `_prowconfig.yaml` to get the current structure and contexts
    - Add a `release-{version}:` entry under `branch-protection.orgs.redhat-developer.repos.rhdh.branches`, copying the structure from the latest release branch
    - Place the new entry in version order among existing entries
 
-6. **Run `make update`** to regenerate Prow job configs
+7. **Run `make update`** to regenerate Prow job configs
 
-7. **Verify and summarize**:
+8. **Verify and summarize**:
    - Confirm generated job files exist: `ls ci-operator/jobs/redhat-developer/rhdh/redhat-developer-rhdh-release-{version}-*.yaml`
    - Show a summary of what was created
 

skills/prow/workflows/decommission-release.md

@@ -11,7 +11,7 @@ Read `../references/release-branch-config.md` for file paths and templates.
 
 2. **Verify files to be removed** (show the user and ask for confirmation):
    - **CI config**: `ci-operator/config/redhat-developer/rhdh/redhat-developer-rhdh-release-{version}.yaml`
-   - **Generated jobs**: `ci-operator/jobs/redhat-developer/rhdh/redhat-developer-rhdh-release-{version}-*.yaml`
+   - **Generated jobs** (removed by `make update`): `ci-operator/jobs/redhat-developer/rhdh/redhat-developer-rhdh-release-{version}-*.yaml`
    - **Branch protection**: `release-{version}:` block in `core-services/prow/02_config/redhat-developer/rhdh/_prowconfig.yaml`
 
 3. **Delete the CI config file**