fix: address PR review feedback

- Add rhdh-dynamic-plugin-factory to SUBMODULE_REPOS with config_key "factory"
- Add factory repo documentation to rhdh-repos.md and ecosystem diagram
- Add rhdh-repos to Shared References table in SKILL.md
- Fix wording/formatting in SKILL.md understand_rhdh_repos principle
- Fix conftest.py unconfigured_cli docstring to match actual patches

Author: kadel

skills/rhdh/SKILL.md

@@ -46,7 +46,7 @@ These contain critical gotchas (jq escaping, JQL limitations, assignee format) t
 <principle name="understand_rhdh_repos">
 **Before any RHDH-related work**, consult `references/rhdh-repos.md` for a reference of all RHDH-related repositories, what each one is used for, and how they relate to each other.
 Use this when navigating between projects or understanding the overall RHDH ecosystem.
-use `$RHDH config set`  to set path to the local checkout of the RHDH repositories.
+Use `$RHDH config set` to set the path to the local checkout of the RHDH repositories.
 </principle>
 
 </essential_principles>
@@ -298,6 +298,7 @@ Todos must be **self-contained**—a new session should understand the task with
 
 | Reference | Purpose | Path |
 |-----------|---------|------|
+| rhdh-repos | Repository map, ecosystem relationships, key paths | `references/rhdh-repos.md` |
 | versions | RHDH/Backstage version compatibility matrix | `references/versions.md` |
 | jira-structure | RHDH Jira projects, issue types, filing rules | `references/jira-structure.md` |
 

skills/rhdh/references/rhdh-repos.md

@@ -133,6 +133,16 @@ Reference of all RHDH-related repositories, what each one is used for, and how t
   - **Branching:** `main` for active development; `1.2` for release maintenance; `changesets-release/<workspace>/main` for automated version PRs.
 - **Key paths:** `workspaces/` (all plugin workspaces), `scripts/ci/` (CI helper scripts), `.github/CODEOWNERS` (per-workspace ownership)
 
+### rhdh-dynamic-plugin-factory
+
+- **Upstream:** https://github.com/redhat-developer/rhdh-dynamic-plugin-factory
+- **Description:** Container image and tooling for building dynamic plugins locally. Provides a pre-configured build environment with all necessary dependencies (Node.js, Yarn, Backstage CLI) so plugin authors can export and package plugins without setting up a full development environment. Used via `podman` or `docker`.
+- **Tech stack:** Container (Podman/Docker), Node.js, Yarn, Backstage CLI
+- **Key concepts:**
+  - **Container-based builds:** Run `podman run` or `docker run` with the factory image to build plugins in an isolated environment.
+  - **Used by overlay workflows:** `rhdh-plugin-export-overlays` can use the factory container for local plugin builds.
+- **Key paths:** `Containerfile` (image definition)
+
 ### backstage
 
 - **Upstream:** https://github.com/backstage/backstage
@@ -172,6 +182,7 @@ rhdh (enterprise distribution, github.com)
     |   +-- rhdh-chart (Helm chart)
     |
     +-- rhdh-local (local dev/test environment)
+    +-- rhdh-dynamic-plugin-factory (container for local plugin building)
 ```
 
 ## Common Workflows

skills/rhdh/rhdh/config.py

@@ -94,6 +94,12 @@
         "config_key": "local",
         "description": "Local RHDH testing environment (Docker Compose)",
     },
+    "rhdh-dynamic-plugin-factory": {
+        "has_fork": False,
+        "required": False,
+        "config_key": "factory",
+        "description": "Container for local dynamic plugin building",
+    },
     "backstage": {
         "has_fork": False,
         "required": False,

tests/conftest.py

@@ -224,7 +224,7 @@ def unconfigured_cli(isolated_env, monkeypatch):
     """Fixture providing CLI with no repos configured.
 
     Use this to test the "needs setup" state without manual monkeypatching.
-    Mocks get_repo to return None for all repos.
+    Mocks get_overlay_repo and get_repo to return None for all repos.
     """
     from rhdh import cli as cli_module