Skip to content

Commit b23482d

Browse files
committed
rhdh-pr-review: restore useful guidance in natural voice
- Bring back follow-up summary exception (scope changed, different revision) - Bring back severity tiering (substantial findings get full comments, nits can be grouped as one-liners) - Bring back calling out good decisions by name (not generic praise)
1 parent 4b9e0ce commit b23482d

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

skills/rhdh-pr-review/workflows/review-code.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,15 +59,15 @@ The posted review should read like a person wrote it, not a report generator. Th
5959

6060
Keep it short and direct — frame what the inline comments are about so the author knows the scope at a glance. Include a requirements coverage note if linked issues were checked. Skip performative praise; it reads as filler.
6161

62-
If `existing_reviews` shows you've already left a top-level comment on this PR, a new one is often unnecessary — consider posting only the inline findings to reduce noise.
62+
If `existing_reviews` shows you've already left a top-level comment on this PR, a new one is often unnecessary — consider posting only the inline findings. A follow-up summary is still warranted if the scope of feedback changed significantly or the prior review was on a different revision.
6363

6464
### Inline comments
6565

66-
Post one inline comment per finding worth raising — no artificial cap. Never leave a comment just to show you noticed something.
66+
Post one inline comment per finding worth raising — no artificial cap. Never leave a comment just to show you noticed something. Not every finding needs the same weight — substantial issues get a full comment, nits can be grouped into a single comment as one-liners.
6767

6868
Write each comment as natural prose — a short paragraph explaining the issue and why it matters. Avoid bullet lists, bold headers, and over-structured formatting. Keep just enough information for the author to understand the problem and act on it. Code suggestions and code blocks are fine since they're functional, not formatting.
6969

70-
Assume deliberate choices. Ask why before suggesting alternatives. Explain reasoning only when the fix isn't obvious.
70+
Assume deliberate choices. Ask why before suggesting alternatives. Explain reasoning only when the fix isn't obvious. Call out specific things done well when genuine — name the pattern or decision, not generic praise.
7171

7272
**If nothing significant survives verification**, that's a valid outcome. Produce a short approving review. Don't manufacture issues.
7373

0 commit comments

Comments
 (0)