Skip to content

Commit bc3f890

Browse files
committed
Remove Jira routing from rhdh skill + review fixes
- Remove Jira intake menu item, routing section, and principle from rhdh SKILL.md so the rhdh-jira skill activates naturally instead of being intercepted by a stale jira-structure.md reference - Remove jira-reference.md and jira-structure.md from reference index and shared references table (files kept for overlay's cross-reference) - Update consult_tool_references principle: GitHub only, with note to use rhdh-jira skill directly for Jira work - Renumber intake menu (1-9) and routing table to match - Fix L1: export-plugin.py ANSI color check uses both stdout+stderr TTY - Fix L2: README skill-maker description mentions consolidation - Fix S1: consolidation-guide.md grep example includes --exclude-dir=.git - Fix scaffold.py: move os import to top-level (ruff E402)
1 parent 1ff5956 commit bc3f890

5 files changed

Lines changed: 20 additions & 28 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ Track work across the four RHDH Jira projects.
4646

4747
### Meta
4848

49-
- **[skill-maker](./skills/skill-maker/SKILL.md)** — Create new skills following the [Agent Skills open standard](https://agentskills.io/specification). Interviews you about scope and edge cases before drafting.
49+
- **[skill-maker](./skills/skill-maker/SKILL.md)** — Create new skills or consolidate existing ones following the [Agent Skills open standard](https://agentskills.io/specification). Interviews you about scope and edge cases before drafting.
5050

5151
## Getting Started
5252

skills/create-plugin/scripts/export-plugin.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,11 @@
2929
# ANSI helpers
3030
# ---------------------------------------------------------------------------
3131

32-
_NO_COLOR = os.environ.get("NO_COLOR") is not None or not sys.stdout.isatty()
32+
# Disable colors if NO_COLOR is set or neither stdout nor stderr is a TTY
33+
_NO_COLOR = (
34+
os.environ.get("NO_COLOR") is not None
35+
or not (sys.stdout.isatty() or sys.stderr.isatty())
36+
)
3337

3438
RED = "" if _NO_COLOR else "\033[0;31m"
3539
GREEN = "" if _NO_COLOR else "\033[0;32m"

skills/create-plugin/scripts/scaffold.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515

1616
import argparse
1717
import json
18+
import os
1819
import subprocess
1920
import sys
2021
from pathlib import Path
@@ -41,8 +42,7 @@
4142
EXIT_USAGE = 2
4243

4344
# ANSI colors (disabled when not a TTY or NO_COLOR is set)
44-
import os as _os
45-
_no_color = _os.environ.get("NO_COLOR") is not None
45+
_no_color = os.environ.get("NO_COLOR") is not None
4646
_is_tty = sys.stderr.isatty() and not _no_color
4747

4848

@@ -328,7 +328,7 @@ def scaffold(args: argparse.Namespace) -> dict:
328328
log(f" 1. cd {plugin_path}")
329329
log(f" 2. Implement {'plugin logic in src/plugin.ts' if is_backend else 'components in src/'}")
330330
if not is_backend and with_theme:
331-
log(f" 3. Configure theme in dev/index.tsx")
331+
log(" 3. Configure theme in dev/index.tsx")
332332
log(f" {'4' if (not is_backend and with_theme) else '3'}. yarn build")
333333
log(
334334
f" {'5' if (not is_backend and with_theme) else '4'}."

skills/rhdh/SKILL.md

Lines changed: 10 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,12 @@ See the `<tracking_system>` section for details.
3636
</principle>
3737

3838
<principle name="consult_tool_references">
39-
**Before using JIRA or GitHub CLI**, read the corresponding reference file:
39+
**Before using GitHub CLI**, read the reference file:
4040
- **GitHub:** `references/github-reference.md` — PR queries, CI analysis, `/publish` triggers
41-
- **JIRA:** `references/jira-reference.md` — JQL queries, issue creation, comment format
4241

43-
These contain critical gotchas (jq escaping, JQL limitations, assignee format) that prevent common errors.
42+
Contains critical gotchas (jq escaping, assignee format) that prevent common errors.
43+
44+
**For Jira work**, use the `rhdh-jira` skill directly — it has its own comprehensive references, CLI tooling (`acli`), and REST/GraphQL fallback.
4445
</principle>
4546

4647
<principle name="understand_rhdh_repos">
@@ -99,20 +100,16 @@ What would you like to do?
99100

100101
6. **Create plugin** — Bootstrap, export, package, or wire a dynamic plugin (backend or frontend)
101102

102-
### Jira Tasks
103-
104-
7. **Jira structure** — Projects and issue types
105-
106103
### Local Testing Tasks
107104

108105
*For testing plugins in a local RHDH instance using rhdh-local-setup*
109106

110-
8. **Local testing** — Enable/disable/test plugins in local RHDH
107+
7. **Local testing** — Enable/disable/test plugins in local RHDH
111108

112109
### General Tasks
113110

114-
9. **Check environment** — Run doctor, configure paths
115-
10. **View/search activity** — Review worklog, todos
111+
8. **Check environment** — Run doctor, configure paths
112+
9. **View/search activity** — Review worklog, todos
116113

117114
**Wait for response before proceeding.**
118115
</intake>
@@ -142,26 +139,20 @@ What would you like to do?
142139

143140
**To route:** Read `../create-plugin/SKILL.md` and follow its routing rules (backend, frontend, export, wiring sub-commands).
144141

145-
### Jira Routes
146-
147-
| Response | Action |
148-
|----------|--------|
149-
| 7, "jira", "jira projects", "issue types", "RHIDP", "RHDHPLAN", "RHDHBUGS", "RHDHSUPP" | Read `references/jira-structure.md` and use it as context |
150-
151142
### Local Testing Routes
152143

153144
| Response | Skill |
154145
|----------|-------|
155-
| 8, "local", "test locally", "enable plugin", "disable plugin", "local testing", "rhdh-local-setup" | Route to `@rhdh-local` skill |
146+
| 7, "local", "test locally", "enable plugin", "disable plugin", "local testing", "rhdh-local-setup" | Route to `@rhdh-local` skill |
156147

157148
**To route:** Read `../rhdh-local/SKILL.md` and follow its intake process.
158149

159150
### General Routes
160151

161152
| Response | Action |
162153
|----------|--------|
163-
| 9, "doctor", "setup", "config" | Use CLI commands below |
164-
| 10, "log", "todo", "activity" | Use tracking commands below |
154+
| 8, "doctor", "setup", "config" | Use CLI commands below |
155+
| 9, "log", "todo", "activity" | Use tracking commands below |
165156

166157
</routing>
167158

@@ -286,8 +277,6 @@ Todos must be **self-contained**—a new session should understand the task with
286277
<reference_index>
287278
**RHDH Repos:** references/rhdh-repos.md — repository map, ecosystem relationships, key paths
288279
**GitHub CLI (PRs, CI, workflows):** references/github-reference.md
289-
**JIRA CLI (issues, JQL, comments):** references/jira-reference.md
290-
**JIRA Structure (projects, issue types, filing rules):** references/jira-structure.md
291280
**Version Matrix:** references/versions.md — RHDH/Backstage version compatibility, create-app versions
292281
**Slack Notifications:** references/slack-notification.md — Slack ping templates, handle mapping, channel routing
293282
</reference_index>
@@ -308,6 +297,5 @@ Todos must be **self-contained**—a new session should understand the task with
308297
|-----------|---------|------|
309298
| rhdh-repos | Repository map, ecosystem relationships, key paths | `references/rhdh-repos.md` |
310299
| versions | RHDH/Backstage version compatibility matrix | `references/versions.md` |
311-
| jira-structure | RHDH Jira projects, issue types, filing rules | `references/jira-structure.md` |
312300

313301
</skills_index>

skills/skill-maker/references/consolidation-guide.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ When consolidating near-identical scripts:
7878
This is where consolidations break. Search the **entire project** for old skill names:
7979

8080
```bash
81-
grep -rn "old-skill-name" --include="*.md" --include="*.py" --include="*.json" --include="*.yaml" .
81+
grep -rn "old-skill-name" --include="*.md" --include="*.py" --include="*.json" --include="*.yaml" --exclude-dir=.git .
8282
```
8383

8484
**Must update:**

0 commit comments

Comments
 (0)