You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
docs: enhance active verification phase with detailed testing guidelines
Updated the active verification phase to clarify the purpose of testing specific code changes on the live cluster. Added instructions for analyzing diffs, proposing verification plans, and capturing evidence during execution. Emphasized the importance of user approval before proceeding with verification steps.
Copy file name to clipboardExpand all lines: skills/rhdh-pr-review/workflows/review-operator-pr.md
+12-7Lines changed: 12 additions & 7 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -476,7 +476,7 @@ When done testing, rollback the operator image:
476
476
477
477
## Phase 6: Active Verification
478
478
479
-
Test the PR's actual changes on the live cluster. Use the diff from Phase 1 and the operator architecture from `../../rhdh/references/rhdh-repos.md` to understand what changed.
479
+
**This phase verifies the PR's specific code changes on the cluster — not generic health checks.** The goal is to exercise the exact code paths the PR modified and capture evidence that the behavioral change works as intended.
480
480
481
481
### 6.1 Analyze the diff
482
482
@@ -486,19 +486,24 @@ Read the diff hunks from Phase 1. For each changed file, understand:
486
486
- What it does **after**
487
487
- What behavioral difference this introduces on a running cluster
488
488
489
+
Map each changed code path to a concrete cluster-observable effect — something you can trigger and measure on the running cluster. If a code change has no cluster-observable effect (e.g., pure refactor with identical behavior), state that explicitly and explain why.
490
+
489
491
### 6.2 Propose a verification plan
490
492
491
-
Based on the analysis, propose a concrete plan to the user:
493
+
Present the plan to the user. For each test, specify:
492
494
493
-
- What cluster actions will exercise the changed code paths
494
-
- What to observe (logs, pod spec, CR status, events) to confirm the fix works
495
-
- What constitutes a pass or fail
495
+
-**What to do**: the exact cluster action (create resource, edit CR, delete pod, etc.)
496
+
-**What to observe**: where to look (logs, pod spec, CR status, events, API response)
497
+
-**Pass criteria**: what output means the fix works
498
+
-**Fail criteria**: what output means the fix is broken
496
499
497
-
**Wait for the user to accept the plan before proceeding.**
500
+
**STOP. Do not run any verification commands. Present the plan and wait for the user to accept it before proceeding to 6.3.**
498
501
499
502
### 6.3 Execute the plan
500
503
501
-
Run the accepted verification steps on the cluster. Capture evidence (operator logs, pod specs, events, CR status) as you go.
504
+
Only after the user accepts the plan:
505
+
506
+
Run each verification step on the cluster. For every step, capture the actual command output as evidence. Do not summarize — show the raw output so the user can see exactly what happened.
0 commit comments