Skip to content

Commit d2baecb

Browse files
docs: enhance active verification phase with detailed testing guidelines
Updated the active verification phase to clarify the purpose of testing specific code changes on the live cluster. Added instructions for analyzing diffs, proposing verification plans, and capturing evidence during execution. Emphasized the importance of user approval before proceeding with verification steps.
1 parent 316fa01 commit d2baecb

1 file changed

Lines changed: 12 additions & 7 deletions

File tree

skills/rhdh-pr-review/workflows/review-operator-pr.md

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,7 @@ When done testing, rollback the operator image:
476476

477477
## Phase 6: Active Verification
478478

479-
Test the PR's actual changes on the live cluster. Use the diff from Phase 1 and the operator architecture from `../../rhdh/references/rhdh-repos.md` to understand what changed.
479+
**This phase verifies the PR's specific code changes on the cluster — not generic health checks.** The goal is to exercise the exact code paths the PR modified and capture evidence that the behavioral change works as intended.
480480

481481
### 6.1 Analyze the diff
482482

@@ -486,19 +486,24 @@ Read the diff hunks from Phase 1. For each changed file, understand:
486486
- What it does **after**
487487
- What behavioral difference this introduces on a running cluster
488488

489+
Map each changed code path to a concrete cluster-observable effect — something you can trigger and measure on the running cluster. If a code change has no cluster-observable effect (e.g., pure refactor with identical behavior), state that explicitly and explain why.
490+
489491
### 6.2 Propose a verification plan
490492

491-
Based on the analysis, propose a concrete plan to the user:
493+
Present the plan to the user. For each test, specify:
492494

493-
- What cluster actions will exercise the changed code paths
494-
- What to observe (logs, pod spec, CR status, events) to confirm the fix works
495-
- What constitutes a pass or fail
495+
- **What to do**: the exact cluster action (create resource, edit CR, delete pod, etc.)
496+
- **What to observe**: where to look (logs, pod spec, CR status, events, API response)
497+
- **Pass criteria**: what output means the fix works
498+
- **Fail criteria**: what output means the fix is broken
496499

497-
**Wait for the user to accept the plan before proceeding.**
500+
**STOP. Do not run any verification commands. Present the plan and wait for the user to accept it before proceeding to 6.3.**
498501

499502
### 6.3 Execute the plan
500503

501-
Run the accepted verification steps on the cluster. Capture evidence (operator logs, pod specs, events, CR status) as you go.
504+
Only after the user accepts the plan:
505+
506+
Run each verification step on the cluster. For every step, capture the actual command output as evidence. Do not summarize — show the raw output so the user can see exactly what happened.
502507

503508
---
504509

0 commit comments

Comments
 (0)