refactor: extract generic utilities into utils.py modules

Move fetch_json, ver_sort_key, is_date, to_date, and
filter_supported_eol_entries from redhat.py into a new
rhdh_lifecycle/utils.py module. These functions are used by
AKS/EKS/GKE/PG scripts that have no relation to the Red Hat
Product Life Cycles API.

Create rhdh_prow/utils.py with ver_sort_key (subset of lifecycle
utils). Restore rhdh_prow/__init__.py to docstring-only.

Update all imports across lifecycle and prow scripts. redhat.py
re-exports is_date, to_date, ver_sort_key for backward
compatibility.

Update AGENTS.md shared modules sync rule to reference utils.py.

Assisted-by: OpenCode

Author: zdrapela

AGENTS.md

@@ -78,7 +78,7 @@ Bump all three when releasing.
 
 `skills/prow/scripts/rhdh_prow/repo.py` and `skills/prow/scripts/rhdh_prow/yaml.py` are copies of `skills/lifecycle/scripts/rhdh_lifecycle/repo.py` and `skills/lifecycle/scripts/rhdh_lifecycle/yaml.py`. The only difference is the internal import path (`rhdh_prow.repo` vs `rhdh_lifecycle.repo`). When modifying either copy, update both to keep them in sync.
 
-`ver_sort_key` in `skills/prow/scripts/rhdh_prow/__init__.py` is a copy of the same function in `skills/lifecycle/scripts/rhdh_lifecycle/redhat.py`. Keep both in sync.
+`skills/prow/scripts/rhdh_prow/utils.py` is a subset of `skills/lifecycle/scripts/rhdh_lifecycle/utils.py`. When modifying either copy, update both to keep them in sync.
 
 ## Agent skills
 

skills/lifecycle/scripts/check_aks_lifecycle.py

@@ -17,8 +17,8 @@
 from datetime import datetime, timezone
 
 from rhdh_lifecycle.configured_versions import print_configured_versions
-from rhdh_lifecycle.redhat import fetch_json, filter_supported_eol_entries, ver_sort_key
 from rhdh_lifecycle.repo import resolve_repo_root
+from rhdh_lifecycle.utils import fetch_json, filter_supported_eol_entries, ver_sort_key
 
 AKS_API_URL = "https://releases.aks.azure.com/parsed_data.json"
 EOL_API_URL = "https://endoflife.date/api/azure-kubernetes-service.json"

skills/lifecycle/scripts/check_eks_lifecycle.py

@@ -20,8 +20,8 @@
 from datetime import datetime, timezone
 
 from rhdh_lifecycle.configured_versions import print_configured_versions
-from rhdh_lifecycle.redhat import fetch_json, filter_supported_eol_entries
 from rhdh_lifecycle.repo import resolve_repo_root
+from rhdh_lifecycle.utils import fetch_json, filter_supported_eol_entries
 
 EKS_DOCS_URL = (
     "https://raw.githubusercontent.com/awsdocs/amazon-eks-user-guide"

skills/lifecycle/scripts/check_gke_lifecycle.py

@@ -17,7 +17,7 @@
 import sys
 from datetime import datetime, timezone
 
-from rhdh_lifecycle.redhat import fetch_json, ver_sort_key
+from rhdh_lifecycle.utils import fetch_json, ver_sort_key
 
 API_URL = "https://endoflife.date/api/google-kubernetes-engine.json"
 

skills/lifecycle/scripts/rhdh_lifecycle/ocp.py

@@ -12,7 +12,7 @@
 
 import re
 
-from rhdh_lifecycle.redhat import is_date, to_date, ver_sort_key
+from rhdh_lifecycle.utils import is_date, to_date, ver_sort_key
 
 
 def classify_ocp_versions(api_data, today):

skills/lifecycle/scripts/rhdh_lifecycle/pg.py

@@ -12,7 +12,7 @@
 
 from __future__ import annotations
 
-from rhdh_lifecycle.redhat import fetch_json
+from rhdh_lifecycle.utils import fetch_json
 
 PROVIDERS = {
     "upstream": "https://endoflife.date/api/postgresql.json",

skills/lifecycle/scripts/rhdh_lifecycle/redhat.py

@@ -21,6 +21,8 @@
 import urllib.parse
 import urllib.request
 
+from rhdh_lifecycle.utils import is_date, to_date, ver_sort_key  # noqa: F401
+
 LIFECYCLE_API_URL = "https://access.redhat.com/product-life-cycles/api/v1/products"
 
 PRODUCT_ALIASES = {
@@ -33,20 +35,6 @@
 }
 
 
-def is_date(val):
-    """Return True if val looks like a YYYY-MM-DD date string."""
-    if not val or not isinstance(val, str):
-        return False
-    return bool(re.match(r"^\d{4}-\d{2}-\d{2}", val))
-
-
-def to_date(val):
-    """Extract YYYY-MM-DD from a date string, or None."""
-    if is_date(val):
-        return val[:10]
-    return None
-
-
 def _phase_date(phases, phase_name):
     """Extract the end_date for a named phase, formatted as YYYY-MM-DD or raw string."""
     for p in phases:
@@ -58,59 +46,11 @@ def _phase_date(phases, phase_name):
     return "N/A"
 
 
-def ver_sort_key(version_str):
-    """Sort key for version strings like '4.16' or '26.2'."""
-    try:
-        return [int(x) for x in version_str.split(".")]
-    except ValueError:
-        return [0]
-
-
-def filter_supported_eol_entries(eol_data, today):
-    """Filter endoflife.date entries to those still supported.
-
-    Considers both ``eol`` and ``extendedSupport`` fields. Returns the
-    filtered list sorted by cycle version (newest first).
-    """
-    supported = []
-    for entry in eol_data:
-        eol = entry.get("eol", "N/A")
-        ext = entry.get("extendedSupport", "N/A")
-        has_support = False
-        if eol == "N/A":
-            has_support = True
-        elif isinstance(eol, bool):
-            has_support = not eol
-        elif isinstance(eol, str) and eol > today:
-            has_support = True
-        if not has_support and isinstance(ext, str) and ext > today:
-            has_support = True
-        if has_support:
-            supported.append(entry)
-    supported.sort(key=lambda e: ver_sort_key(e["cycle"]), reverse=True)
-    return supported
-
-
 def resolve_product_name(product):
     """Resolve a product alias to the full API product name."""
     return PRODUCT_ALIASES.get(product.lower(), product)
 
 
-def fetch_json(url):
-    """Fetch JSON from a URL.
-
-    Returns the parsed JSON, or None on failure. Shared by all lifecycle
-    scripts that consume external APIs (endoflife.date, AKS, EKS, etc.).
-    """
-    req = urllib.request.Request(url, headers={"User-Agent": "rhdh-skill"})
-    try:
-        with urllib.request.urlopen(req, timeout=30) as resp:
-            return json.loads(resp.read().decode("utf-8"))
-    except (urllib.error.URLError, OSError) as exc:
-        print(f"ERROR: Failed to fetch {url}: {exc}", file=sys.stderr)
-        return None
-
-
 def fetch_api(product_name):
     """Fetch raw lifecycle data from the Red Hat Product Life Cycles API.
 

skills/lifecycle/scripts/rhdh_lifecycle/rhdh.py

@@ -7,7 +7,8 @@
 
 from __future__ import annotations
 
-from rhdh_lifecycle.redhat import fetch_api, fetch_product_lifecycle, parse_versions, ver_sort_key
+from rhdh_lifecycle.redhat import fetch_api, fetch_product_lifecycle, parse_versions
+from rhdh_lifecycle.utils import ver_sort_key
 
 
 def _enrich_rhdh_version(v):

skills/lifecycle/scripts/rhdh_lifecycle/utils.py

@@ -0,0 +1,78 @@
+"""Generic utility functions shared across lifecycle scripts.
+
+Provides URL fetching, date parsing, version sorting, and endoflife.date
+helpers used by all lifecycle and prow scripts.
+
+Usage:
+    from rhdh_lifecycle.utils import fetch_json, ver_sort_key
+"""
+
+from __future__ import annotations
+
+import json
+import re
+import sys
+import urllib.error
+import urllib.request
+
+
+def fetch_json(url):
+    """Fetch JSON from a URL.
+
+    Returns the parsed JSON, or None on failure. Shared by all lifecycle
+    scripts that consume external APIs (endoflife.date, AKS, EKS, etc.).
+    """
+    req = urllib.request.Request(url, headers={"User-Agent": "rhdh-skill"})
+    try:
+        with urllib.request.urlopen(req, timeout=30) as resp:
+            return json.loads(resp.read().decode("utf-8"))
+    except (urllib.error.URLError, OSError) as exc:
+        print(f"ERROR: Failed to fetch {url}: {exc}", file=sys.stderr)
+        return None
+
+
+def is_date(val):
+    """Return True if val looks like a YYYY-MM-DD date string."""
+    if not val or not isinstance(val, str):
+        return False
+    return bool(re.match(r"^\d{4}-\d{2}-\d{2}", val))
+
+
+def to_date(val):
+    """Extract YYYY-MM-DD from a date string, or None."""
+    if is_date(val):
+        return val[:10]
+    return None
+
+
+def ver_sort_key(version_str):
+    """Sort key for version strings like '4.16' or '26.2'."""
+    try:
+        return [int(x) for x in version_str.split(".")]
+    except ValueError:
+        return [0]
+
+
+def filter_supported_eol_entries(eol_data, today):
+    """Filter endoflife.date entries to those still supported.
+
+    Considers both ``eol`` and ``extendedSupport`` fields. Returns the
+    filtered list sorted by cycle version (newest first).
+    """
+    supported = []
+    for entry in eol_data:
+        eol = entry.get("eol", "N/A")
+        ext = entry.get("extendedSupport", "N/A")
+        has_support = False
+        if eol == "N/A":
+            has_support = True
+        elif isinstance(eol, bool):
+            has_support = not eol
+        elif isinstance(eol, str) and eol > today:
+            has_support = True
+        if not has_support and isinstance(ext, str) and ext > today:
+            has_support = True
+        if has_support:
+            supported.append(entry)
+    supported.sort(key=lambda e: ver_sort_key(e["cycle"]), reverse=True)
+    return supported

skills/prow/scripts/analyze_coverage.py

@@ -24,8 +24,8 @@
 from datetime import datetime, timezone
 from pathlib import Path
 
-from rhdh_prow import ver_sort_key
 from rhdh_prow.repo import resolve_repo_root
+from rhdh_prow.utils import ver_sort_key
 from rhdh_prow.yaml import extract_branch, fetch_yaml, list_yaml_files
 
 POOL_DIR = "clusters/hosted-mgmt/hive/pools/rhdh"