refactor(e2e): move about:blank cleanup from try/finally to test.afterEach

Move the WebSocket teardown workaround (page.goto('about:blank')) from
per-test try/finally blocks into test.afterEach hooks. This is cleaner:
the cleanup is declared once per describe block and applies to all tests
that use the page fixture, without wrapping test bodies.

Assisted-by: OpenCode

Author: zdrapela

e2e-tests/playwright/e2e/configuration-test/config-map.spec.ts

@@ -26,6 +26,13 @@ test.describe("Change app-config at e2e test runtime", () => {
     await ensureRuntimeDeployed();
   });
 
+  // Navigate away from RHDH to close WebSocket connections before
+  // Playwright tears down the page — prevents a long hang during
+  // context/trace cleanup.
+  test.afterEach(async ({ page }) => {
+    await page.goto("about:blank").catch(() => {});
+  });
+
   test("Verify title change after ConfigMap modification", async ({ page }) => {
     test.setTimeout(300000);
 
@@ -60,11 +67,6 @@ test.describe("Change app-config at e2e test runtime", () => {
     } catch (error) {
       console.log(`Test failed during ConfigMap update or deployment restart:`, error);
       throw error;
-    } finally {
-      // Navigate away from RHDH to close WebSocket connections before
-      // Playwright tears down the page — prevents a long hang during
-      // context/trace cleanup.
-      await page.goto("about:blank").catch(() => {});
     }
   });
 });

e2e-tests/playwright/e2e/external-database/verify-tls-config-with-external-azure-db.spec.ts

@@ -89,6 +89,10 @@ test.describe("Verify TLS configuration with Azure Database for PostgreSQL healt
         });
       });
 
+      test.afterEach(async ({ page }) => {
+        await page.goto("about:blank").catch(() => {});
+      });
+
       test("Configure and restart deployment", async ({}, testInfo) => {
         if (!config.host) {
           testInfo.skip(true, `AZURE_DB_*_HOST not set for ${config.name}`);
@@ -105,14 +109,10 @@ test.describe("Verify TLS configuration with Azure Database for PostgreSQL healt
       });
 
       test("Verify successful DB connection", async ({ page }) => {
-        try {
-          const uiHelper = new UIhelper(page);
-          const common = new Common(page);
-          await common.loginAsGuest();
-          await uiHelper.verifyHeading("Welcome back!");
-        } finally {
-          await page.goto("about:blank").catch(() => {});
-        }
+        const uiHelper = new UIhelper(page);
+        const common = new Common(page);
+        await common.loginAsGuest();
+        await uiHelper.verifyHeading("Welcome back!");
       });
     });
   }

e2e-tests/playwright/e2e/external-database/verify-tls-config-with-external-rds.spec.ts

@@ -89,6 +89,10 @@ test.describe("Verify TLS configuration with RDS PostgreSQL health check", () =>
         });
       });
 
+      test.afterEach(async ({ page }) => {
+        await page.goto("about:blank").catch(() => {});
+      });
+
       test("Configure and restart deployment", async ({}, testInfo) => {
         if (!config.host) {
           testInfo.skip(true, `RDS_*_HOST not set for ${config.name}`);
@@ -105,14 +109,10 @@ test.describe("Verify TLS configuration with RDS PostgreSQL health check", () =>
       });
 
       test("Verify successful DB connection", async ({ page }) => {
-        try {
-          const uiHelper = new UIhelper(page);
-          const common = new Common(page);
-          await common.loginAsGuest();
-          await uiHelper.verifyHeading("Welcome back!");
-        } finally {
-          await page.goto("about:blank").catch(() => {});
-        }
+        const uiHelper = new UIhelper(page);
+        const common = new Common(page);
+        await common.loginAsGuest();
+        await uiHelper.verifyHeading("Welcome back!");
       });
     });
   }

e2e-tests/playwright/e2e/plugin-division-mode-schema/verify-schema-mode.spec.ts

@@ -156,6 +156,10 @@ test.describe("Verify pluginDivisionMode: schema", () => {
     await killPortForward(portForwardProcess);
   });
 
+  test.afterEach(async ({ page }) => {
+    await page.goto("about:blank").catch(() => {});
+  });
+
   test("Verify database user has restricted permissions", async () => {
     const hasRestrictedPerms = await testSetup.verifyRestrictedDatabasePermissions();
     expect(hasRestrictedPerms).toBe(true);
@@ -181,17 +185,10 @@ test.describe("Verify pluginDivisionMode: schema", () => {
     }
 
     const common = new Common(page);
-    try {
-      await common.loginAsGuest();
+    await common.loginAsGuest();
 
-      await expect(page.getByRole("heading", { level: 1 })).toBeVisible();
+    await expect(page.getByRole("heading", { level: 1 })).toBeVisible();
 
-      console.log("RHDH is accessible - plugins successfully created schemas in schema mode");
-    } finally {
-      // Navigate away from RHDH to close WebSocket connections before
-      // Playwright tears down the page — prevents a long hang during
-      // context/trace cleanup.
-      await page.goto("about:blank").catch(() => {});
-    }
+    console.log("RHDH is accessible - plugins successfully created schemas in schema mode");
   });
 });