fix(e2e): apply Playwright assertion fixes in oxlint pedantic PR

Use plain await for deployment restart, expect().toBeVisible() for the
About card link, and table-scoped verifyText for catalog Name checks.
Register restartDeployment as an assert helper for expect-expect.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: schultzp2020

e2e-tests/oxlint.config.ts

@@ -166,6 +166,7 @@ export default defineConfig({
               "verifyTextInSelector",
               "verifyPartialTextInSelector",
               "loginAsGuest",
+              "restartDeployment",
               "waitForTitle",
             ],
           },

e2e-tests/playwright/e2e/external-database/verify-tls-config-with-external-azure-db.spec.ts

@@ -1,4 +1,4 @@
-import { test, expect } from "@support/coverage/test";
+import { test } from "@support/coverage/test";
 import { UIhelper } from "../../utils/ui-helper";
 import { Common } from "../../utils/common";
 import { KubeClient, getRhdhDeploymentName } from "../../utils/kube-client";
@@ -92,9 +92,7 @@ test.describe("Verify TLS configuration with Azure Database for PostgreSQL healt
           user: azureUser,
           password: azurePassword,
         });
-        await expect(
-          kubeClient.restartDeployment(deploymentName, namespace),
-        ).resolves.toBeUndefined();
+        await kubeClient.restartDeployment(deploymentName, namespace);
       });
 
       test("Verify successful DB connection", async ({ page }) => {

e2e-tests/playwright/e2e/external-database/verify-tls-config-with-external-rds.spec.ts

@@ -1,4 +1,4 @@
-import { test, expect } from "@support/coverage/test";
+import { test } from "@support/coverage/test";
 import { UIhelper } from "../../utils/ui-helper";
 import { Common } from "../../utils/common";
 import { KubeClient, getRhdhDeploymentName } from "../../utils/kube-client";
@@ -88,9 +88,7 @@ test.describe("Verify TLS configuration with RDS PostgreSQL health check", () =>
           user: rdsUser,
           password: rdsPassword,
         });
-        await expect(
-          kubeClient.restartDeployment(deploymentName, namespace),
-        ).resolves.toBeUndefined();
+        await kubeClient.restartDeployment(deploymentName, namespace);
       });
 
       test("Verify successful DB connection", async ({ page }) => {

e2e-tests/playwright/e2e/plugins/scaffolder-relation-processor/scaffolder-relation-processor.spec.ts

@@ -51,10 +51,7 @@ test.describe.serial("Test Scaffolder Relation Processor Plugin", () => {
 
   test("Register the template for scaffolder relation processor", async () => {
     await uiHelper.openSidebar("Catalog");
-    // Wait for the Catalog page table to fully load before proceeding
-    await expect(page.getByText("Name", { exact: true }).first()).toBeVisible({
-      timeout: 20000,
-    });
+    await uiHelper.verifyText("Name");
 
     await uiHelper.clickButton("Self-service");
     await uiHelper.verifyHeading("Self-service");

e2e-tests/playwright/support/pages/backstage-showcase.ts

@@ -58,12 +58,7 @@ export class BackstageShowcase {
   async verifyAboutCardIsDisplayed() {
     const url =
       "https://github.com/redhat-developer/rhdh/tree/main/catalog-entities/components/";
-    const isLinkVisible = await this.page
-      .locator(`a[href="${url}"]`)
-      .isVisible();
-    if (!isLinkVisible) {
-      throw new Error("About card is not displayed");
-    }
+    await expect(this.page.locator(`a[href="${url}"]`)).toBeVisible();
   }
 
   async verifyPRRows(