feat(e2e): enable oxlint pedantic and burn down violations

Turn on pedantic-as-error with prefer-readonly-parameter-types disabled
for test helpers, then fix ~635 violations via stricter booleans, nullish
coalescing, module splits for oversized files, and deprecated selector migrations.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: schultzp2020

e2e-tests/oxlint.config.ts

@@ -13,6 +13,7 @@ export default defineConfig({
   categories: {
     correctness: "error",
     suspicious: "error",
+    pedantic: "error",
   },
   options: {
     typeAware: true,
@@ -25,6 +26,7 @@ export default defineConfig({
     "test-results/**",
     "coverage/**",
     ".local-test/**",
+    "scripts/**",
   ],
   rules: {
     "typescript/no-floating-promises": "error",
@@ -34,6 +36,7 @@ export default defineConfig({
     "typescript/no-unsafe-call": "error",
     "typescript/no-unsafe-return": "error",
     "typescript/strict-void-return": "error",
+    "typescript/prefer-readonly-parameter-types": "off",
     "check-file/filename-naming-convention": [
       "error",
       {
@@ -72,6 +75,58 @@ export default defineConfig({
       files: ["playwright/e2e/auth-providers/**/*.spec.ts"],
       rules: {
         "typescript/strict-void-return": "off",
+        "typescript/no-misused-promises": "off",
+      },
+    },
+    {
+      files: ["**/*.spec.ts", "**/*.test.ts"],
+      rules: {
+        "eslint/max-lines": "off",
+        "eslint/max-lines-per-function": "off",
+      },
+    },
+    {
+      files: [
+        "playwright/utils/kube-client.ts",
+        "playwright/utils/kube-client-*.ts",
+        "playwright/utils/common.ts",
+        "playwright/utils/common-auth-popup.ts",
+        "playwright/utils/ui-helper.ts",
+        "playwright/utils/ui-helper/**/*.ts",
+        "playwright/utils/api-helper.ts",
+        "playwright/utils/postgres-config.ts",
+        "playwright/utils/authentication-providers/rhdh-deployment.ts",
+        "playwright/utils/authentication-providers/rhdh-deployment-*.ts",
+        "playwright/utils/authentication-providers/msgraph-helper.ts",
+        "playwright/utils/authentication-providers/msgraph-helper-nsg.ts",
+        "playwright/e2e/audit-log/log-utils.ts",
+        "playwright/e2e/plugin-division-mode-schema/schema-mode-setup.ts",
+        "playwright/e2e/plugin-division-mode-schema/schema-mode-db.ts",
+        "playwright/support/selectors/semantic-selectors*.ts",
+        "playwright/data/rbac-constants.ts",
+      ],
+      rules: {
+        "eslint/max-lines": "off",
+        "eslint/max-lines-per-function": "off",
+        "eslint/max-depth": "off",
+      },
+    },
+    {
+      files: ["playwright/e2e/localization/locale.ts"],
+      rules: {
+        "import/max-dependencies": "off",
+      },
+    },
+    {
+      files: ["playwright/utils/kube-client.ts"],
+      rules: {
+        "import/max-dependencies": "off",
+      },
+    },
+    {
+      files: ["playwright/utils/authentication-providers/rhdh-deployment.ts"],
+      rules: {
+        "import/max-dependencies": "off",
       },
     },
     {

e2e-tests/playwright.config.ts

@@ -2,8 +2,8 @@ import { defineConfig, devices } from "@playwright/test";
 import type { ReporterDescription } from "@playwright/test";
 import { PW_PROJECT } from "./playwright/projects";
 
-process.env.JOB_NAME = process.env.JOB_NAME || "";
-process.env.IS_OPENSHIFT = process.env.IS_OPENSHIFT || "";
+process.env.JOB_NAME = process.env.JOB_NAME ?? "";
+process.env.IS_OPENSHIFT = process.env.IS_OPENSHIFT ?? "";
 
 // Set LOCALE based on which project is being run
 const args = process.argv;
@@ -26,26 +26,27 @@ if (args.some((arg) => arg.includes(PW_PROJECT.SHOWCASE_LOCALIZATION_DE))) {
   args.some((arg) => arg.includes(PW_PROJECT.SHOWCASE_LOCALIZATION_JA))
 ) {
   process.env.LOCALE = "ja";
-} else if (!process.env.LOCALE) {
+} else if (process.env.LOCALE === undefined || process.env.LOCALE === "") {
   process.env.LOCALE = "en";
 }
 
 const k8sSpecificConfig = {
   use: {
     actionTimeout: 15 * 1000,
   },
+  // Global expect timeout
   expect: {
-    timeout: 15 * 1000, // Global expect timeout
+    timeout: 15 * 1000,
   },
 };
 
 export default defineConfig({
   timeout: 90 * 1000,
   testDir: "./playwright",
   /* Fail the build on CI if you accidentally left test.only in the source code. */
-  forbidOnly: !!process.env.CI,
+  forbidOnly: process.env.CI !== undefined && process.env.CI !== "",
   /* Retry on CI only */
-  retries: process.env.CI ? 2 : 0,
+  retries: process.env.CI !== undefined && process.env.CI !== "" ? 2 : 0,
   /* Opt out of parallel tests on CI. */
   workers: 3,
   /* Reporter to use. See https://playwright.dev/docs/test-reporters */
@@ -54,7 +55,7 @@ export default defineConfig({
   reporter: [
     ["html"],
     ["list"],
-    ["junit", { outputFile: process.env.JUNIT_RESULTS || "junit-results.xml" }],
+    ["junit", { outputFile: process.env.JUNIT_RESULTS ?? "junit-results.xml" }],
     ...(process.env.COLLECT_COVERAGE === "true"
       ? ([
           ["./playwright/support/coverage/reporter.ts"],
@@ -63,7 +64,7 @@ export default defineConfig({
   ],
   /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */
   use: {
-    locale: process.env.LOCALE || "en",
+    locale: process.env.LOCALE ?? "en",
     baseURL: process.env.BASE_URL,
     ignoreHTTPSErrors: true,
     trace: "on",
@@ -81,8 +82,9 @@ export default defineConfig({
     actionTimeout: 10 * 1000,
     navigationTimeout: 50 * 1000,
   },
+  // Global expect timeout
   expect: {
-    timeout: 10 * 1000, // Global expect timeout
+    timeout: 10 * 1000,
   },
 
   /* Configure projects for major browsers */
@@ -119,7 +121,8 @@ export default defineConfig({
       name: PW_PROJECT.SHOWCASE_AUTH_PROVIDERS,
       testMatch: ["**/playwright/e2e/auth-providers/*.spec.ts"],
       testIgnore: [
-        "**/playwright/e2e/auth-providers/github-happy-path.spec.ts", // temporarily disable
+        // temporarily disable github-happy-path
+        "**/playwright/e2e/auth-providers/github-happy-path.spec.ts",
         "**/playwright/e2e/external-database/verify-tls-config-with-external-rds.spec.ts",
         "**/playwright/e2e/external-database/verify-tls-config-with-external-azure-db.spec.ts",
       ],

e2e-tests/playwright/data/rbac-constants-policies.ts

@@ -0,0 +1,148 @@
+import { Policy } from "../support/api/rbac-api-structures";
+
+export const EXPECTED_POLICIES: Policy[] = [
+  {
+    entityReference: "role:default/rbac_admin",
+    permission: "policy-entity",
+    policy: "read",
+    effect: "allow",
+  },
+  {
+    entityReference: "role:default/rbac_admin",
+    permission: "policy.entity.create",
+    policy: "create",
+    effect: "allow",
+  },
+  {
+    entityReference: "role:default/rbac_admin",
+    permission: "policy-entity",
+    policy: "delete",
+    effect: "allow",
+  },
+  {
+    entityReference: "role:default/rbac_admin",
+    permission: "policy-entity",
+    policy: "update",
+    effect: "allow",
+  },
+  {
+    entityReference: "role:default/rbac_admin",
+    permission: "catalog-entity",
+    policy: "read",
+    effect: "allow",
+  },
+  {
+    entityReference: "role:default/guests",
+    permission: "catalog.entity.create",
+    policy: "create",
+    effect: "allow",
+  },
+  {
+    entityReference: "role:default/team_a",
+    permission: "catalog-entity",
+    policy: "read",
+    effect: "allow",
+  },
+  {
+    entityReference: "role:xyz/team_a",
+    permission: "catalog-entity",
+    policy: "read",
+    effect: "allow",
+  },
+  {
+    entityReference: "role:xyz/team_a",
+    permission: "catalog.entity.create",
+    policy: "create",
+    effect: "allow",
+  },
+  {
+    entityReference: "role:xyz/team_a",
+    permission: "catalog.location.create",
+    policy: "create",
+    effect: "allow",
+  },
+  {
+    entityReference: "role:xyz/team_a",
+    permission: "catalog.location.read",
+    policy: "read",
+    effect: "allow",
+  },
+  {
+    entityReference: "role:default/qe_rbac_admin",
+    permission: "kubernetes.proxy",
+    policy: "use",
+    effect: "allow",
+  },
+  {
+    entityReference: "role:default/qe_rbac_admin",
+    permission: "kubernetes.resources.read",
+    policy: "read",
+    effect: "allow",
+  },
+  {
+    entityReference: "role:default/qe_rbac_admin",
+    permission: "kubernetes.clusters.read",
+    policy: "read",
+    effect: "allow",
+  },
+  {
+    entityReference: "role:default/qe_rbac_admin",
+    permission: "catalog.entity.create",
+    policy: "create",
+    effect: "allow",
+  },
+  {
+    entityReference: "role:default/qe_rbac_admin",
+    permission: "catalog.location.create",
+    policy: "create",
+    effect: "allow",
+  },
+  {
+    entityReference: "role:default/qe_rbac_admin",
+    permission: "catalog.location.read",
+    policy: "read",
+    effect: "allow",
+  },
+  {
+    entityReference: "role:default/kubernetes_reader",
+    permission: "kubernetes.resources.read",
+    policy: "read",
+    effect: "allow",
+  },
+  {
+    entityReference: "role:default/kubernetes_reader",
+    permission: "kubernetes.clusters.read",
+    policy: "read",
+    effect: "allow",
+  },
+  {
+    entityReference: "role:default/catalog_reader",
+    permission: "catalog.entity.read",
+    policy: "read",
+    effect: "allow",
+  },
+  {
+    entityReference: "role:default/all_resource_reader",
+    permission: "catalog-entity",
+    policy: "read",
+    effect: "allow",
+  },
+  {
+    entityReference: "role:default/all_resource_reader",
+    permission: "catalog-entity",
+    policy: "create",
+    effect: "allow",
+  },
+  {
+    entityReference: "role:default/all_resource_denier",
+    permission: "catalog-entity",
+    policy: "read",
+    effect: "deny",
+  },
+  {
+    entityReference: "role:default/all_resource_denier",
+    permission: "catalog-entity",
+    policy: "create",
+    effect: "allow",
+  },
+];

e2e-tests/playwright/data/rbac-constants-roles.ts

@@ -0,0 +1,59 @@
+import { Role } from "../support/api/rbac-api-structures";
+
+export const EXPECTED_ROLES: Role[] = [
+  {
+    memberReferences: ["user:default/rhdh-qe"],
+    name: "role:default/rbac_admin",
+  },
+  {
+    memberReferences: ["user:default/guest"],
+    name: "role:default/guests",
+  },
+  {
+    memberReferences: ["user:default/user_team_a", "user:default/rhdh-qe"],
+    name: "role:default/team_a",
+  },
+  {
+    memberReferences: ["user:xyz/user"],
+    name: "role:xyz/team_a",
+  },
+  {
+    memberReferences: ["group:default/rhdh-qe-2-team"],
+    name: "role:default/test2-role",
+  },
+  {
+    memberReferences: ["user:default/rhdh-qe"],
+    name: "role:default/qe_rbac_admin",
+  },
+  {
+    memberReferences: [
+      "group:default/rhdh-qe-parent-team",
+      "group:default/rhdh-qe-child-team",
+    ],
+    name: "role:default/transitive-owner",
+  },
+  {
+    memberReferences: ["user:default/rhdh-qe-5"],
+    name: "role:default/kubernetes_reader",
+  },
+  {
+    memberReferences: ["user:default/rhdh-qe-5", "user:default/rhdh-qe-6"],
+    name: "role:default/catalog_reader",
+  },
+  {
+    memberReferences: ["user:default/rhdh-qe-7", "user:default/rhdh-qe-9"],
+    name: "role:default/all_resource_reader",
+  },
+  {
+    memberReferences: ["user:default/rhdh-qe-8"],
+    name: "role:default/all_resource_denier",
+  },
+  {
+    memberReferences: ["user:default/rhdh-qe-7", "user:default/rhdh-qe-8"],
+    name: "role:default/owned_resource_reader",
+  },
+  {
+    memberReferences: ["user:default/rhdh-qe-9"],
+    name: "role:default/conditional_denier",
+  },
+];