feat(e2e): complete hardening — POMs, fixtures, naming, a11y gate

Migrate all specs off direct UIhelper usage into page objects, add global
RHDH health setup and managed browser sessions, replace waitForSelector,
remove deprecated showcase selectors, rename catalog constants, enforce
critical axe violations, add stability script, and native fetch in Keycloak.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: schultzp2020

e2e-tests/README.md

@@ -201,6 +201,7 @@ letting CI or a local run target a subset.
 | `@smoke`             | Fast, high-signal check suitable to run on every PR.                                      |
 | `@ga-plugin`         | Exercises a generally-available (GA) plugin.                                              |
 | `@non-ga-plugin`     | Exercises a tech-preview / dev-preview (non-GA) plugin.                                   |
+| `@blocked`           | Blocked by a known issue; tests are skipped with a Jira reference.                        |
 
 ```bash
 # Run only smoke-tagged tests
@@ -404,18 +405,24 @@ This opens an interactive UI where you can select individual tests, watch them r
 
 After running `local-test-setup.sh`, these variables are set:
 
-| Variable                    | Description                                   |
-| --------------------------- | --------------------------------------------- |
-| `BASE_URL`                  | URL of the deployed RHDH instance             |
-| `SHOWCASE_URL`              | Showcase deployment URL                       |
-| `SHOWCASE_RBAC_URL`         | Showcase RBAC deployment URL                  |
-| `K8S_CLUSTER_URL`           | OpenShift API server URL                      |
-| `K8S_CLUSTER_TOKEN`         | Service account token (48-hour duration)      |
-| `JOB_NAME`                  | Selected job name                             |
-| `IMAGE_REGISTRY`            | Image registry (default: `quay.io`)           |
-| `IMAGE_REPO`                | Image repository (fallback: `QUAY_REPO`)      |
-| `TAG_NAME`                  | Image tag                                     |
-| Plus all secrets from Vault | (exported with `-`, `.`, `/` replaced by `_`) |
+| Variable                    | Description                                                                                    |
+| --------------------------- | ---------------------------------------------------------------------------------------------- |
+| `BASE_URL`                  | URL of the deployed RHDH instance (Playwright uses this as the test base URL)                  |
+| `SHOWCASE_URL`              | Legacy name for the standard RHDH deployment URL (same value as `BASE_URL` for showcase tests) |
+| `SHOWCASE_RBAC_URL`         | Legacy name for the RBAC deployment URL                                                        |
+| `K8S_CLUSTER_URL`           | OpenShift API server URL                                                                       |
+| `K8S_CLUSTER_TOKEN`         | Service account token (48-hour duration)                                                       |
+| `JOB_NAME`                  | Selected job name                                                                              |
+| `IMAGE_REGISTRY`            | Image registry (default: `quay.io`)                                                            |
+| `IMAGE_REPO`                | Image repository (fallback: `QUAY_REPO`)                                                       |
+| `TAG_NAME`                  | Image tag                                                                                      |
+| Plus all secrets from Vault | (exported with `-`, `.`, `/` replaced by `_`)                                                  |
+
+> **Note:** `BASE_URL` is the canonical Playwright base URL for the RHDH instance under test.
+> `SHOWCASE_URL` and `SHOWCASE_RBAC_URL` are legacy names retained by `local-test-setup.sh` and
+> deployment scripts; `local-test-setup.sh` sets `BASE_URL` from the appropriate legacy URL.
+> Yarn scripts such as `yarn showcase`, `yarn showcase-rbac`, and `yarn test:stability` still use
+> the `showcase` Playwright project name for historical reasons.
 
 ### Artifacts and Logs
 

e2e-tests/oxlint.config.ts

@@ -142,19 +142,37 @@ export default defineConfig({
               "expect",
               "toPass",
               "verifyHeading",
+              "verifyWelcomeHeading",
+              "verifyGuestProfile",
+              "verifySignInPageTitle",
+              "verifyProfileHeading",
+              "verifySignInError",
               "verifyQuickAccess",
               "verifyLink",
               "verifyRowsInTable",
               "verifyDivHasText",
               "verifyComponentInCatalog",
+              "verifyComponentsInCatalog",
               "verifyParagraph",
               "verifyText",
               "verifyTextinCard",
+              "verifyTextInCard",
               "verifyVisitedCardContent",
               "verifyAboutCardIsDisplayed",
               "verifyPRStatisticsRendered",
               "verifyPRRows",
               "verifyPRRowsPerPage",
+              "verifyTestPageContent",
+              "verifyContextOneCard",
+              "verifyContextTwoCard",
+              "verifyTemplatesHeading",
+              "verifyDocumentationHeading",
+              "verifyDocHeading",
+              "verifyCreateReactAppReviewTableWithGroupOwner",
+              "verifyDependencyGraphLabels",
+              "launchTemplateAndVerifyIntro",
+              "runHttpRequestTemplateFlow",
+              "inspectEntityAndVerifyYaml",
               "registerExistingComponent",
               "validateLog",
               "validateLogEvent",

e2e-tests/package.json

@@ -7,6 +7,7 @@
     "node": "24"
   },
   "scripts": {
+    "test:stability": "playwright test --project=showcase --retries=0",
     "showcase": "playwright test --project=showcase",
     "showcase-rbac": "playwright test --project=showcase-rbac",
     "showcase-k8s": "playwright test --project=showcase-k8s",
@@ -36,7 +37,6 @@
     "@playwright/test": "1.59.1",
     "@types/js-yaml": "^4.0.9",
     "@types/node": "24.12.2",
-    "@types/node-fetch": "^2.6.13",
     "@types/pg": "8.20.0",
     "eslint-plugin-check-file": "3.3.1",
     "eslint-plugin-playwright": "2.10.4",
@@ -57,7 +57,6 @@
     "@microsoft/microsoft-graph-client": "3.0.7",
     "isomorphic-fetch": "3.0.0",
     "js-yaml": "4.1.1",
-    "node-fetch": "2.7.0",
     "octokit": "4.1.4",
     "pg": "8.22.0",
     "uuid": "14.0.0",

e2e-tests/playwright.config.ts

@@ -41,6 +41,7 @@ const k8sSpecificConfig = {
 };
 
 export default defineConfig({
+  globalSetup: "./playwright/global-setup.ts",
   timeout: 90 * 1000,
   testDir: "./playwright",
   /* Fail the build on CI if you accidentally left test.only in the source code. */

e2e-tests/playwright/e2e/audit-log/auditor-catalog.spec.ts

@@ -1,9 +1,10 @@
 import { test } from "@support/coverage/test";
 import { Common } from "../../utils/common";
-import { UIhelper } from "../../utils/ui-helper";
 import { LogUtils } from "./log-utils";
 import { CatalogImport } from "../../support/pages/catalog-import";
 import { APIHelper } from "../../utils/api-helper";
+import { SelfServicePage } from "../../support/pages/self-service-page";
+
 const template =
   "https://github.com/janus-qe/sample-service/blob/main/demo_template.yaml";
 const entityName = "hello-world-2";
@@ -26,7 +27,7 @@ async function ensureEntityDoesNotExist() {
 }
 
 test.describe.serial("Audit Log check for Catalog Plugin", () => {
-  let uiHelper: UIhelper;
+  let selfServicePage: SelfServicePage;
   let common: Common;
   let catalogImport: CatalogImport;
 
@@ -38,16 +39,16 @@ test.describe.serial("Audit Log check for Catalog Plugin", () => {
   });
 
   test.beforeEach(async ({ page }) => {
-    uiHelper = new UIhelper(page);
+    selfServicePage = new SelfServicePage(page);
     common = new Common(page);
     catalogImport = new CatalogImport(page);
     await common.loginAsGuest();
-    await uiHelper.goToSelfServicePage();
+    await selfServicePage.open();
   });
 
   test("Should fetch logs for entity-mutate event and validate log structure and values", async () => {
     await ensureEntityExists();
-    await uiHelper.clickButton("Import an existing Git repository");
+    await selfServicePage.clickImportGitRepository();
     await catalogImport.registerExistingComponent(template, false);
     await LogUtils.validateLogEvent(
       "entity-mutate",
@@ -64,7 +65,7 @@ test.describe.serial("Audit Log check for Catalog Plugin", () => {
 
   test("Should fetch logs for location-mutate event and validate log structure and values", async () => {
     await ensureEntityDoesNotExist();
-    await uiHelper.clickButton("Import an existing Git repository");
+    await selfServicePage.clickImportGitRepository();
     await catalogImport.registerExistingComponent(template, false);
     await LogUtils.validateLogEvent(
       "location-mutate",

e2e-tests/playwright/e2e/audit-log/auditor-rbac.spec.ts

@@ -1,5 +1,9 @@
 import { test, expect, Page } from "@support/coverage/test";
-import { Common, setupBrowser, teardownBrowser } from "../../utils/common";
+import { Common } from "../../utils/common";
+import {
+  createManagedBrowserSession,
+  type ManagedBrowserSession,
+} from "../../support/fixtures/managed-browser";
 import {
   RBAC_API,
   ROLE_NAME,
@@ -26,6 +30,7 @@ let rbacApi: RhdhRbacApi;
 
 test.describe("Auditor check for RBAC Plugin", () => {
   let page: Page;
+  let browserSession: ManagedBrowserSession;
 
   test.beforeAll(async ({ browser }, testInfo) => {
     test.info().annotations.push({
@@ -34,7 +39,8 @@ test.describe("Auditor check for RBAC Plugin", () => {
     });
 
     await (await import("./log-utils")).LogUtils.loginToOpenShift();
-    page = (await setupBrowser(browser, testInfo)).page;
+    browserSession = await createManagedBrowserSession(browser, testInfo);
+    page = browserSession.page;
     common = new Common(page);
     await common.loginAsKeycloakUser();
     rbacApi = await RhdhRbacApi.buildRbacApi(page);
@@ -300,7 +306,7 @@ test.describe("Auditor check for RBAC Plugin", () => {
     ).resolves.toBeUndefined();
   });
 
-  test.afterAll(async (_args, testInfo) => {
-    await teardownBrowser(page, testInfo);
+  test.afterAll(async () => {
+    await browserSession.dispose();
   });
 });

e2e-tests/playwright/e2e/auth-providers/github.spec.ts

@@ -1,10 +1,15 @@
 import { test, expect, Page, BrowserContext } from "@support/coverage/test";
 import RHDHDeployment from "../../utils/authentication-providers/rhdh-deployment";
-import { Common, setupBrowser, teardownBrowser } from "../../utils/common";
-import { UIhelper } from "../../utils/ui-helper";
+import { Common } from "../../utils/common";
 import { NO_USER_FOUND_IN_CATALOG_ERROR_MESSAGE } from "../../utils/constants";
+import { SettingsPage } from "../../support/pages/settings-page";
+import {
+  createManagedBrowserSession,
+  type ManagedBrowserSession,
+} from "../../support/fixtures/managed-browser";
 let page: Page;
 let context: BrowserContext;
+let browserSession: ManagedBrowserSession;
 
 /* SUPORTED RESOLVERS
 GITHUB:
@@ -17,7 +22,7 @@ GITHUB:
 // oxlint-disable-next-line eslint/require-await -- top-level await configures test.use baseURL
 test.describe("Configure Github Provider", async () => {
   let common: Common;
-  let uiHelper: UIhelper;
+  let settingsPage: SettingsPage;
 
   const namespace = "albarbaro-test-namespace-github";
   const appConfigMap = "app-config-rhdh";
@@ -53,9 +58,11 @@ test.describe("Configure Github Provider", async () => {
     await deployment.loadAllConfigs();
 
     // setup playwright helpers
-    ({ context, page } = await setupBrowser(browser, testInfo));
+    browserSession = await createManagedBrowserSession(browser, testInfo);
+    context = browserSession.context;
+    page = browserSession.page;
     common = new Common(page);
-    uiHelper = new UIhelper(page);
+    settingsPage = new SettingsPage(page);
 
     // expect some expected variables
 
@@ -146,8 +153,8 @@ test.describe("Configure Github Provider", async () => {
     );
     expect(login).toBe("Login successful");
 
-    await uiHelper.goToSettingsPage();
-    await uiHelper.verifyHeading("RHDH QE Admin");
+    await settingsPage.open();
+    await settingsPage.verifyProfileHeading("RHDH QE Admin");
     await common.signOut();
     await context.clearCookies();
   });
@@ -170,8 +177,8 @@ test.describe("Configure Github Provider", async () => {
     );
     expect(login).toBe("Login successful");
 
-    await uiHelper.goToSettingsPage();
-    await uiHelper.verifyHeading("RHDH QE Admin");
+    await settingsPage.open();
+    await settingsPage.verifyProfileHeading("RHDH QE Admin");
     await common.signOut();
     await context.clearCookies();
   });
@@ -197,7 +204,7 @@ test.describe("Configure Github Provider", async () => {
     );
     expect(login).toBe("Login successful");
 
-    await uiHelper.verifyAlertErrorMessage(
+    await settingsPage.verifySignInError(
       NO_USER_FOUND_IN_CATALOG_ERROR_MESSAGE,
     );
     await context.clearCookies();
@@ -227,7 +234,7 @@ test.describe("Configure Github Provider", async () => {
 
     expect(login).toBe("Login successful");
 
-    await uiHelper.verifyAlertErrorMessage(
+    await settingsPage.verifySignInError(
       NO_USER_FOUND_IN_CATALOG_ERROR_MESSAGE,
     );
     await context.clearCookies();
@@ -271,8 +278,8 @@ test.describe("Configure Github Provider", async () => {
     expect(actualDuration).toBeGreaterThan(threeDays - tolerance);
     expect(actualDuration).toBeLessThan(threeDays + tolerance);
 
-    await uiHelper.goToSettingsPage();
-    await uiHelper.verifyHeading("RHDH QE Admin");
+    await settingsPage.open();
+    await settingsPage.verifyProfileHeading("RHDH QE Admin");
     await common.signOut();
     await context.clearCookies();
   });
@@ -348,15 +355,15 @@ test.describe("Configure Github Provider", async () => {
 
     expect(login).toBe("Login successful");
 
-    await uiHelper.verifyAlertErrorMessage(
+    await settingsPage.verifySignInError(
       /Login failed; caused by Error: The GitHub provider is not configured to support sign-in/u,
     );
     await context.clearCookies();
   });
 
   test.afterAll(async () => {
-    if (page !== undefined) {
-      await teardownBrowser(page, test.info());
+    if (browserSession !== undefined) {
+      await browserSession.dispose();
     }
     console.log("[TEST] Starting cleanup...");
     await deployment.killRunningProcess();

e2e-tests/playwright/e2e/auth-providers/gitlab.spec.ts

@@ -1,10 +1,15 @@
 import { test, expect, Page, BrowserContext } from "@support/coverage/test";
 import RHDHDeployment from "../../utils/authentication-providers/rhdh-deployment";
-import { Common, setupBrowser, teardownBrowser } from "../../utils/common";
-import { UIhelper } from "../../utils/ui-helper";
+import { Common } from "../../utils/common";
 import { GitLabHelper } from "../../utils/authentication-providers/gitlab-helper";
+import { SettingsPage } from "../../support/pages/settings-page";
+import {
+  createManagedBrowserSession,
+  type ManagedBrowserSession,
+} from "../../support/fixtures/managed-browser";
 let page: Page;
 let context: BrowserContext;
+let browserSession: ManagedBrowserSession;
 
 /* SUPORTED RESOLVERS
 GITLAB:
@@ -17,7 +22,7 @@ GITLAB:
 // oxlint-disable-next-line eslint/require-await -- top-level await configures test.use baseURL
 test.describe("Configure GitLab Provider", async () => {
   let common: Common;
-  let uiHelper: UIhelper;
+  let settingsPage: SettingsPage;
   let gitlabHelper: GitLabHelper;
   let oauthAppId: number | null = null;
 
@@ -55,9 +60,11 @@ test.describe("Configure GitLab Provider", async () => {
     await deployment.loadAllConfigs();
 
     // setup playwright helpers
-    ({ context, page } = await setupBrowser(browser, testInfo));
+    browserSession = await createManagedBrowserSession(browser, testInfo);
+    context = browserSession.context;
+    page = browserSession.page;
     common = new Common(page);
-    uiHelper = new UIhelper(page);
+    settingsPage = new SettingsPage(page);
 
     // expect some expected variables
     expect(process.env.AUTH_PROVIDERS_GITLAB_HOST!).toBeDefined();
@@ -158,8 +165,8 @@ test.describe("Configure GitLab Provider", async () => {
     );
     expect(login).toBe("Login successful");
 
-    await uiHelper.goToSettingsPage();
-    await uiHelper.verifyHeading("user1");
+    await settingsPage.open();
+    await settingsPage.verifyProfileHeading("user1");
     await common.signOut();
     await context.clearCookies();
   });
@@ -247,8 +254,8 @@ test.describe("Configure GitLab Provider", async () => {
   });
 
   test.afterAll(async () => {
-    if (page !== undefined) {
-      await teardownBrowser(page, test.info());
+    if (browserSession !== undefined) {
+      await browserSession.dispose();
     }
     console.log("[TEST] Starting cleanup...");