feat(e2e): harden browser lifecycle, smoke gate, and naming

Close browser contexts in teardownBrowser, add teardown to auth-provider
specs, wait for /healthcheck before smoke login and drop 10 retries,
replace dispatchEvent clicks with native Playwright actions, and rename
BackstageShowcase to RhdhInstance with dedicated table page object.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: schultzp2020

e2e-tests/playwright.config.ts

@@ -92,7 +92,6 @@ export default defineConfig({
     {
       name: PW_PROJECT.SMOKE_TEST,
       testMatch: "**/playwright/e2e/smoke-test.spec.ts",
-      retries: 10,
     },
     {
       name: PW_PROJECT.SHOWCASE,

e2e-tests/playwright/e2e/auth-providers/github.spec.ts

@@ -1,6 +1,6 @@
 import { test, expect, Page, BrowserContext } from "@support/coverage/test";
 import RHDHDeployment from "../../utils/authentication-providers/rhdh-deployment";
-import { Common, setupBrowser } from "../../utils/common";
+import { Common, setupBrowser, teardownBrowser } from "../../utils/common";
 import { UIhelper } from "../../utils/ui-helper";
 import { NO_USER_FOUND_IN_CATALOG_ERROR_MESSAGE } from "../../utils/constants";
 let page: Page;
@@ -355,6 +355,9 @@ test.describe("Configure Github Provider", async () => {
   });
 
   test.afterAll(async () => {
+    if (page !== undefined) {
+      await teardownBrowser(page, test.info());
+    }
     console.log("[TEST] Starting cleanup...");
     await deployment.killRunningProcess();
     console.log("[TEST] Cleanup completed");

e2e-tests/playwright/e2e/auth-providers/gitlab.spec.ts

@@ -1,6 +1,6 @@
 import { test, expect, Page, BrowserContext } from "@support/coverage/test";
 import RHDHDeployment from "../../utils/authentication-providers/rhdh-deployment";
-import { Common, setupBrowser } from "../../utils/common";
+import { Common, setupBrowser, teardownBrowser } from "../../utils/common";
 import { UIhelper } from "../../utils/ui-helper";
 import { GitLabHelper } from "../../utils/authentication-providers/gitlab-helper";
 let page: Page;
@@ -247,6 +247,9 @@ test.describe("Configure GitLab Provider", async () => {
   });
 
   test.afterAll(async () => {
+    if (page !== undefined) {
+      await teardownBrowser(page, test.info());
+    }
     console.log("[TEST] Starting cleanup...");
 
     // Delete the dynamically created OAuth application

e2e-tests/playwright/e2e/auth-providers/ldap.spec.ts

@@ -1,6 +1,6 @@
 import { test, expect, Page, BrowserContext } from "@support/coverage/test";
 import RHDHDeployment from "../../utils/authentication-providers/rhdh-deployment";
-import { Common, setupBrowser } from "../../utils/common";
+import { Common, setupBrowser, teardownBrowser } from "../../utils/common";
 import { UIhelper } from "../../utils/ui-helper";
 import { MSClient } from "../../utils/authentication-providers/msgraph-helper";
 
@@ -340,6 +340,9 @@ test.describe("Configure LDAP Provider", () => {
   });
 
   test.afterAll(async () => {
+    if (page !== undefined) {
+      await teardownBrowser(page, test.info());
+    }
     console.log("[TEST] Starting cleanup...");
 
     // Clean up NSG rule

e2e-tests/playwright/e2e/auth-providers/microsoft.spec.ts

@@ -1,6 +1,6 @@
 import { test, expect, Page, BrowserContext } from "@support/coverage/test";
 import RHDHDeployment from "../../utils/authentication-providers/rhdh-deployment";
-import { Common, setupBrowser } from "../../utils/common";
+import { Common, setupBrowser, teardownBrowser } from "../../utils/common";
 import { UIhelper } from "../../utils/ui-helper";
 import { MSClient } from "../../utils/authentication-providers/msgraph-helper";
 import { NO_USER_FOUND_IN_CATALOG_ERROR_MESSAGE } from "../../utils/constants";
@@ -387,6 +387,9 @@ test.describe("Configure Microsoft Provider", async () => {
   });
 
   test.afterAll(async () => {
+    if (page !== undefined) {
+      await teardownBrowser(page, test.info());
+    }
     console.log("[TEST] Starting cleanup...");
     await deployment.killRunningProcess();
 

e2e-tests/playwright/e2e/auth-providers/oidc.spec.ts

@@ -1,6 +1,6 @@
 import { test, expect, Page, BrowserContext } from "@support/coverage/test";
 import RHDHDeployment from "../../utils/authentication-providers/rhdh-deployment";
-import { Common, setupBrowser } from "../../utils/common";
+import { Common, setupBrowser, teardownBrowser } from "../../utils/common";
 import { UIhelper } from "../../utils/ui-helper";
 import { KeycloakHelper } from "../../utils/authentication-providers/keycloak-helper";
 import { NO_USER_FOUND_IN_CATALOG_ERROR_MESSAGE } from "../../utils/constants";
@@ -535,6 +535,9 @@ test.describe("Configure OIDC provider (using RHBK)", async () => {
   });
 
   test.afterAll(async () => {
+    if (page !== undefined) {
+      await teardownBrowser(page, test.info());
+    }
     console.log("[TEST] Starting cleanup...");
     await deployment.killRunningProcess();
     console.log("[TEST] Cleanup completed");

e2e-tests/playwright/e2e/github-happy-path.spec.ts

@@ -2,10 +2,7 @@ import { test, expect, Page, BrowserContext } from "@support/coverage/test";
 import { UIhelper } from "../utils/ui-helper";
 import { Common, setupBrowser, teardownBrowser } from "../utils/common";
 import { RESOURCES } from "../support/test-data/resources";
-import {
-  BackstageShowcase,
-  CatalogImport,
-} from "../support/pages/catalog-import";
+import { RhdhInstance, CatalogImport } from "../support/pages/catalog-import";
 import { TEMPLATES } from "../support/test-data/templates";
 
 type GithubPullRequest = { title: string; number: string };
@@ -38,11 +35,11 @@ function parseGithubPullRequests(data: unknown): GithubPullRequest[] {
   });
 }
 
-async function getShowcasePullRequests(
+async function getRhdhPullRequests(
   state: "open" | "closed" | "all",
   paginated = false,
 ): Promise<GithubPullRequest[]> {
-  const data: unknown = await BackstageShowcase.getShowcasePRs(
+  const data: unknown = await RhdhInstance.getRhdhPullRequests(
     state,
     paginated,
   );
@@ -57,7 +54,7 @@ test.describe.fixme("GitHub Happy path", () => {
   let common: Common;
   let uiHelper: UIhelper;
   let catalogImport: CatalogImport;
-  let backstageShowcase: BackstageShowcase;
+  let rhdhInstance: RhdhInstance;
 
   const component =
     "https://github.com/redhat-developer/rhdh/blob/main/catalog-entities/all.yaml";
@@ -72,7 +69,7 @@ test.describe.fixme("GitHub Happy path", () => {
     uiHelper = new UIhelper(page);
     common = new Common(page);
     catalogImport = new CatalogImport(page);
-    backstageShowcase = new BackstageShowcase(page);
+    rhdhInstance = new RhdhInstance(page);
     test.info().setTimeout(600 * 1000);
   });
 
@@ -173,15 +170,15 @@ test.describe.fixme("GitHub Happy path", () => {
     await page.getByRole("button", { name: "20" }).click();
     await page.getByRole("option", { name: "10", exact: true }).click();
 
-    await backstageShowcase.verifyPRStatisticsRendered();
-    await backstageShowcase.verifyAboutCardIsDisplayed();
+    await rhdhInstance.verifyPRStatisticsRendered();
+    await rhdhInstance.verifyAboutCardIsDisplayed();
   });
 
   test("Verify that the Pull/Merge Requests tab renders the 5 most recently updated Open Pull Requests", async () => {
     await uiHelper.clickTab("Pull/Merge Requests");
-    const openPRs = await getShowcasePullRequests("open");
+    const openPRs = await getRhdhPullRequests("open");
     await expect(
-      backstageShowcase.verifyPRRows(openPRs, 0, 5),
+      rhdhInstance.verifyPRRows(openPRs, 0, 5),
     ).resolves.toBeUndefined();
   });
 
@@ -191,16 +188,16 @@ test.describe.fixme("GitHub Happy path", () => {
     await expect(closedButton).toBeVisible();
     await expect(closedButton).toBeEnabled();
     await closedButton.click();
-    const closedPRs = await getShowcasePullRequests("closed");
+    const closedPRs = await getRhdhPullRequests("closed");
     await common.waitForLoad();
     await expect(
-      backstageShowcase.verifyPRRows(closedPRs, 0, 5),
+      rhdhInstance.verifyPRRows(closedPRs, 0, 5),
     ).resolves.toBeUndefined();
   });
 
   test("Click on the arrows to verify that the next/previous/first/last pages of PRs are loaded", async () => {
     console.log("Fetching all PRs from GitHub");
-    const allPRs = await getShowcasePullRequests("all", true);
+    const allPRs = await getRhdhPullRequests("all", true);
 
     console.log("Clicking on ALL button");
     // Use semantic selector and wait for button to be ready (no force needed)
@@ -209,30 +206,30 @@ test.describe.fixme("GitHub Happy path", () => {
     await expect(allButton).toBeEnabled();
     await allButton.click();
     await expect(
-      backstageShowcase.verifyPRRows(allPRs, 0, 5),
+      rhdhInstance.verifyPRRows(allPRs, 0, 5),
     ).resolves.toBeUndefined();
 
     console.log("Clicking on Next Page button");
-    await backstageShowcase.clickNextPage();
+    await rhdhInstance.clickNextPage();
     await expect(
-      backstageShowcase.verifyPRRows(allPRs, 5, 10),
+      rhdhInstance.verifyPRRows(allPRs, 5, 10),
     ).resolves.toBeUndefined();
 
     // const lastPagePRs = Math.floor((allPRs.length - 1) / 5) * 5;
     // redhat-developer/rhdh have more than 1000 PRs open/closed and by default the latest 1000 PR results are displayed.
     const lastPagePRs = 996;
 
     console.log("Clicking on Last Page button");
-    await backstageShowcase.clickLastPage();
+    await rhdhInstance.clickLastPage();
     await expect(
-      backstageShowcase.verifyPRRows(allPRs, lastPagePRs, 1000),
+      rhdhInstance.verifyPRRows(allPRs, lastPagePRs, 1000),
     ).resolves.toBeUndefined();
 
     console.log("Clicking on Previous Page button");
-    await backstageShowcase.clickPreviousPage();
+    await rhdhInstance.clickPreviousPage();
     await common.waitForLoad();
     await expect(
-      backstageShowcase.verifyPRRows(allPRs, lastPagePRs - 5, lastPagePRs - 1),
+      rhdhInstance.verifyPRRows(allPRs, lastPagePRs - 5, lastPagePRs - 1),
     ).resolves.toBeUndefined();
   });
 
@@ -241,15 +238,15 @@ test.describe.fixme("GitHub Happy path", () => {
     await uiHelper.clickLink("Red Hat Developer Hub");
     await common.clickOnGHloginPopup();
     await uiHelper.clickTab("Pull/Merge Requests");
-    const allPRs = await getShowcasePullRequests("open");
+    const allPRs = await getRhdhPullRequests("open");
     await expect(
-      backstageShowcase.verifyPRRowsPerPage(5, allPRs),
+      rhdhInstance.verifyPRRowsPerPage(5, allPRs),
     ).resolves.toBeUndefined();
     await expect(
-      backstageShowcase.verifyPRRowsPerPage(10, allPRs),
+      rhdhInstance.verifyPRRowsPerPage(10, allPRs),
     ).resolves.toBeUndefined();
     await expect(
-      backstageShowcase.verifyPRRowsPerPage(20, allPRs),
+      rhdhInstance.verifyPRRowsPerPage(20, allPRs),
     ).resolves.toBeUndefined();
   });
 

e2e-tests/playwright/e2e/smoke-test.spec.ts

@@ -1,6 +1,7 @@
 import { test } from "@support/coverage/test";
 import { UIhelper } from "../utils/ui-helper";
 import { Common } from "../utils/common";
+import { waitForRhdhReady } from "../utils/wait-for-rhdh-ready";
 
 test.describe("Smoke test", { tag: "@smoke" }, () => {
   let uiHelper: UIhelper;
@@ -13,13 +14,14 @@ test.describe("Smoke test", { tag: "@smoke" }, () => {
     });
   });
 
-  test.beforeEach(async ({ page }) => {
+  test.beforeEach(async ({ page, request }) => {
+    await waitForRhdhReady(request);
     uiHelper = new UIhelper(page);
     common = new Common(page);
     await common.loginAsGuest();
   });
 
-  test("Verify the Homepage renders", async () => {
+  test("Verify the RHDH instance homepage renders", async () => {
     await uiHelper.verifyHeading("Welcome back!");
   });
 });

e2e-tests/playwright/support/page-objects/page-obj.ts

@@ -140,6 +140,7 @@ export const KUBERNETES_COMPONENTS = {
 
 /**
  * BACKSTAGE_SHOWCASE_COMPONENTS - Table pagination selectors
+ * @deprecated Use RHDH_INSTANCE_TABLE from ./rhdh-instance-table instead
  */
 export const BACKSTAGE_SHOWCASE_COMPONENTS = {
   // Legacy selectors - maintained for backward compatibility
@@ -153,48 +154,21 @@ export const BACKSTAGE_SHOWCASE_COMPONENTS = {
   /** @deprecated Use pagination role-based selector */
   tablePageSelectBox: 'div[class*="MuiTablePagination-input"]',
 
-  // Semantic methods - preferred
-  /**
-   * Get next page button
-   * ✅ Already semantic, but wrapped for consistency
-   * @example BACKSTAGE_SHOWCASE_COMPONENTS.getNextPageButton(page).click()
-   */
   getNextPageButton: (page: Page): Locator =>
     page.getByRole("button", { name: "Next Page" }),
 
-  /**
-   * Get previous page button
-   * @example BACKSTAGE_SHOWCASE_COMPONENTS.getPreviousPageButton(page).click()
-   */
   getPreviousPageButton: (page: Page): Locator =>
     page.getByRole("button", { name: "Previous Page" }),
 
-  /**
-   * Get last page button
-   * @example BACKSTAGE_SHOWCASE_COMPONENTS.getLastPageButton(page).click()
-   */
   getLastPageButton: (page: Page): Locator =>
     page.getByRole("button", { name: "Last Page" }),
 
-  /**
-   * Get first page button
-   * @example BACKSTAGE_SHOWCASE_COMPONENTS.getFirstPageButton(page).click()
-   */
   getFirstPageButton: (page: Page): Locator =>
     page.getByRole("button", { name: "First Page" }),
 
-  /**
-   * Get table rows
-   * ✅ Preferred over tableRows
-   * @example const rows = BACKSTAGE_SHOWCASE_COMPONENTS.getTableRows(page)
-   */
   getTableRows: (page: Page): Locator =>
     SemanticSelectors.table(page).locator("tbody tr"),
 
-  /**
-   * Get specific table row by content
-   * @example const row = BACKSTAGE_SHOWCASE_COMPONENTS.getTableRow(page, 'Guest User')
-   */
   getTableRow: (page: Page, text: string | RegExp): Locator =>
     SemanticSelectors.tableRow(page, text),
 };

e2e-tests/playwright/support/page-objects/rhdh-instance-table.ts

@@ -0,0 +1,24 @@
+import { Page } from "@playwright/test";
+import { SemanticSelectors } from "../selectors/semantic-selectors";
+
+/**
+ * Table pagination helpers for RHDH instance catalog entity pages.
+ */
+export const RHDH_INSTANCE_TABLE = {
+  getNextPageButton: (page: Page) =>
+    page.getByRole("button", { name: "Next Page" }),
+
+  getPreviousPageButton: (page: Page) =>
+    page.getByRole("button", { name: "Previous Page" }),
+
+  getLastPageButton: (page: Page) =>
+    page.getByRole("button", { name: "Last Page" }),
+
+  getFirstPageButton: (page: Page) =>
+    page.getByRole("button", { name: "First Page" }),
+
+  getTableRows: (page: Page) => SemanticSelectors.table(page).getByRole("row"),
+
+  getTableRow: (page: Page, text: string | RegExp) =>
+    SemanticSelectors.tableRow(page, text),
+};