Skip to content

Commit 175c9fd

Browse files
authored
chore: switch to NodeJS LTS version by default (#2266)
1 parent 2bbcaec commit 175c9fd

File tree

9 files changed

+10
-23
lines changed

9 files changed

+10
-23
lines changed

.github/workflows/coverage.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
- name: ⚙️ Setup NodeJS
3636
uses: actions/setup-node@v6
3737
with:
38-
node-version: 22
38+
node-version: lts/*
3939
cache: npm
4040

4141
- name: 🔧 Install

.github/workflows/publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ jobs:
8787
- name: ⚙️ Set up Node.js
8888
uses: actions/setup-node@v6
8989
with:
90-
node-version: 22
90+
node-version: lts/*
9191

9292
- name: 📦 Install GitHub CLI
9393
run: sudo apt-get install -y gh

.github/workflows/runner-publish.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ jobs:
6969
- name: ⚙️ Set up Node.js
7070
uses: actions/setup-node@v6
7171
with:
72-
node-version: 22
72+
node-version: lts/*
7373

7474
- name: 📦 Install tools
7575
run: |

.github/workflows/runner-snapshot.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
- name: ⚙️ Setup NodeJS
2323
uses: actions/setup-node@v6
2424
with:
25-
node-version: 22
25+
node-version: lts/*
2626

2727
- name: 📦 Install vsce
2828
run: npm install -g @vscode/vsce

.github/workflows/template-main.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on:
88
type: string
99
nodejs:
1010
required: false
11-
default: "22.x"
11+
default: "lts/*"
1212
type: string
1313
code_type:
1414
required: false

.github/workflows/template-runner.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on:
88
type: string
99
nodejs:
1010
required: false
11-
default: "22.x"
11+
default: "lts/*"
1212
type: string
1313
code_type:
1414
required: false

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,9 @@
3939

4040
### Requirements
4141

42-
| NodeJS | Visual Studio Code | Operating System |
43-
| ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------ | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
44-
| <table style="text-align:center;"> <tr><th>20</th><th>22 (LTS)</th><th>Latest</th></tr><tr><td>✅</td><td>✅</td><td>✅❓</td></tr><tr><td colspan="3">❓ Best-effort</td></tr> </table> | <table style="text-align:center;"> <tr><th>min</th><th>-</th><th>max</th></tr><tr><td>1.107.x</td><td>1.108.x</td><td>1.109.x</td></tr> </table> | <table style="text-align:center;"> <tr><th>Linux</th><th>Windows</th><th>macOS</th></tr><tr><td>✅ ⚠️</td><td>✅</td><td>✅ ⚠️</td></tr><tr><td colspan="3">⚠️ [Known Issues](KNOWN_ISSUES.md)</td></tr> </table> |
42+
| NodeJS | Visual Studio Code | Operating System |
43+
| ------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------ | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
44+
| <table style="text-align:center;"> <tr><th>LTS</th><th>Latest</th></tr><tr><td>✅</td><td>✅❓</td></tr><tr><td colspan="2">❓ Best-effort</td></tr> </table> | <table style="text-align:center;"> <tr><th>min</th><th>-</th><th>max</th></tr><tr><td>1.107.x</td><td>1.108.x</td><td>1.109.x</td></tr> </table> | <table style="text-align:center;"> <tr><th>Linux</th><th>Windows</th><th>macOS</th></tr><tr><td>✅ ⚠️</td><td>✅</td><td>✅ ⚠️</td></tr><tr><td colspan="3">⚠️ [Known Issues](KNOWN_ISSUES.md)</td></tr> </table> |
4545

4646
#### NodeJS Support Policy
4747

packages/extester/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,7 @@
5353
],
5454
"supportedVersions": {
5555
"vscode-min": "1.107.1",
56-
"vscode-max": "1.109.4",
57-
"nodejs": "22"
56+
"vscode-max": "1.109.4"
5857
},
5958
"dependencies": {
6059
"@redhat-developer/locators": "^1.18.1",

packages/extester/src/extester.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,6 @@ export const DEFAULT_STORAGE_FOLDER = process.env.TEST_RESOURCES ? process.env.T
5151
export const VSCODE_VERSION_MIN = pjson.supportedVersions['vscode-min'];
5252
export const VSCODE_VERSION_MAX = pjson.supportedVersions['vscode-max'];
5353

54-
/**
55-
* The latest version with automated tests
56-
*/
57-
export const NODEJS_VERSION_MAX = pjson.supportedVersions.nodejs;
58-
5954
/**
6055
* ExTester
6156
*/
@@ -71,13 +66,6 @@ export class ExTester {
7166
) {
7267
this.code = new CodeUtil(storageFolder, releaseType, extensionsDir, coverage);
7368
this.chrome = new DriverUtil(storageFolder);
74-
75-
if (process.versions.node.slice(0, 2) > NODEJS_VERSION_MAX) {
76-
console.log(
77-
'\x1b[33m%s\x1b[0m',
78-
`\nWarning: You are using the untested NodeJS version '${process.versions.node}'. The latest supported version is '${NODEJS_VERSION_MAX}.x.x'.\n\t We recommend to use tested version to have ExTester working properly.\n\n`,
79-
);
80-
}
8169
}
8270

8371
/**

0 commit comments

Comments
 (0)