Use proxyURL to log into sandbox using Red Hat auth token #2743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgolovin
commented
Feb 3, 2023
| @@ -29,6 +29,7 @@ export interface SBSignupResponse { | |||
| givenName: string; | |||
| status: SBStatus; | |||
| username: string; | |||
| proxyURL: string; | |||
There was a problem hiding this comment.
new attribute in reg service response
dgolovin
commented
Feb 3, 2023
| @@ -173,7 +173,7 @@ async function clusterEditorMessageListener (event: any ): Promise<any> { | |||
| case 'sandboxLoginUsingDataInClipboard': | |||
| const telemetryEventLoginToSandbox = new ExtCommandTelemetryEvent('openshift.explorer.addCluster.sandboxLoginUsingDataInClipboard'); | |||
| try { | |||
| const result = await Cluster.loginUsingClipboardToken(event.payload.apiEndpointUrl, event.payload.oauthRequestTokenUrl); | |||
| const result = await Cluster.loginUsingClipboardToken(event.payload.proxyUrl, (sessionCheck as any).idToken); | |||
There was a problem hiding this comment.
Login to the sandbox using proxyUrl and token from RedHat SSO. No need to get sandbox token from browser.
Fix redhat-developer#2519. Signed-off-by: Denis Golovin [email protected]
dgolovin
force-pushed
the
i2519-use-proxy-url-and-redhat-auth-token-for-sandbox-login
branch
from
3350909 to
88c5cf7
Compare
|
Incorporated by #4439. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting resources seems to work fine through the proxy, but there are two problems to solve:
Fix #2519.
Signed-off-by: Denis Golovin [email protected]