Skip to content

Commit e15a92c

Browse files
committed
Drop support for Alpine Linux-specific version
We can't build a binary version of the language server for Alpine Linux any more due to bugs/limitations in GraalVM and changes to the runners in GitHub Actions. It's _probably_ okay to drop Alpine Linux support, since Alpine Linux is usually used on servers instead of as a desktop operating system, and it's a real pain to set up as a desktop operating system. Alpine Linux users should still be able to use the extension if they install Java. Signed-off-by: David Thompson <[email protected]>
1 parent 62f6a66 commit e15a92c

File tree

5 files changed

+5
-20
lines changed

5 files changed

+5
-20
lines changed

.github/workflows/native-image.yaml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
strategy:
2727
fail-fast: true
2828
matrix:
29-
label: [osx-x86_64, osx-aarch_64, linux, alpine]
29+
label: [osx-x86_64, osx-aarch_64, linux]
3030
include:
3131
- label: osx-x86_64
3232
os: macos-13
@@ -35,9 +35,6 @@
3535
- label: linux
3636
os: ubuntu-22.04
3737
prop: -Dgraalvm.static=-H:+StaticExecutableWithDynamicLibC
38-
- label: alpine
39-
os: ubuntu-22.04
40-
prop: -Dgraalvm.static=--static
4138
steps:
4239
- uses: actions/checkout@v4
4340
with:

.github/workflows/release.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ jobs:
118118
- name: Prepare Binary Artifacts For Packaging
119119
run: |
120120
mkdir -p ../staging/zips ../staging/checksums
121-
for f in lemminx-{linux,alpine} lemminx-osx-{x86_64,aarch_64} lemminx-win32; do
121+
for f in lemminx-linux lemminx-osx-{x86_64,aarch_64} lemminx-win32; do
122122
pushd ${f}
123123
chmod u+x ${f}*
124124
zip ../../staging/zips/${f}.zip ${f}*
@@ -130,7 +130,6 @@ jobs:
130130
- name: Package vscode-xml
131131
run: |
132132
declare -A targets
133-
targets["alpine-x64"]=alpine
134133
targets["linux-x64"]=linux
135134
targets["win32-x64"]=win32
136135
targets["darwin-x64"]=osx-x86_64

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
### Build
1010

1111
* Add smoke tests for the binary server. See [#1075](https://github.com/redhat-developer/vscode-xml/issues/1075).
12+
* Drop support for Alpine Linux-specific version. See [#1083](https://github.com/redhat-developer/vscode-xml/pull/1083)
1213

1314
## [0.28.1](https://github.com/redhat-developer/vscode-xml/milestone/40?closed=1) (April 9, 2025)
1415

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
},
2727
"binaryServerDownloadUrl": {
2828
"linux": "https://github.com/redhat-developer/vscode-xml/releases/download/latest/lemminx-linux.zip",
29-
"alpine": "https://github.com/redhat-developer/vscode-xml/releases/download/latest/lemminx-alpine.zip",
3029
"osx-x86_64": "https://github.com/redhat-developer/vscode-xml/releases/download/latest/lemminx-osx-x86_64.zip",
3130
"osx-aarch_64": "https://github.com/redhat-developer/vscode-xml/releases/download/latest/lemminx-osx-aarch_64.zip",
3231
"win32": "https://github.com/redhat-developer/vscode-xml/releases/download/latest/lemminx-win32.zip"

src/server/binary/binaryServerStarter.ts

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -206,24 +206,13 @@ function getBinaryEnvironment(): any {
206206
return process.env;
207207
}
208208

209-
/**
210-
* Returns the platform of the current operating system.
211-
* If the OS is Alpine Linux, it returns 'alpine'.
212-
* Otherwise, it returns the platform string provided by the 'os' module.
213-
*
214-
* @returns The platform of the current operating system.
215-
*/
216-
function getPlatform (): NodeJS.Platform | 'alpine' {
217-
return fs.existsSync('/etc/alpine-release') ? 'alpine' : os.platform();
218-
}
219-
220209
/**
221210
* Returns the name of the server binary file for the current OS and architecture
222211
*
223212
* @return the name of the server binary file for the current OS and architecture
224213
*/
225214
function getServerBinaryNameWithoutExtension(): string {
226-
switch (getPlatform()) {
215+
switch (os.platform()) {
227216
case 'darwin':
228217
switch (os.arch()) {
229218
case 'arm64':
@@ -232,7 +221,7 @@ function getServerBinaryNameWithoutExtension(): string {
232221
return 'lemminx-osx-x86_64';
233222
}
234223
default:
235-
return `lemminx-${getPlatform()}`;
224+
return `lemminx-${os.platform()}`;
236225
}
237226
}
238227

0 commit comments

Comments
 (0)