fix: Aggressively clean podman storage before image transfer

Kill running podman processes and remove all locks/db files
before transferring localhost images to rootful storage.
Unconditionally re-transfer to avoid stale state issues.

pre-commit.check-secrets: ENABLED

Author: agullon

scripts/start-bootc-vm.sh

@@ -97,28 +97,29 @@ mkdir -p "${VM_DIR}/bib-tmp"
 if [[ "${IMAGE}" == localhost/* ]]; then
     echo "STEP-01 Using local image ${IMAGE}..."
 
-    # For localhost images, always transfer to rootful storage to ensure it's available
-    # Clean up any stale locks first
-    echo "STEP-01 Cleaning up container storage locks..."
-    sudo find /var/lib/containers/storage -name '*.lock' -type f -mmin +10 -delete 2>/dev/null || true
-
-    # Check if image exists in rootful storage
-    if sudo podman image exists "${IMAGE}" 2>/dev/null; then
-        echo "STEP-01 Image already in rootful storage, verifying..."
-        # Verify it's accessible by getting the image ID
-        if ! sudo podman image inspect "${IMAGE}" --format '{{.Id}}' >/dev/null 2>&1; then
-            echo "STEP-01 Image corrupted, removing and re-transferring..."
-            sudo podman rmi "${IMAGE}" 2>/dev/null || true
-        else
-            echo "STEP-01 Image verified in rootful storage."
-        fi
-    fi
-
-    # If image doesn't exist or was removed, transfer it
-    if ! sudo podman image exists "${IMAGE}" 2>/dev/null; then
-        echo "STEP-01 Transferring ${IMAGE} to rootful podman storage..."
-        podman save "${IMAGE}" | sudo podman load
+    # For localhost images, transfer to rootful storage
+    # Stop any running podman processes that might hold locks
+    echo "STEP-01 Stopping podman processes..."
+    sudo pkill -9 podman 2>/dev/null || true
+    sleep 2
+
+    # Clean up stale locks and corrupted storage
+    echo "STEP-01 Cleaning up container storage..."
+    sudo find /var/lib/containers/storage -name '*.lock' -delete 2>/dev/null || true
+    sudo rm -f /var/lib/containers/storage/libpod/bolt_state.db-shm 2>/dev/null || true
+    sudo rm -f /var/lib/containers/storage/libpod/bolt_state.db-wal 2>/dev/null || true
+
+    # Unconditionally transfer the image to ensure it's fresh
+    echo "STEP-01 Transferring ${IMAGE} to rootful podman storage..."
+    sudo podman rmi "${IMAGE}" 2>/dev/null || true
+    podman save "${IMAGE}" | sudo podman load
+
+    # Verify the image is now accessible
+    if ! sudo podman image inspect "${IMAGE}" --format '{{.Id}}' >/dev/null 2>&1; then
+        echo "ERROR: Failed to transfer ${IMAGE} to rootful storage"
+        exit 1
     fi
+    echo "STEP-01 Image verified in rootful storage."
 else
     echo "STEP-01 Pulling ${IMAGE}..."
     sudo podman pull "${IMAGE}"