Skip to content

Commit a3a6555

Browse files
committed
Coderabbit comments
1 parent 8d1d7d2 commit a3a6555

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

tests/unittest/cloud_governance/aws/tag_cluster/test_tag_cluster_operations.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ def test_returns_autoscaling_without_iam_validation(self):
3535

3636
def test_skips_automation_user_from_instance_cloudtrail(self):
3737
ops = _make_tag_cluster_ops(
38+
iam_users=['pragchau', 'cloud-governance-delete-user', 'cloud-governance-user'],
3839
instance_ct_user='cloud-governance-user',
3940
cluster_role_user='pragchau')
4041
result = ops.get_username(

tests/unittest/cloud_governance/aws/tag_non_cluster/test_non_cluster_operations.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,9 @@ class TestNonClusterOperationsGetUsername:
2020
START_TIME = datetime(2026, 6, 30, 14, 0, 0, tzinfo=timezone.utc)
2121

2222
def test_excludes_automation_user_from_primary_cloudtrail(self):
23-
ops = _make_non_cluster_ops(cloudtrail_user='cloud-governance-user')
23+
ops = _make_non_cluster_ops(
24+
iam_users=['pragchau', 'cloud-governance-delete-user', 'cloud-governance-user'],
25+
cloudtrail_user='cloud-governance-user')
2426
result = ops.get_username(
2527
start_time=self.START_TIME, resource_id='vol-abc123',
2628
resource_type='AWS::EC2::Volume', tags=[])

0 commit comments

Comments
 (0)