Skip to content

Deduplicate logging setup and implement init_logging #130

Description

@mcurrier2

Description

The logging initialization code (~70 lines) is duplicated between the async and blocking paths in main.rs (~lines 123–191 and 379–437). Meanwhile, logging.rs only exports ColorizedFormatter but has module-level docs describing a non-existent init_logging function.

Impact

  • Code drift between async/blocking logging setup
  • Confusing documentation referencing a function that doesn't exist
  • Any logging changes need to be made in two places

Suggested Fix

  1. Implement pub fn init_logging(level, log_file) -> Result<()> in logging.rs
  2. Call it from both async and blocking entry points in main.rs
  3. Remove the duplicated inline logging setup

Found during release polish review

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions