Description
The logging initialization code (~70 lines) is duplicated between the async and blocking paths in main.rs (~lines 123–191 and 379–437). Meanwhile, logging.rs only exports ColorizedFormatter but has module-level docs describing a non-existent init_logging function.
Impact
- Code drift between async/blocking logging setup
- Confusing documentation referencing a function that doesn't exist
- Any logging changes need to be made in two places
Suggested Fix
- Implement
pub fn init_logging(level, log_file) -> Result<()> in logging.rs
- Call it from both async and blocking entry points in
main.rs
- Remove the duplicated inline logging setup
Found during release polish review
Description
The logging initialization code (~70 lines) is duplicated between the async and blocking paths in
main.rs(~lines 123–191 and 379–437). Meanwhile,logging.rsonly exportsColorizedFormatterbut has module-level docs describing a non-existentinit_loggingfunction.Impact
Suggested Fix
pub fn init_logging(level, log_file) -> Result<()>inlogging.rsmain.rsFound during release polish review