Skip to content

Commit a3940f9

Browse files
committed
fix: calculation of Instance.active
Move the calculation if the active state of an instance from _add_devices_nocheck() to _add_devices_process(), to make it symmetric with device removal. Signed-off-by: Adriaan Schmidt <adriaan.schmidt@siemens.com>
1 parent 1c746a3 commit a3940f9

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

tuned/plugins/hotplug.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,10 @@ def _add_device_process(self, instance, device_name):
4343
self._added_device_apply_tuning(instance, device_name)
4444
self._call_device_script(instance, instance.script_post, "apply", [device_name])
4545
instance.processed_devices.add(device_name)
46+
# This can be a bit racy (we can overcount),
47+
# but it shouldn't affect the boolean result
48+
instance.active = len(instance.processed_devices) \
49+
+ len(instance.assigned_devices) > 0
4650

4751
def _add_device(self, device_name):
4852
if device_name in (self._assigned_devices | self._free_devices):
@@ -63,10 +67,6 @@ def _add_devices_nocheck(self, instance, device_names):
6367
"""
6468
for dev in device_names:
6569
self._add_device_process(instance, dev)
66-
# This can be a bit racy (we can overcount),
67-
# but it shouldn't affect the boolean result
68-
instance.active = len(instance.processed_devices) \
69-
+ len(instance.assigned_devices) > 0
7070

7171
def _remove_device_process(self, instance, device_name):
7272
if device_name in instance.processed_devices:

0 commit comments

Comments
 (0)