Avoid using QUIT command (#3377)

Backport of #3353 

---------

Please refer to: redis/redis#11420

This PR cancels calling the quit command when the Jedis internal link is abnormal, and deprecate the user interface `Jedis.quit()`. This optimizes Jedis connection pool performance and fixes: #2105

---------

 Conflicts:
	src/main/java/redis/clients/jedis/Connection.java
	src/main/java/redis/clients/jedis/ConnectionFactory.java
	src/main/java/redis/clients/jedis/Jedis.java
	src/main/java/redis/clients/jedis/Protocol.java

* more changes

* Modify makeObject() for Jedis 3.x

---------

Co-authored-by: bodong.ybd <[email protected]>

Author: sazzad16

src/main/java/redis/clients/jedis/BinaryClient.java

@@ -156,6 +156,9 @@ public void connect() {
     }
   }
 
+  /**
+   * Closing the socket will disconnect the server connection.
+   */
   @Override
   public void disconnect() {
     db = 0;
@@ -219,6 +222,11 @@ public void getEx(final byte[] key, final GetExParams params) {
     sendCommand(GETEX, params.getByteParams(key));
   }
 
+  /**
+   * @deprecated The QUIT command is deprecated, see <a href="https://github.com/redis/redis/issues/11420">#11420</a>.
+   * {@link BinaryClient#disconnect()} can be used instead.
+   */
+  @Deprecated
   public void quit() {
     db = 0;
     sendCommand(QUIT);

src/main/java/redis/clients/jedis/BinaryJedis.java

@@ -110,9 +110,6 @@ private void initializeFromClientConfig(JedisClientConfig config) {
       }
     } catch (JedisException je) {
       try {
-        if (isConnected()) {
-          quit();
-        }
         disconnect();
       } catch (RuntimeException e) {
         //
@@ -314,6 +311,9 @@ public void connect() {
     client.connect();
   }
 
+  /**
+   * Closing the socket will disconnect the server connection.
+   */
   public void disconnect() {
     client.disconnect();
   }
@@ -467,8 +467,11 @@ public byte[] getEx(final byte[] key, final GetExParams params) {
 
   /**
    * Ask the server to silently close the connection.
+   * @deprecated The QUIT command is deprecated, see <a href="https://github.com/redis/redis/issues/11420">#11420</a>.
+   * {@link BinaryJedis#disconnect()} can be used instead.
    */
   @Override
+  @Deprecated
   public String quit() {
     checkIsInMultiOrPipeline();
     client.quit();

src/main/java/redis/clients/jedis/BinaryShardedJedis.java

@@ -58,20 +58,11 @@ public BinaryShardedJedis(List<JedisShardInfo> shards, Hashing algo, Pattern key
   public void disconnect() {
     for (Jedis jedis : getAllShards()) {
       if (jedis.isConnected()) {
-        try {
-          // need a proper test, probably with mock
-          if (!jedis.isBroken()) {
-            jedis.quit();
-          }
-        } catch (JedisConnectionException e) {
-          // ignore the exception node, so that all other normal nodes can release all connections.
-          logger.warn("Error while QUIT", e);
-        }
         try {
           jedis.disconnect();
         } catch (JedisConnectionException e) {
           // ignore the exception node, so that all other normal nodes can release all connections.
-          logger.warn("Error while disconnect", e);
+          logger.debug("Error while disconnect", e);
         }
       }
     }

src/main/java/redis/clients/jedis/Connection.java

@@ -246,6 +246,9 @@ public void close() {
     disconnect();
   }
 
+  /**
+   * Close the socket and disconnect the server.
+   */
   public void disconnect() {
     if (isConnected()) {
       try {

src/main/java/redis/clients/jedis/JedisFactory.java

@@ -154,14 +154,6 @@ public void activateObject(PooledObject<Jedis> pooledJedis) throws Exception {
   public void destroyObject(PooledObject<Jedis> pooledJedis) throws Exception {
     final BinaryJedis jedis = pooledJedis.getObject();
     if (jedis.isConnected()) {
-      try {
-        // need a proper test, probably with mock
-        if (!jedis.isBroken()) {
-          jedis.quit();
-        }
-      } catch (RuntimeException e) {
-        logger.debug("Error while QUIT", e);
-      }
       try {
         jedis.close();
       } catch (RuntimeException e) {
@@ -179,11 +171,6 @@ public PooledObject<Jedis> makeObject() throws Exception {
       return new DefaultPooledObject<>(jedis);
     } catch (JedisException je) {
       if (jedis != null) {
-        try {
-          jedis.quit();
-        } catch (RuntimeException e) {
-          logger.debug("Error while QUIT", e);
-        }
         try {
           jedis.close();
         } catch (RuntimeException e) {

src/main/java/redis/clients/jedis/Protocol.java

@@ -253,7 +253,7 @@ public static final byte[] toByteArray(final double value) {
   }
 
   public static enum Command implements ProtocolCommand {
-    PING, SET, GET, GETDEL, GETEX, QUIT, EXISTS, DEL, UNLINK, TYPE, FLUSHDB, KEYS, RANDOMKEY, RENAME,
+    PING, SET, GET, GETDEL, GETEX, @Deprecated QUIT, EXISTS, DEL, UNLINK, TYPE, FLUSHDB, KEYS, RANDOMKEY, RENAME,
     RENAMENX, RENAMEX, DBSIZE, EXPIRE, EXPIREAT, TTL, SELECT, MOVE, FLUSHALL, GETSET, MGET, SETNX,
     SETEX, MSET, MSETNX, DECRBY, DECR, INCRBY, INCR, APPEND, SUBSTR, HSET, HGET, HSETNX, HMSET,
     HMGET, HINCRBY, HEXISTS, HDEL, HLEN, HKEYS, HVALS, HGETALL, HRANDFIELD, RPUSH, LPUSH, LLEN, LRANGE, LTRIM,

src/main/java/redis/clients/jedis/ShardedJedisPool.java

@@ -87,18 +87,10 @@ public void destroyObject(PooledObject<ShardedJedis> pooledShardedJedis) throws
       final ShardedJedis shardedJedis = pooledShardedJedis.getObject();
       for (Jedis jedis : shardedJedis.getAllShards()) {
         if (jedis.isConnected()) {
-          try {
-            // need a proper test, probably with mock
-            if (!jedis.isBroken()) {
-              jedis.quit();
-            }
-          } catch (RuntimeException e) {
-            logger.warn("Error while QUIT", e);
-          }
           try {
             jedis.disconnect();
           } catch (RuntimeException e) {
-            logger.warn("Error while disconnect", e);
+            logger.debug("Error while disconnect", e);
           }
         }
       }

src/main/java/redis/clients/jedis/commands/BasicCommands.java

@@ -17,7 +17,10 @@ public interface BasicCommands {
    * Ask the server to close the connection. The connection is closed as soon as all pending replies
    * have been written to the client.
    * @return OK
+   * @deprecated The QUIT command is deprecated, see <a href="https://github.com/redis/redis/issues/11420">#11420</a>.
+   * If available, {@code disconnect()} method in the concerned class can be used instead.
    */
+  @Deprecated
   String quit();
 
   /**