Skip to content

Commit 350d474

Browse files
committed
Fix SORTABLE argument issue in FT.CREATE command (#3584)
All I know these changes have been enough to pass all redis-om-spring tests in redis/redis-om-spring#357
1 parent 233ab64 commit 350d474

File tree

2 files changed

+20
-19
lines changed

2 files changed

+20
-19
lines changed

src/main/java/redis/clients/jedis/search/schemafields/TagField.java

+8-8
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,14 @@ public void addParams(CommandArguments args) {
106106
args.add(SEPARATOR).add(separator);
107107
}
108108

109+
if (caseSensitive) {
110+
args.add(CASESENSITIVE);
111+
}
112+
113+
if (withSuffixTrie) {
114+
args.add(WITHSUFFIXTRIE);
115+
}
116+
109117
if (sortableUNF) {
110118
args.add(SORTABLE).add(UNF);
111119
} else if (sortable) {
@@ -115,13 +123,5 @@ public void addParams(CommandArguments args) {
115123
if (noIndex) {
116124
args.add(NOINDEX);
117125
}
118-
119-
if (caseSensitive) {
120-
args.add(CASESENSITIVE);
121-
}
122-
123-
if (withSuffixTrie) {
124-
args.add(WITHSUFFIXTRIE);
125-
}
126126
}
127127
}

src/main/java/redis/clients/jedis/search/schemafields/TextField.java

+12-11
Original file line numberDiff line numberDiff line change
@@ -107,29 +107,30 @@ public void addParams(CommandArguments args) {
107107
args.addParams(fieldName);
108108
args.add(TEXT);
109109

110-
if (sortableUNF) {
111-
args.add(SORTABLE).add(UNF);
112-
} else if (sortable) {
113-
args.add(SORTABLE);
110+
if (weight != null) {
111+
args.add(WEIGHT).add(weight);
114112
}
115113

116114
if (noStem) {
117115
args.add(NOSTEM);
118116
}
119-
if (noIndex) {
120-
args.add(NOINDEX);
121-
}
122117

123118
if (phoneticMatcher != null) {
124119
args.add(PHONETIC).add(phoneticMatcher);
125120
}
126121

127-
if (weight != null) {
128-
args.add(WEIGHT).add(weight);
129-
}
130-
131122
if (withSuffixTrie) {
132123
args.add(WITHSUFFIXTRIE);
133124
}
125+
126+
if (sortableUNF) {
127+
args.add(SORTABLE).add(UNF);
128+
} else if (sortable) {
129+
args.add(SORTABLE);
130+
}
131+
132+
if (noIndex) {
133+
args.add(NOINDEX);
134+
}
134135
}
135136
}

0 commit comments

Comments
 (0)