Key prefixes conflict when they start with same letters

[Jimmys20]

Hello, in this demo I have the following models:

[Document(StorageType = StorageType.Json, Prefixes = ["Player"])]
public class PlayerEntity
{
  [RedisIdField, Indexed] public string UniquePlayerId { get; set; }
  // other properties
}

[Document(StorageType = StorageType.Json, Prefixes = ["PlayerState"])]
public class PlayerStateEntity
{
  [RedisIdField, Indexed] public string UniquePlayerId { get; set; }
  // other properties
}

and two RedisCollection instances:

var provider = new RedisConnectionProvider(redisConfigurationOptions);

provider.Connection.DropIndexAndAssociatedRecords(typeof(PlayerEntity));
await provider.Connection.CreateIndexAsync(typeof(PlayerEntity));

provider.Connection.DropIndexAndAssociatedRecords(typeof(PlayerStateEntity));
await provider.Connection.CreateIndexAsync(typeof(PlayerStateEntity));

var players = provider.RedisCollection<PlayerEntity>();
var playerStates = provider.RedisCollection<PlayerStateEntity>();

any record inserted to the 'playerStates' collection is also included in the 'players' collection when I enumerate it:

await players.InsertAsync(new PlayerEntity
{
  UniquePlayerId = Guid.NewGuid().ToString(),
});

await playerStates.InsertAsync(new PlayerStateEntity
{
  UniquePlayerId = Guid.NewGuid().ToString(),
});

var playerList = await players.ToListAsync();

Console.WriteLine(playerList2.Count); // Should be 1

The problem seems to happen because "PlayerState" prefix starts with "Player" which is the other prefix. If I change the prefixes to completely different strings the problem is gone. Is this a bug? What are some good strategies to create key prefixes that will not conflict with each other? I have multiple apps that share the same redis instance, I'm thinking about concatenating the application namespace to all key prefixes to try to prevent similar issues. Do you have any better suggestions?

[SMAH1]

See Here

[Jimmys20]

Thank you, this is exactly the same issue I'm having. What confuses me (and seems to be confusing the people in the other issues as well) is that with prefixes "Player" and "PlayerState" when I query redis using redis-cli I get keys like following:

Player:{UniquePlayerId}
PlayerState:{UniquePlayerId}

so the colon seems to be there even though I didn't specify the prefixes as "PlayerState:", "Player:". So it looks to me like Redis.OM is appending a colon after the custom prefix when inserting values to redis but then uses the the custom prefix as is when reading from redis.

if with prefixes "Player" and "PlayerState" would generate keys were like following:

Player{UniquePlayerId}
PlayerState{UniquePlayerId}

then it would make perfect sense to me why they are conflicting and I would add the colon at the prefix like: "PlayerState:", "Player:"

If I have a class Player and PlayerState in namespace MyApp.Models and I don't define a custom prefix then Redis.OM generates keys like:

MyApp.Models.Player:{id}
MyApp.Models.PlayerState:{id}

MyApp.Models.Player is a subset of MyApp.Models.PlayerState but somehow Redis.OM knows that they are different and works correctly.

If I define custom prefixes as "MyApp.Models.Player" and "MyApp.Models.PlayerState" then the same keys will be generated on redis exactly like before:

MyApp.Models.Player:{id}
MyApp.Models.PlayerState:{id}

but for some reason Redis.OM won't know how to handle them anymore.

[SMAH1]

I solved by like code:

[Document(StorageType = StorageType.Json, Prefixes = ["Player:DB"])]
...
[Document(StorageType = StorageType.Json, Prefixes = ["PlayerState:DB"])]
...

[zairnamlas]

Caught up in the same issue.
Figured out that when no prefix is defined on the document then the full name of the class with trailing : is used as prefix in the index. i.e., User class with some namespace A.B.C.User.cs
A.B.C.User:

but when we define a custom prefix like user then the prefix doesn't have the trailing :
user

For me the fix was to modify the code while creating the index as those would just work fine once created according to my research. Following is the place to change the code Redis.OM.Modeling.RedisIndex.cs

redis-om-dotnet/src/Redis.OM/Modeling/RedisIndex.cs

Lines 283 to 293 in 9cb3460

	args.Add("PREFIX");
	if (objAttribute.Prefixes.Length > 0)
	{
	args.Add(objAttribute.Prefixes.Length.ToString());
	args.AddRange(objAttribute.Prefixes);
	}
	else
	{
	args.Add("1");
	args.Add($"{type.FullName}:");
	}

TO:

      args.Add("PREFIX");
      if (objAttribute.Prefixes.Length > 0)
      {
          args.Add(objAttribute.Prefixes.Length.ToString());
      
          string[] prefixes = objAttribute.Prefixes.Select(p =>
          {
              if (string.IsNullOrWhiteSpace(p) || p.EndsWith(":"))
                  return p;
      
              return $"{p}:";
          }).ToArray();
      
          args.AddRange(prefixes);
      }
      else
      {
          args.Add("1");
          args.Add($"{type.FullName}:");
      }

In the other discussion it was mentioned that it could be ground breaking change, please correct me if this could go wrong so I'll use other logic in mind (have unique starting characters in prefixes of documents)