Fix CLI async/sync function call issues causing test failures

Fixed async CLI functions that were incorrectly wrapped with run_async()
calls, which caused "a coroutine was expected" errors in CI tests.
Changed all CLI command functions to be properly async and use await
instead of run_async() wrapper.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: abrookins

aredis_om/model/cli/migrate.py

@@ -25,32 +25,29 @@ def migrate():
 
 @migrate.command()
 @click.option("--migrations-dir", help="Directory containing schema migration files")
-def status(migrations_dir: Optional[str]):
+async def status(migrations_dir: Optional[str]):
     """Show current schema migration status from files."""
 
-    async def _status():
-        dir_path = migrations_dir or os.path.join(
-            get_root_migrations_dir(), "schema-migrations"
-        )
-        migrator = SchemaMigrator(migrations_dir=dir_path)
-        status_info = await migrator.status()
+    dir_path = migrations_dir or os.path.join(
+        get_root_migrations_dir(), "schema-migrations"
+    )
+    migrator = SchemaMigrator(migrations_dir=dir_path)
+    status_info = await migrator.status()
 
-        click.echo("Schema Migration Status:")
-        click.echo(f"  Total migrations: {status_info['total_migrations']}")
-        click.echo(f"  Applied: {status_info['applied_count']}")
-        click.echo(f"  Pending: {status_info['pending_count']}")
-
-        if status_info["pending_migrations"]:
-            click.echo("\nPending migrations:")
-            for migration_id in status_info["pending_migrations"]:
-                click.echo(f"- {migration_id}")
+    click.echo("Schema Migration Status:")
+    click.echo(f"  Total migrations: {status_info['total_migrations']}")
+    click.echo(f"  Applied: {status_info['applied_count']}")
+    click.echo(f"  Pending: {status_info['pending_count']}")
 
-        if status_info["applied_migrations"]:
-            click.echo("\nApplied migrations:")
-            for migration_id in status_info["applied_migrations"]:
-                click.echo(f"- {migration_id}")
+    if status_info["pending_migrations"]:
+        click.echo("\nPending migrations:")
+        for migration_id in status_info["pending_migrations"]:
+            click.echo(f"- {migration_id}")
 
-    run_async(_status())
+    if status_info["applied_migrations"]:
+        click.echo("\nApplied migrations:")
+        for migration_id in status_info["applied_migrations"]:
+            click.echo(f"- {migration_id}")
 
 
 @migrate.command()
@@ -66,7 +63,7 @@ async def _status():
     is_flag=True,
     help="Skip confirmation prompt to create directory or run",
 )
-def run(
+async def run(
     migrations_dir: Optional[str],
     dry_run: bool,
     verbose: bool,
@@ -75,43 +72,38 @@ def run(
 ):
     """Run pending schema migrations from files."""
 
-    async def _run():
-        dir_path = migrations_dir or os.path.join(
-            get_root_migrations_dir(), "schema-migrations"
-        )
+    dir_path = migrations_dir or os.path.join(
+        get_root_migrations_dir(), "schema-migrations"
+    )
+
+    if not os.path.exists(dir_path):
+        if yes or click.confirm(f"Create schema migrations directory at '{dir_path}'?"):
+            os.makedirs(dir_path, exist_ok=True)
+        else:
+            click.echo("Aborted.")
+            return
+
+    migrator = SchemaMigrator(migrations_dir=dir_path)
 
-        if not os.path.exists(dir_path):
-            if yes or click.confirm(
-                f"Create schema migrations directory at '{dir_path}'?"
+    # Show list for confirmation
+    if not dry_run and not yes:
+        status_info = await migrator.status()
+        if status_info["pending_migrations"]:
+            listing = "\n".join(
+                f"- {m}"
+                for m in status_info["pending_migrations"][
+                    : (limit or len(status_info["pending_migrations"]))
+                ]
+            )
+            if not click.confirm(
+                f"Run {min(limit or len(status_info['pending_migrations']), len(status_info['pending_migrations']))} migration(s)?\n{listing}"
             ):
-                os.makedirs(dir_path, exist_ok=True)
-            else:
                 click.echo("Aborted.")
                 return
 
-        migrator = SchemaMigrator(migrations_dir=dir_path)
-
-        # Show list for confirmation
-        if not dry_run and not yes:
-            status_info = await migrator.status()
-            if status_info["pending_migrations"]:
-                listing = "\n".join(
-                    f"- {m}"
-                    for m in status_info["pending_migrations"][
-                        : (limit or len(status_info["pending_migrations"]))
-                    ]
-                )
-                if not click.confirm(
-                    f"Run {min(limit or len(status_info['pending_migrations']), len(status_info['pending_migrations']))} migration(s)?\n{listing}"
-                ):
-                    click.echo("Aborted.")
-                    return
-
-        count = await migrator.run(dry_run=dry_run, limit=limit, verbose=verbose)
-        if verbose and not dry_run:
-            click.echo(f"Successfully applied {count} migration(s).")
-
-    run_async(_run())
+    count = await migrator.run(dry_run=dry_run, limit=limit, verbose=verbose)
+    if verbose and not dry_run:
+        click.echo(f"Successfully applied {count} migration(s).")
 
 
 @migrate.command()
@@ -120,31 +112,26 @@ async def _run():
 @click.option(
     "--yes", "-y", is_flag=True, help="Skip confirmation prompt to create directory"
 )
-def create(name: str, migrations_dir: Optional[str], yes: bool):
+async def create(name: str, migrations_dir: Optional[str], yes: bool):
     """Create a new schema migration snapshot file from current pending operations."""
 
-    async def _create():
-        dir_path = migrations_dir or os.path.join(
-            get_root_migrations_dir(), "schema-migrations"
-        )
-
-        if not os.path.exists(dir_path):
-            if yes or click.confirm(
-                f"Create schema migrations directory at '{dir_path}'?"
-            ):
-                os.makedirs(dir_path, exist_ok=True)
-            else:
-                click.echo("Aborted.")
-                return
+    dir_path = migrations_dir or os.path.join(
+        get_root_migrations_dir(), "schema-migrations"
+    )
 
-        migrator = SchemaMigrator(migrations_dir=dir_path)
-        filepath = await migrator.create_migration_file(name)
-        if filepath:
-            click.echo(f"Created migration: {filepath}")
+    if not os.path.exists(dir_path):
+        if yes or click.confirm(f"Create schema migrations directory at '{dir_path}'?"):
+            os.makedirs(dir_path, exist_ok=True)
         else:
-            click.echo("No pending schema changes detected. Nothing to snapshot.")
+            click.echo("Aborted.")
+            return
 
-    run_async(_create())
+    migrator = SchemaMigrator(migrations_dir=dir_path)
+    filepath = await migrator.create_migration_file(name)
+    if filepath:
+        click.echo(f"Created migration: {filepath}")
+    else:
+        click.echo("No pending schema changes detected. Nothing to snapshot.")
 
 
 @migrate.command()
@@ -160,7 +147,7 @@ async def _create():
     is_flag=True,
     help="Skip confirmation prompt to create directory or run",
 )
-def rollback(
+async def rollback(
     migration_id: str,
     migrations_dir: Optional[str],
     dry_run: bool,
@@ -169,37 +156,30 @@ def rollback(
 ):
     """Rollback a specific schema migration by ID."""
 
-    async def _rollback():
-        dir_path = migrations_dir or os.path.join(
-            get_root_migrations_dir(), "schema-migrations"
-        )
-
-        if not os.path.exists(dir_path):
-            if yes or click.confirm(
-                f"Create schema migrations directory at '{dir_path}'?"
-            ):
-                os.makedirs(dir_path, exist_ok=True)
-            else:
-                click.echo("Aborted.")
-                return
-
-        migrator = SchemaMigrator(migrations_dir=dir_path)
-
-        if not yes and not dry_run:
-            if not click.confirm(f"Rollback migration '{migration_id}'?"):
-                click.echo("Aborted.")
-                return
+    dir_path = migrations_dir or os.path.join(
+        get_root_migrations_dir(), "schema-migrations"
+    )
 
-        success = await migrator.rollback(
-            migration_id, dry_run=dry_run, verbose=verbose
-        )
-        if success:
-            if verbose:
-                click.echo(f"Successfully rolled back migration: {migration_id}")
+    if not os.path.exists(dir_path):
+        if yes or click.confirm(f"Create schema migrations directory at '{dir_path}'?"):
+            os.makedirs(dir_path, exist_ok=True)
         else:
-            click.echo(
-                f"Migration '{migration_id}' does not support rollback or is not applied.",
-                err=True,
-            )
-
-    run_async(_rollback())
+            click.echo("Aborted.")
+            return
+
+    migrator = SchemaMigrator(migrations_dir=dir_path)
+
+    if not yes and not dry_run:
+        if not click.confirm(f"Rollback migration '{migration_id}'?"):
+            click.echo("Aborted.")
+            return
+
+    success = await migrator.rollback(migration_id, dry_run=dry_run, verbose=verbose)
+    if success:
+        if verbose:
+            click.echo(f"Successfully rolled back migration: {migration_id}")
+    else:
+        click.echo(
+            f"Migration '{migration_id}' does not support rollback or is not applied.",
+            err=True,
+        )

aredis_om/model/cli/migrate_data.py

@@ -34,7 +34,7 @@ def migrate_data():
     help="Directory containing migration files (default: <root>/data-migrations)",
 )
 @click.option("--module", help="Python module containing migrations")
-def status(migrations_dir: str, module: str):
+async def status(migrations_dir: str, module: str):
     """Show current migration status."""
 
     async def _status():
@@ -71,7 +71,7 @@ async def _status():
             click.echo(f"Error: {e}", err=True)
             raise click.Abort()
 
-    run_async(_status())
+    await _status()
 
 
 @migrate_data.command()
@@ -86,7 +86,7 @@ async def _status():
 @click.option("--verbose", "-v", is_flag=True, help="Enable verbose output")
 @click.option("--limit", type=int, help="Limit number of migrations to run")
 @click.option("--yes", "-y", is_flag=True, help="Skip confirmation prompt")
-def run(
+async def run(
     migrations_dir: str,
     module: str,
     dry_run: bool,
@@ -164,7 +164,7 @@ async def _run():
             click.echo(f"Error: {e}", err=True)
             raise click.Abort()
 
-    run_async(_run())
+    await _run()
 
 
 @migrate_data.command()
@@ -176,7 +176,7 @@ async def _run():
 @click.option(
     "--yes", "-y", is_flag=True, help="Skip confirmation prompt to create directory"
 )
-def create(name: str, migrations_dir: Optional[str], yes: bool):
+async def create(name: str, migrations_dir: Optional[str], yes: bool):
     """Create a new migration file."""
 
     async def _create():
@@ -206,7 +206,7 @@ async def _create():
             click.echo(f"Error creating migration: {e}", err=True)
             raise click.Abort()
 
-    run_async(_create())
+    await _create()
 
 
 @migrate_data.command()
@@ -222,7 +222,7 @@ async def _create():
 )
 @click.option("--verbose", "-v", is_flag=True, help="Enable verbose output")
 @click.option("--yes", "-y", is_flag=True, help="Skip confirmation prompt")
-def rollback(
+async def rollback(
     migration_id: str,
     migrations_dir: str,
     module: str,
@@ -284,7 +284,7 @@ async def _rollback():
             click.echo(f"Error: {e}", err=True)
             raise click.Abort()
 
-    run_async(_rollback())
+    await _rollback()
 
 
 if __name__ == "__main__":