Skip to content

NOT IN (>>) operator is not working on v0.2.2 #607

Closed
@deepsghimire

Description

@deepsghimire

commit dabd0fc introduced following changes in aredis_om/model/model.py

  elif op is Operators.NOT_IN:
                 # TODO: Implement NOT_IN, test this...
                 expanded_value = cls.expand_tag_value(value)
-                result += f"-(@{field_name}:{{{expanded_value}}})"
+                result += "-(@{field_name}):{{{expanded_value}}}".format(
+                    field_name=field_name, expanded_value=expanded_value
+                )

note the placement of right parenthesis

shouldn't this be following?

  elif op is Operators.NOT_IN:
                 # TODO: Implement NOT_IN, test this...
                 expanded_value = cls.expand_tag_value(value)
-                result += f"-(@{field_name}:{{{expanded_value}}})"
+                result += "-(@{field_name}:{{{expanded_value}}})".format(
+                    field_name=field_name, expanded_value=expanded_value
+                )

Activity

slorello89

slorello89 commented on May 2, 2024

@slorello89
Member

Good catch, fixed in #603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @slorello89@deepsghimire

        Issue actions

          NOT IN (>>) operator is not working on v0.2.2 · Issue #607 · redis/redis-om-python