Skip to content

Cannot add users into protected branch list #823

Open
@tomhub

Description

@tomhub

I am able to add protected branches, but I cannot include users. When I select users and click save, I get this:

I, [2023-02-27T12:10:52.666116 #71]  INFO -- : Started PUT "/repositories/12/protected_branches/19" for 10.23.36.15 at 2023-02-27 12:10:52 +0000
I, [2023-02-27T12:10:52.667266 #71]  INFO -- : Processing by RepositoryProtectedBranchesController#update as JS
I, [2023-02-27T12:10:52.667439 #71]  INFO -- :    Parameters: {"utf8"=>"✓", "authenticity_token"=>"xxx", "repository_protected_branche"=>{"path"=>"dev/", "permissions"=>"RW+"}, "user_ids"=>["", "5"], "group_ids"=>[""], "commit"=>"Save", "repository_id"=>"12", "id"=>"19"}
I, [2023-02-27T12:10:52.672267 #71]  INFO -- :    Current user: xxx (id=5)
I, [2023-02-27T12:10:52.684013 #71]  INFO -- :  Completed 500 Internal Server Error in 16ms (ActiveRecord: 3.8ms | Allocations: 4103)
F, [2023-02-27T12:10:52.685072 #71] FATAL -- :   
 ArgumentError (wrong number of arguments (given 4, expected 3)):
   
 plugins/redmine_git_hosting/app/use_cases/repository_protected_branches/member_manager.rb:63:in `create_member'
 plugins/redmine_git_hosting/app/use_cases/repository_protected_branches/member_manager.rb:41:in `create_user_member'
 plugins/redmine_git_hosting/app/use_cases/repository_protected_branches/member_manager.rb:29:in `add_users'
 plugins/redmine_git_hosting/app/controllers/repository_protected_branches_controller.rb:79:in `check_members'
 plugins/redmine_git_hosting/app/controllers/repository_protected_branches_controller.rb:34:in `update'
 lib/redmine/sudo_mode.rb:61:in `sudo_mode'

setup:

Environment:
  Redmine version                5.0.4.stable
  Ruby version                   3.0.5-p211 (2022-11-24) [x86_64-linux]
  Rails version                  6.1.7
  Environment                    production
  Database adapter               Mysql2
  Mailer queue                   ActiveJob::QueueAdapters::AsyncAdapter
  Mailer delivery                smtp
Redmine settings:
  Redmine theme                  Alternate
SCM:
  Git                            2.39.2
  Filesystem                     
  Xitolite                       2.39.2
Redmine plugins:
  additionals                    3.0.8
  redmine_git_hosting            6.0.1
  redmine_privacy_terms          1.0.6
  redmine_spent_time             4.1.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions