Skip to content

Commit bb3929a

Browse files
jvorcakclaude
andcommitted
fix(consumers): tidy Protocol stats for empty groups
Empty groups have no protocol/protocolType, which rendered blank stat values, and the legacy ProtocolType helper duplicated protocolType under a "Protocol" label. Show the actual group.protocol field (matching the list column) and group.protocolType with an em-dash fallback, and drop the redundant ProtocolType component. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 30ca302 commit bb3929a

1 file changed

Lines changed: 2 additions & 11 deletions

File tree

frontend/src/components/pages/consumers/group-details.tsx

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -296,8 +296,8 @@ const GroupDetailsMain = ({ groupId, search, onSearchChange }: GroupDetailsProps
296296
<CardContent className="flex flex-wrap gap-x-12 gap-y-4">
297297
<StatItem label="State" value={<ConsumerGroupStateCell state={group.state} />} />
298298
<StatItem label="Assigned Partitions" value={totalPartitions} />
299-
<ProtocolType group={group} />
300-
<StatItem label="Protocol Type" value={group.protocolType} />
299+
<StatItem label="Protocol" value={group.protocol || '—'} />
300+
<StatItem label="Protocol Type" value={group.protocolType || '—'} />
301301
<StatItem
302302
label={
303303
<span className="inline-flex items-center gap-1">
@@ -739,15 +739,6 @@ const renderMergedID = (id?: string, clientId?: string) => {
739739
return null;
740740
};
741741

742-
const ProtocolType = (p: { group: GroupDescription }) => {
743-
const protocol = p.group.protocolType;
744-
if (protocol === 'consumer') {
745-
return null;
746-
}
747-
748-
return <StatItem label="Protocol" value={protocol} />;
749-
};
750-
751742
function cannotEditGroupReason(
752743
group: GroupDescription,
753744
featurePatchGroup: boolean,

0 commit comments

Comments
 (0)