Skip to content

Commit f3398fa

Browse files
committed
backend: fix lint issues
1 parent a009620 commit f3398fa

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

backend/pkg/console/list_messages_integration_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -795,7 +795,7 @@ func createNewTestService(t *testing.T, log *zap.Logger,
795795
svc, err := NewService(&cfg, log, kafkaFactory, schemaFactory, nil, cacheFn, nil)
796796
require.NoError(t, err)
797797

798-
err = svc.Start()
798+
err = svc.Start(context.Background())
799799
require.NoError(t, err)
800800

801801
return svc

backend/pkg/console/service.go

+6-3
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ func (s *Service) Start(ctx context.Context) error {
141141
}
142142

143143
if err := s.testKafkaConnectivity(ctx); err != nil {
144-
return err
144+
return fmt.Errorf("failed to test kafka connectivity: %w", err)
145145
}
146146

147147
return nil
@@ -161,16 +161,19 @@ func (s *Service) testKafkaConnectivity(ctx context.Context) error {
161161
}
162162

163163
testConnection := func(kafkaCl *kgo.Client, timeout time.Duration) error {
164+
connectionCtx, cancel := context.WithTimeout(ctx, timeout)
165+
defer cancel()
166+
164167
s.logger.Info("connecting to Kafka seed brokers, trying to fetch cluster metadata", zap.Strings("seed_brokers", s.cfg.Kafka.Brokers))
165168
req := kmsg.NewMetadataRequest()
166-
res, err := req.RequestWith(ctx, kafkaCl)
169+
res, err := req.RequestWith(connectionCtx, kafkaCl)
167170
if err != nil {
168171
return fmt.Errorf("failed to request metadata: %w", err)
169172
}
170173

171174
// Request versions in order to guess Kafka Cluster version
172175
versionsReq := kmsg.NewApiVersionsRequest()
173-
versionsRes, err := versionsReq.RequestWith(ctx, kafkaCl)
176+
versionsRes, err := versionsReq.RequestWith(connectionCtx, kafkaCl)
174177
if err != nil {
175178
return fmt.Errorf("failed to request api versions: %w", err)
176179
}

0 commit comments

Comments
 (0)