Added hikaricp.connections.max (pool max size) (DataDog#1890)

* Add hikaricp.connections.max (connection pool size)

* Change metric description

* Fix wrong captial letter

* Add unit name

Co-authored-by: Florent Clarret <[email protected]>

---------

Co-authored-by: karl <[email protected]>
Co-authored-by: Florent Clarret <[email protected]>

Author: 3 people

hikaricp/datadog_checks/hikaricp/metrics.py

@@ -2,6 +2,7 @@
     "hikaricp_connections": "connections",
     "hikaricp_connections_active": "connections.active",
     "hikaricp_connections_idle": "connections.idle",
+    "hikaricp_connections_max": "connections.max",
     "hikaricp_connections_pending": "connections.pending",
     "hikaricp_connections_timeout": "connections.timeout",
     "hikaricp_connections_acquire_seconds": "connections.acquire.seconds",

hikaricp/metadata.csv

@@ -3,6 +3,7 @@ hikaricp.connections,gauge,,,,Number of connections,0,hikaricp,connection number
 hikaricp.connections.timeout.count,count,,,,Total number of timeout connections,0,hikaricp,connection timeout total,
 hikaricp.connections.active,gauge,,,,Number of active connections,0,hikaricp,active connection number,
 hikaricp.connections.idle,gauge,,,,Number of idle connections,0,hikaricp,idle connection number,
+hikaricp.connections.max,gauge,,connection,,Max number of connections,0,hikaricp,max connection number,
 hikaricp.connections.pending,gauge,,,,Number of pending connections,0,hikaricp,pending connection number,
 hikaricp.connections.acquire.seconds.count,count,,second,,Count of acquire connection time,0,hikaricp,acquire connections time seconds,
 hikaricp.connections.acquire.seconds.max,gauge,,second,, Max of acquire connection time,0,hikaricp,acquire connections time seconds,
@@ -12,4 +13,4 @@ hikaricp.connections.creation.seconds.max,gauge,,second,,Max of creation connect
 hikaricp.connections.creation.seconds.sum,count,,second,,Sum of creation connection time,0,hikaricp,creation connections time seconds,
 hikaricp.connections.usage.seconds.count,count,,second,,Count of usage connection time,0,hikaricp,usage connections time seconds,
 hikaricp.connections.usage.seconds.max,gauge,,second,,Max of usage connection time,0,hikaricp,usage connections time seconds,
-hikaricp.connections.usage.seconds.sum,count,,second,,Sum of usage connection time,0,hikaricp,usage connections time seconds,
+hikaricp.connections.usage.seconds.sum,count,,second,,Sum of usage connection time,0,hikaricp,usage connections time seconds,

hikaricp/tests/test_hikaricp.py

@@ -7,6 +7,7 @@
     "hikaricp.connections",
     "hikaricp.connections.active",
     "hikaricp.connections.idle",
+    "hikaricp.connections.max",
     "hikaricp.connections.pending",
     "hikaricp.connections.timeout.count",
     "hikaricp.connections.acquire.seconds.count",