Skip to content

Ability of configuring min.insync.replica for kminion end to end topic #301

@shk3

Description

@shk3

Hi,

Is it something wanted to allow configure the minISR parameter on the end to end topic? It looks like the minISR is currently set through a hard-coded logic (see the code reference below). In our use case, we use the end to end topic as a probe to identify Kafka issues, and we would have replication factor 3 while keeping minISR as 1 in order to allow N+2 availability. Ideally, the probe should be able to reproduce the same setup.

If the customization feature is wanted, I could contribute a PR. Thanks!

kminion/e2e/topic.go

Lines 391 to 397 in ea8e76a

minISR := 1
if cfgTopic.ReplicationFactor >= 3 {
// Only with 3+ replicas does it make sense to require acks from 2 brokers
// todo: think about if we should change how 'producer.requiredAcks' works.
// we probably don't even need this configured on the topic directly...
minISR = 2
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions