no-leaderless-notification

mmaslankaprv · mmaslankaprv · commit 0e84a900a3c0 · 2025-02-27T10:38:06.000+01:00
Signed-off-by: Michał Maślanka &lt;michal@redpanda.com&gt;
diff --git a/src/v/raft/consensus.cc b/src/v/raft/consensus.cc
@@ -237,7 +237,6 @@ void consensus::maybe_step_down() {
                     do_step_down("heartbeats_majority");
                     if (_leader_id) {
                         _leader_id = std::nullopt;
-                        trigger_leadership_notification();
                     }
                 }
             }
@@ -1881,7 +1880,6 @@ ss::future<vote_reply> consensus::do_vote(vote_request r) {
         do_step_down("candidate_term_greater");
         if (_leader_id) {
             _leader_id = std::nullopt;
-            trigger_leadership_notification();
         }
 
         // do not grant vote if log isn't ok
@@ -3134,7 +3132,6 @@ ss::future<> consensus::maybe_commit_configuration(ssx::semaphore_units u) {
         co_await transfer_and_stepdown("no_longer_member");
         if (_leader_id) {
             _leader_id = std::nullopt;
-            trigger_leadership_notification();
         }
     }
 }
@@ -3664,7 +3661,6 @@ consensus::do_transfer_leadership(transfer_leadership_request req) {
                               do_step_down("leadership_transfer");
                               if (_leader_id) {
                                   _leader_id = std::nullopt;
-                                  trigger_leadership_notification();
                               }
 
                               return make_error_code(errc::success);
diff --git a/src/v/raft/consensus.h b/src/v/raft/consensus.h
@@ -359,7 +359,6 @@ class consensus {
             do_step_down(fmt::format("external_stepdown - {}", ctx));
             if (_leader_id) {
                 _leader_id = std::nullopt;
-                trigger_leadership_notification();
             }
         });
     }
diff --git a/src/v/raft/vote_stm.cc b/src/v/raft/vote_stm.cc
@@ -140,7 +140,6 @@ ss::future<election_success> vote_stm::vote(bool leadership_transfer) {
               //  only trigger notification when we had a leader previously
               if (_ptr->_leader_id) {
                   _ptr->_leader_id = std::nullopt;
-                  _ptr->trigger_leadership_notification();
               }
 
               if (_prevote && leadership_transfer) {

Original file line number	Diff line number	Diff line change
`@@ -237,7 +237,6 @@ void consensus::maybe_step_down() {`
`237`	`237`	`do_step_down("heartbeats_majority");`
`238`	`238`	`if (_leader_id) {`
`239`	`239`	`_leader_id = std::nullopt;`
`240`		`- trigger_leadership_notification();`
`241`	`240`	`}`
`242`	`241`	`}`
`243`	`242`	`}`
`@@ -1881,7 +1880,6 @@ ss::future<vote_reply> consensus::do_vote(vote_request r) {`
`1881`	`1880`	`do_step_down("candidate_term_greater");`
`1882`	`1881`	`if (_leader_id) {`
`1883`	`1882`	`_leader_id = std::nullopt;`
`1884`		`- trigger_leadership_notification();`
`1885`	`1883`	`}`
`1886`	`1884`
`1887`	`1885`	`// do not grant vote if log isn't ok`
`@@ -3134,7 +3132,6 @@ ss::future<> consensus::maybe_commit_configuration(ssx::semaphore_units u) {`
`3134`	`3132`	`co_await transfer_and_stepdown("no_longer_member");`
`3135`	`3133`	`if (_leader_id) {`
`3136`	`3134`	`_leader_id = std::nullopt;`
`3137`		`- trigger_leadership_notification();`
`3138`	`3135`	`}`
`3139`	`3136`	`}`
`3140`	`3137`	`}`
`@@ -3664,7 +3661,6 @@ consensus::do_transfer_leadership(transfer_leadership_request req) {`
`3664`	`3661`	`do_step_down("leadership_transfer");`
`3665`	`3662`	`if (_leader_id) {`
`3666`	`3663`	`_leader_id = std::nullopt;`
`3667`		`- trigger_leadership_notification();`
`3668`	`3664`	`}`
`3669`	`3665`
`3670`	`3666`	`return make_error_code(errc::success);`
Original file line number	Diff line number	Diff line change
`@@ -359,7 +359,6 @@ class consensus {`
`359`	`359`	`do_step_down(fmt::format("external_stepdown - {}", ctx));`
`360`	`360`	`if (_leader_id) {`
`361`	`361`	`_leader_id = std::nullopt;`
`362`		`- trigger_leadership_notification();`
`363`	`362`	`}`
`364`	`363`	`});`
`365`	`364`	`}`
Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,6 @@ ss::future<election_success> vote_stm::vote(bool leadership_transfer) {`
`140`	`140`	`// only trigger notification when we had a leader previously`
`141`	`141`	`if (_ptr->_leader_id) {`
`142`	`142`	`_ptr->_leader_id = std::nullopt;`
`143`		`- _ptr->trigger_leadership_notification();`
`144`	`143`	`}`
`145`	`144`
`146`	`145`	`if (_prevote && leadership_transfer) {`