Skip to content

Commit 88ea42b

Browse files
Merge pull request #26531 from vbotbuildovich/backport-pr-26530-v24.3.x-406
[v24.3.x] `kafka`: use `chunked_vector` in `describe_groups_handler::handle`
2 parents bfada7b + d524967 commit 88ea42b

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/v/kafka/server/server.cc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@
6969
#include "security/scram_authenticator.h"
7070
#include "ssx/future-util.h"
7171
#include "ssx/thread_worker.h"
72+
#include "ssx/when_all.h"
7273
#include "strings/string_switch.h"
7374
#include "strings/utf8.h"
7475

@@ -1870,7 +1871,7 @@ describe_groups_handler::handle(request_context ctx, ss::smp_service_group) {
18701871
describe_groups_response response;
18711872

18721873
if (likely(!request.data.groups.empty())) {
1873-
std::vector<ss::future<described_group>> described;
1874+
chunked_vector<ss::future<described_group>> described;
18741875
described.reserve(request.data.groups.size());
18751876
for (auto& group_id : request.data.groups) {
18761877
described.push_back(ctx.groups().describe_group(group_id).then(
@@ -1882,12 +1883,11 @@ describe_groups_handler::handle(request_context ctx, ss::smp_service_group) {
18821883
return res;
18831884
}));
18841885
}
1885-
auto group_v = co_await ss::when_all_succeed(
1886-
described.begin(), described.end());
1886+
auto group_v
1887+
= co_await ssx::when_all_succeed<chunked_vector<described_group>>(
1888+
std::move(described));
18871889

1888-
response.data.groups = {
1889-
std::make_move_iterator(group_v.begin()),
1890-
std::make_move_iterator(group_v.end())};
1890+
response.data.groups = std::move(group_v);
18911891
}
18921892

18931893
for (auto& group : unauthorized) {

0 commit comments

Comments
 (0)