Commit 0b11655
authored
fix: JSX transforms issue with favicon links
## Context
We do several [transformations](https://github.com/redwoodjs/sdk/blob/b839158d5f89eee392a4ab39041e7ebfb0b5eb49/docs/architecture/documentTransforms.md) to the jsx for `Document`s , using ts-morph.
## Problem
We had some transformation being done for nodes already removed from the ast, causing ts-morph to throw an error.
## Solution
Do several passes: first collect all the info we need, then do the modifications after. By not mixing collection and modification, we avoid ending up accessing removed nodes.1 parent 2bab283 commit 0b11655
File tree
5 files changed
+718
-219
lines changed- sdk
- src
- scripts
- vite
5 files changed
+718
-219
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
154 | 154 | | |
155 | 155 | | |
156 | 156 | | |
157 | | - | |
158 | 157 | | |
159 | 158 | | |
160 | | - | |
| 159 | + | |
| 160 | + | |
161 | 161 | | |
162 | 162 | | |
163 | 163 | | |
| |||
178 | 178 | | |
179 | 179 | | |
180 | 180 | | |
| 181 | + | |
181 | 182 | | |
182 | 183 | | |
183 | 184 | | |
| 185 | + | |
184 | 186 | | |
185 | 187 | | |
186 | 188 | | |
| |||
0 commit comments