Skip to content

Commit 5a4fcde

Browse files
committed
Enable full test matrix for nightly tests.
1 parent dc474f1 commit 5a4fcde

File tree

3 files changed

+27
-11
lines changed

3 files changed

+27
-11
lines changed

.github/workflows/nightly-tests.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,11 @@ jobs:
1010
smoke-test-starters:
1111
uses: ./.github/workflows/smoke-test-starters.yml
1212
secrets: inherit
13+
with:
14+
run_full_matrix: true
1315

1416
playground-e2e-tests:
1517
uses: ./.github/workflows/playground-e2e-tests.yml
1618
secrets: inherit
19+
with:
20+
run_full_matrix: true

.github/workflows/playground-e2e-tests.yml

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,12 @@ on:
4141
# todo(justinvdm, 25 Sep 2025): Re-enable yarn-classic once E2E tests are fixed
4242
# - yarn-classic
4343
workflow_call:
44+
inputs:
45+
run_full_matrix:
46+
description: "Run the full test matrix"
47+
required: false
48+
type: boolean
49+
default: false
4450

4551
concurrency:
4652
group: ${{ github.workflow }}-${{ github.ref }}
@@ -58,9 +64,10 @@ jobs:
5864
steps:
5965
- id: set-matrix
6066
run: |
61-
if [ "${{ github.event_name }}" == "pull_request" ] || [ "${{ github.event_name }}" == "push" ]; then
62-
echo 'matrix={"include":[{"os":"ubuntu-latest","package-manager":"npm"}]}' >> $GITHUB_OUTPUT
63-
elif [ "${{ github.event_name }}" == "workflow_dispatch" ]; then
67+
if [[ "${{ inputs.run_full_matrix }}" == "true" ]]; then
68+
# todo(justinvdm, 25 Sep 2025): Re-enable yarn-classic once E2E tests are fixed
69+
echo 'matrix={"include":[{"os":"ubuntu-latest","package-manager":"pnpm"},{"os":"ubuntu-latest","package-manager":"npm"},{"os":"ubuntu-latest","package-manager":"yarn"},{"os":"macos-latest","package-manager":"pnpm"},{"os":"macos-latest","package-manager":"npm"},{"os":"macos-latest","package-manager":"yarn"}]}' >> $GITHUB_OUTPUT
70+
elif [[ "${{ github.event_name }}" == "workflow_dispatch" ]]; then
6471
OS_INPUT=${{ github.event.inputs.os }}
6572
PM_INPUT=${{ github.event.inputs.package-manager }}
6673
@@ -75,9 +82,8 @@ jobs:
7582
done
7683
done
7784
echo "matrix={\"include\":${JSON_ARRAY}}" >> $GITHUB_OUTPUT
78-
else # this is for workflow_call
79-
# todo(justinvdm, 25 Sep 2025): Re-enable yarn-classic once E2E tests are fixed
80-
echo 'matrix={"include":[{"os":"ubuntu-latest","package-manager":"pnpm"},{"os":"ubuntu-latest","package-manager":"npm"},{"os":"ubuntu-latest","package-manager":"yarn"},{"os":"macos-latest","package-manager":"pnpm"},{"os":"macos-latest","package-manager":"npm"},{"os":"macos-latest","package-manager":"yarn"}]}' >> $GITHUB_OUTPUT
85+
else
86+
echo 'matrix={"include":[{"os":"ubuntu-latest","package-manager":"npm"}]}' >> $GITHUB_OUTPUT
8187
fi
8288
8389
playground-e2e:

.github/workflows/smoke-test-starters.yml

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,12 @@ on:
4949
- yarn
5050
- yarn-classic
5151
workflow_call:
52+
inputs:
53+
run_full_matrix:
54+
description: "Run the full test matrix"
55+
required: false
56+
type: boolean
57+
default: false
5258

5359
concurrency:
5460
group: ${{ github.workflow }}-${{ github.ref }}
@@ -66,9 +72,9 @@ jobs:
6672
steps:
6773
- id: set-matrix
6874
run: |
69-
if [ "${{ github.event_name }}" == "pull_request" ] || [ "${{ github.event_name }}" == "push" ]; then
70-
echo 'matrix={"include":[{"starter":"minimal","os":"ubuntu-latest","package-manager":"npm"}]}' >> $GITHUB_OUTPUT
71-
elif [ "${{ github.event_name }}" == "workflow_dispatch" ]; then
75+
if [[ "${{ inputs.run_full_matrix }}" == "true" ]]; then
76+
echo 'matrix={"include":[{"starter":"minimal","os":"ubuntu-latest","package-manager":"pnpm"},{"starter":"minimal","os":"ubuntu-latest","package-manager":"npm"},{"starter":"minimal","os":"ubuntu-latest","package-manager":"yarn"},{"starter":"minimal","os":"ubuntu-latest","package-manager":"yarn-classic"},{"starter":"minimal","os":"macos-latest","package-manager":"pnpm"},{"starter":"minimal","os":"macos-latest","package-manager":"npm"},{"starter":"minimal","os":"macos-latest","package-manager":"yarn"},{"starter":"minimal","os":"macos-latest","package-manager":"yarn-classic"},{"starter":"standard","os":"ubuntu-latest","package-manager":"pnpm"},{"starter":"standard","os":"ubuntu-latest","package-manager":"npm"},{"starter":"standard","os":"ubuntu-latest","package-manager":"yarn"},{"starter":"standard","os":"ubuntu-latest","package-manager":"yarn-classic"},{"starter":"standard","os":"macos-latest","package-manager":"pnpm"},{"starter":"standard","os":"macos-latest","package-manager":"npm"},{"starter":"standard","os":"macos-latest","package-manager":"yarn"},{"starter":"standard","os":"macos-latest","package-manager":"yarn-classic"}]}' >> $GITHUB_OUTPUT
77+
elif [[ "${{ github.event_name }}" == "workflow_dispatch" ]]; then
7278
STARTER_INPUT=${{ github.event.inputs.starter }}
7379
OS_INPUT=${{ github.event.inputs.os }}
7480
PM_INPUT=${{ github.event.inputs.package-manager }}
@@ -86,8 +92,8 @@ jobs:
8692
done
8793
done
8894
echo "matrix={\"include\":${JSON_ARRAY}}" >> $GITHUB_OUTPUT
89-
else # this is for workflow_call
90-
echo 'matrix={"include":[{"starter":"minimal","os":"ubuntu-latest","package-manager":"pnpm"},{"starter":"minimal","os":"ubuntu-latest","package-manager":"npm"},{"starter":"minimal","os":"ubuntu-latest","package-manager":"yarn"},{"starter":"minimal","os":"ubuntu-latest","package-manager":"yarn-classic"},{"starter":"minimal","os":"macos-latest","package-manager":"pnpm"},{"starter":"minimal","os":"macos-latest","package-manager":"npm"},{"starter":"minimal","os":"macos-latest","package-manager":"yarn"},{"starter":"minimal","os":"macos-latest","package-manager":"yarn-classic"},{"starter":"standard","os":"ubuntu-latest","package-manager":"pnpm"},{"starter":"standard","os":"ubuntu-latest","package-manager":"npm"},{"starter":"standard","os":"ubuntu-latest","package-manager":"yarn"},{"starter":"standard","os":"ubuntu-latest","package-manager":"yarn-classic"},{"starter":"standard","os":"macos-latest","package-manager":"pnpm"},{"starter":"standard","os":"macos-latest","package-manager":"npm"},{"starter":"standard","os":"macos-latest","package-manager":"yarn"},{"starter":"standard","os":"macos-latest","package-manager":"yarn-classic"}]}' >> $GITHUB_OUTPUT
95+
else
96+
echo 'matrix={"include":[{"starter":"minimal","os":"ubuntu-latest","package-manager":"npm"}]}' >> $GITHUB_OUTPUT
9197
fi
9298
9399
smoke-test:

0 commit comments

Comments
 (0)