Skip to content

Commit 79b9ca5

Browse files
committed
Update default.json to exclude unnecessary peer dependencies from starter-app-dependencies group.
1 parent 3b1d76a commit 79b9ca5

2 files changed

Lines changed: 34 additions & 2 deletions

File tree

.notes/justin/worklogs/2025-0-17-dependency-greenkeeping-strategy.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,3 +51,15 @@ The initial run of the Renovate App with the corrected pointer syntax revealed s
5151
4. **Updated Documentation**: The `CONTRIBUTING.md` file has been updated with a section explaining how to use the Dependency Dashboard to monitor and manually trigger updates.
5252

5353
With these changes, the configuration should now be correct and robust. The next run of Renovate should produce the correctly grouped PRs as originally intended.
54+
55+
### Step 14: Expanding the Peer Dependency Group
56+
57+
A review of the `sdk` and `starters` `package.json` files revealed that the `starter-peer-dependencies` group was incomplete. It was missing the critical `react` packages and their associated types.
58+
59+
**Finding:**
60+
61+
The initial focus was on the Cloudflare and Vite dependencies, but `react`, `react-dom`, `react-server-dom-webpack`, and their corresponding `@types/*` packages are also essential peer dependencies for the starter projects. For maximum stability, these packages and their types should be updated together with the other peer dependencies in the high-priority group.
62+
63+
**Action:**
64+
65+
The `default.json` configuration has been updated to expand the `starter-peer-dependencies` group. This group now includes all `react` packages and their types, as well as `@cloudflare/workers-types`. The `starter-app-dependencies` group has also been updated to exclude these packages, preventing any grouping conflicts.

default.json

Lines changed: 22 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,34 @@
3535
{
3636
"description": "Group all starter application dependencies into a single weekly PR.",
3737
"matchFileNames": ["starters/**/package.json"],
38-
"excludePackageNames": ["@cloudflare/vite-plugin", "wrangler", "vite"],
38+
"excludePackageNames": [
39+
"@cloudflare/vite-plugin",
40+
"@cloudflare/workers-types",
41+
"wrangler",
42+
"vite",
43+
"react",
44+
"react-dom",
45+
"react-server-dom-webpack",
46+
"@types/react",
47+
"@types/react-dom"
48+
],
3949
"groupName": "starter-app-dependencies",
4050
"schedule": ["on saturday"]
4151
},
4252
{
4353
"description": "Update peer dependencies in starter projects as soon as they are available.",
4454
"matchFileNames": ["starters/**/package.json"],
45-
"matchPackageNames": ["@cloudflare/vite-plugin", "wrangler", "vite"],
55+
"matchPackageNames": [
56+
"@cloudflare/vite-plugin",
57+
"@cloudflare/workers-types",
58+
"wrangler",
59+
"vite",
60+
"react",
61+
"react-dom",
62+
"react-server-dom-webpack",
63+
"@types/react",
64+
"@types/react-dom"
65+
],
4666
"groupName": "starter-peer-dependencies",
4767
"schedule": ["every weekend"],
4868
"prPriority": 1

0 commit comments

Comments
 (0)