redwoodjs
diff --git a/‎.github/workflows/check-starters.yml‎
Lines changed: 0 additions & 45 deletions b/‎.github/workflows/check-starters.yml‎
Lines changed: 0 additions & 45 deletions
diff --git a/‎.github/workflows/playground-e2e-tests.yml‎
Lines changed: 4 additions & 0 deletions b/‎.github/workflows/playground-e2e-tests.yml‎
Lines changed: 4 additions & 0 deletions
diff --git a/‎.github/workflows/smoke-test-starters.yml‎
Lines changed: 4 additions & 0 deletions b/‎.github/workflows/smoke-test-starters.yml‎
Lines changed: 4 additions & 0 deletions
diff --git a/‎.gitignore‎
Lines changed: 1 addition & 0 deletions b/‎.gitignore‎
Lines changed: 1 addition & 0 deletions
diff --git a/‎.notes/justin/worklogs/2025-09-21-fix-esbuild-scanner-error.md‎
Lines changed: 290 additions & 0 deletions b/‎.notes/justin/worklogs/2025-09-21-fix-esbuild-scanner-error.md‎
Lines changed: 290 additions & 0 deletions
diff --git a/‎.notes/justin/worklogs/205-09-21-fix-esbuild-scanner-error.md‎
Lines changed: 27 additions & 0 deletions b/‎.notes/justin/worklogs/205-09-21-fix-esbuild-scanner-error.md‎
Lines changed: 27 additions & 0 deletions
diff --git a/‎playground/hello-world/package.json‎
Lines changed: 8 additions & 7 deletions b/‎playground/hello-world/package.json‎
Lines changed: 8 additions & 7 deletions
diff --git a/‎playground/hello-world/worker-configuration.d.ts‎
Lines changed: 104 additions & 13 deletions b/‎playground/hello-world/worker-configuration.d.ts‎
Lines changed: 104 additions & 13 deletions
diff --git a/‎playground/render-apis/package.json‎
Lines changed: 8 additions & 7 deletions b/‎playground/render-apis/package.json‎
Lines changed: 8 additions & 7 deletions
diff --git a/‎playground/useid-test/__tests__/e2e.test.mts‎
Lines changed: 3 additions & 1 deletion b/‎playground/useid-test/__tests__/e2e.test.mts‎
Lines changed: 3 additions & 1 deletion
@@ -6,11 +6,15 @@ on:
       - main
     paths-ignore:
       - "docs/**"
+      - ".notes/**"
+      - "*.md"
   pull_request:
     branches:
       - main
     paths-ignore:
       - "docs/**"
+      - ".notes/**"
+      - "*.md"
   workflow_dispatch:
     inputs:
       os:
 
@@ -6,11 +6,15 @@ on:
       - main
     paths-ignore:
       - "docs/**"
+      - ".notes/**"
+      - "*.md"
   pull_request:
     branches:
       - main
     paths-ignore:
       - "docs/**"
+      - ".notes/**"
+      - "*.md"
   workflow_dispatch:
     inputs:
       starter:
 
@@ -187,4 +187,5 @@ smoke-test-artifacts
 # But we also don't want to commit the cursor rules to this repo
 starters/standard/.cursor/rules/*
 starters/standard/.pnpm-store
+
 .cursor/rules/user
@@ -0,0 +1,27 @@
+Running the type check separately was problematic because it would run before the necessary types had been generated. Relying on the `generate` script's built-in type check ensures that types are checked at the correct point in the process, resolving the CI failures.
+
+## PR Description
+
+### Manual Changes and Fixes
+
+This PR includes manual changes to address issues that arose from the automated dependency updates.
+
+#### Problem
+
+The dependency updates, primarily to Vite and its internal esbuild version, introduced several breaking changes and revealed weaknesses in the CI process:
+
+1.  **Build Failures**: An esbuild version bump caused a breaking change in its API, leading to build failures in the directive scanner.
+2.  **CI Blind Spots**: The existing CI (`check-starters.yml`) used workspace linking, which masked type inconsistencies and did not accurately simulate a real user's package installation. This allowed type errors related to Vite's updated plugin API to go undetected.
+3.  **Brittle Test Environments**: Attempts to improve CI by running `npm run check` in isolated environments failed. This was due to broken `pnpm` symlinks being copied into test directories, which prevented clean dependency installation.
+4.  **Code Duplication**: The setup logic for smoke tests and the E2E tests was heavily duplicated, making maintenance difficult.
+
+#### Solution
+
+A series of fixes and refactorings were implemented to resolve these issues and make the testing process more robust:
+
+1.  **Build Fixes**: The esbuild scanner was updated to be compatible with the new API. A TypeScript error in an E2E test file related to `null` values was also corrected.
+2.  **Tarball-Based Testing**: The CI process was refactored to use tarball-based installations for E2E and smoke tests. This more accurately reflects a real user environment and successfully caught the underlying type errors.
+3.  **Test Environment Refactoring**: The project-copying and environment setup logic for both smoke and E2E tests were consolidated into a single, shared, cross-platform function. This new function correctly excludes `node_modules` to ensure clean dependency installs, resolving the broken symlink issue.
+4.  **Simplified Type Checking**: Redundant `npm run check` commands were removed from the test harnesses. The type check that runs as part of the `npm run generate` command is now the single source of truth, ensuring types are checked only after they have been correctly generated.
+
+These changes ensure the codebase is compatible with the updated dependencies and strengthen the CI process to prevent similar issues in the future.
@@ -23,19 +23,20 @@
   },
   "dependencies": {
     "rwsdk": "workspace:*",
-    "react": "19.2.0-canary-3fb190f7-20250908",
-    "react-dom": "19.2.0-canary-3fb190f7-20250908",
-    "react-server-dom-webpack": "19.2.0-canary-3fb190f7-20250908"
+    "react": "19.2.0-canary-d415fd3e-20250919",
+    "react-dom": "19.2.0-canary-d415fd3e-20250919",
+    "react-server-dom-webpack": "19.2.0-canary-d415fd3e-20250919"
   },
   "devDependencies": {
-    "@cloudflare/vite-plugin": "1.12.4",
-    "@cloudflare/workers-types": "4.20250913.0",
+    "@cloudflare/vite-plugin": "1.13.3",
+    "@cloudflare/workers-types": "4.20250921.0",
     "@types/node": "22.14.0",
     "@types/react": "19.1.2",
     "@types/react-dom": "19.1.2",
     "typescript": "5.8.3",
-    "vite": "7.1.5",
-    "wrangler": "4.35.0"
+    "vite": "7.1.6",
+    "vitest": "^3.1.1",
+    "wrangler": "4.38.0"
   },
   "pnpm": {
     "onlyBuiltDependencies": [
 
@@ -1,7 +1,10 @@
 /* eslint-disable */
-// Generated by Wrangler by running `wrangler types` (hash: 187132f48ddf0f604882ba8213fe386f)
-// Runtime types generated with workerd@1.20250906.0 2025-08-21 nodejs_compat
+// Generated by Wrangler by running `wrangler types` (hash: 6b6db21c80ba9cfeb812f12bd8b8b3e4)
+// Runtime types generated with workerd@1.20250917.0 2025-08-21 nodejs_compat
 declare namespace Cloudflare {
+	interface GlobalProps {
+		mainModule: typeof import("./src/worker");
+	}
 	interface Env {
 		ASSETS: Fetcher;
 	}
@@ -340,10 +343,10 @@ declare const origin: string;
 declare const navigator: Navigator;
 interface TestController {
 }
-interface ExecutionContext {
+interface ExecutionContext<Props = unknown> {
     waitUntil(promise: Promise<any>): void;
     passThroughOnException(): void;
-    props: any;
+    readonly props: Props;
 }
 type ExportedHandlerFetchHandler<Env = unknown, CfHostMetadata = unknown> = (request: Request<CfHostMetadata, IncomingRequestCfProperties<CfHostMetadata>>, env: Env, ctx: ExecutionContext) => Response | Promise<Response>;
 type ExportedHandlerTailHandler<Env = unknown> = (events: TraceItem[], env: Env, ctx: ExecutionContext) => void | Promise<void>;
@@ -430,9 +433,11 @@ type DurableObjectLocationHint = "wnam" | "enam" | "sam" | "weur" | "eeur" | "ap
 interface DurableObjectNamespaceGetDurableObjectOptions {
     locationHint?: DurableObjectLocationHint;
 }
-interface DurableObjectState {
+interface DurableObjectClass<_T extends Rpc.DurableObjectBranded | undefined = undefined> {
+}
+interface DurableObjectState<Props = unknown> {
     waitUntil(promise: Promise<any>): void;
-    props: any;
+    readonly props: Props;
     readonly id: DurableObjectId;
     readonly storage: DurableObjectStorage;
     container?: Container;
@@ -2569,6 +2574,17 @@ declare class MessageChannel {
 interface MessagePortPostMessageOptions {
     transfer?: any[];
 }
+type LoopbackForExport<T extends (new (...args: any[]) => Rpc.EntrypointBranded) | ExportedHandler<any, any, any> | undefined = undefined> = T extends new (...args: any[]) => Rpc.WorkerEntrypointBranded ? LoopbackServiceStub<InstanceType<T>> : T extends new (...args: any[]) => Rpc.DurableObjectBranded ? LoopbackDurableObjectClass<InstanceType<T>> : T extends ExportedHandler<any, any, any> ? LoopbackServiceStub<undefined> : undefined;
+type LoopbackServiceStub<T extends Rpc.WorkerEntrypointBranded | undefined = undefined> = Fetcher<T> & (T extends CloudflareWorkersModule.WorkerEntrypoint<any, infer Props> ? (opts: {
+    props?: Props;
+}) => Fetcher<T> : (opts: {
+    props?: any;
+}) => Fetcher<T>);
+type LoopbackDurableObjectClass<T extends Rpc.DurableObjectBranded | undefined = undefined> = DurableObjectClass<T> & (T extends CloudflareWorkersModule.DurableObject<any, infer Props> ? (opts: {
+    props?: Props;
+}) => DurableObjectClass<T> : (opts: {
+    props?: any;
+}) => DurableObjectClass<T>);
 interface SyncKvStorage {
     get<T = unknown>(key: string): T | undefined;
     list<T = unknown>(options?: SyncKvListOptions): Iterable<[
@@ -2586,6 +2602,34 @@ interface SyncKvListOptions {
     reverse?: boolean;
     limit?: number;
 }
+interface WorkerStub {
+    getEntrypoint<T extends Rpc.WorkerEntrypointBranded | undefined>(name?: string, options?: WorkerStubEntrypointOptions): Fetcher<T>;
+}
+interface WorkerStubEntrypointOptions {
+    props?: any;
+}
+interface WorkerLoader {
+    get(name: string, getCode: () => WorkerLoaderWorkerCode | Promise<WorkerLoaderWorkerCode>): WorkerStub;
+}
+interface WorkerLoaderModule {
+    js?: string;
+    cjs?: string;
+    text?: string;
+    data?: ArrayBuffer;
+    json?: any;
+    py?: string;
+}
+interface WorkerLoaderWorkerCode {
+    compatibilityDate: string;
+    compatibilityFlags?: string[];
+    allowExperimental?: boolean;
+    mainModule: string;
+    modules: Record<string, WorkerLoaderModule | string>;
+    env?: any;
+    globalOutbound?: (Fetcher | null);
+    tails?: Fetcher[];
+    streamingTails?: Fetcher[];
+}
 type AiImageClassificationInput = {
     image: number[];
 };
@@ -6305,6 +6349,11 @@ interface D1Meta {
          */
         sql_duration_ms: number;
     };
+    /**
+     * Number of total attempts to execute the query, due to automatic retries.
+     * Note: All other fields in the response like `timings` only apply to the last attempt.
+     */
+    total_attempts?: number;
 }
 interface D1Response {
     success: true;
@@ -6322,11 +6371,11 @@ type D1SessionConstraint =
 // Indicates that the first query should go to the primary, and the rest queries
 // using the same D1DatabaseSession will go to any replica that is consistent with
 // the bookmark maintained by the session (returned by the first query).
-"first-primary"
+'first-primary'
 // Indicates that the first query can go anywhere (primary or replica), and the rest queries
 // using the same D1DatabaseSession will go to any replica that is consistent with
 // the bookmark maintained by the session (returned by the first query).
- | "first-unconstrained";
+ | 'first-unconstrained';
 type D1SessionBookmark = string;
 declare abstract class D1Database {
     prepare(query: string): D1PreparedStatement;
@@ -6951,8 +7000,47 @@ declare namespace Rpc {
     };
 }
 declare namespace Cloudflare {
+    // Type of `env`.
+    //
+    // The specific project can extend `Env` by redeclaring it in project-specific files. Typescript
+    // will merge all declarations.
+    //
+    // You can use `wrangler types` to generate the `Env` type automatically.
     interface Env {
     }
+    // Project-specific parameters used to inform types.
+    //
+    // This interface is, again, intended to be declared in project-specific files, and then that
+    // declaration will be merged with this one.
+    //
+    // A project should have a declaration like this:
+    //
+    //     interface GlobalProps {
+    //       // Declares the main module's exports. Used to populate Cloudflare.Exports aka the type
+    //       // of `ctx.exports`.
+    //       mainModule: typeof import("my-main-module");
+    //
+    //       // Declares which of the main module's exports are configured with durable storage, and
+    //       // thus should behave as Durable Object namsepace bindings.
+    //       durableNamespaces: "MyDurableObject" | "AnotherDurableObject";
+    //     }
+    //
+    // You can use `wrangler types` to generate `GlobalProps` automatically.
+    interface GlobalProps {
+    }
+    // Evaluates to the type of a property in GlobalProps, defaulting to `Default` if it is not
+    // present.
+    type GlobalProp<K extends string, Default> = K extends keyof GlobalProps ? GlobalProps[K] : Default;
+    // The type of the program's main module exports, if known. Requires `GlobalProps` to declare the
+    // `mainModule` property.
+    type MainModule = GlobalProp<"mainModule", {}>;
+    // The type of ctx.exports, which contains loopback bindings for all top-level exports.
+    type Exports = {
+        [K in keyof MainModule]: LoopbackForExport<MainModule[K]>
+        // If the export is listed in `durableNamespaces`, then it is also a
+        // DurableObjectNamespace.
+         & (K extends GlobalProp<"durableNamespaces", never> ? MainModule[K] extends new (...args: any[]) => infer DoInstance ? DoInstance extends Rpc.DurableObjectBranded ? DurableObjectNamespace<DoInstance> : DurableObjectNamespace<undefined> : DurableObjectNamespace<undefined> : {});
+    };
 }
 declare module 'cloudflare:node' {
     export interface DefaultHandler {
@@ -6967,7 +7055,7 @@ declare module 'cloudflare:node' {
         port: number;
     }, handlers?: Omit<DefaultHandler, 'fetch'>): DefaultHandler;
 }
-declare module 'cloudflare:workers' {
+declare namespace CloudflareWorkersModule {
     export type RpcStub<T extends Rpc.Stubable> = Rpc.Stub<T>;
     export const RpcStub: {
         new <T extends Rpc.Stubable>(value: T): Rpc.Stub<T>;
@@ -6976,9 +7064,9 @@ declare module 'cloudflare:workers' {
         [Rpc.__RPC_TARGET_BRAND]: never;
     }
     // `protected` fields don't appear in `keyof`s, so can't be accessed over RPC
-    export abstract class WorkerEntrypoint<Env = unknown> implements Rpc.WorkerEntrypointBranded {
+    export abstract class WorkerEntrypoint<Env = Cloudflare.Env, Props = {}> implements Rpc.WorkerEntrypointBranded {
         [Rpc.__WORKER_ENTRYPOINT_BRAND]: never;
-        protected ctx: ExecutionContext;
+        protected ctx: ExecutionContext<Props>;
         protected env: Env;
         constructor(ctx: ExecutionContext, env: Env);
         fetch?(request: Request): Response | Promise<Response>;
@@ -6988,9 +7076,9 @@ declare module 'cloudflare:workers' {
         queue?(batch: MessageBatch<unknown>): void | Promise<void>;
         test?(controller: TestController): void | Promise<void>;
     }
-    export abstract class DurableObject<Env = unknown> implements Rpc.DurableObjectBranded {
+    export abstract class DurableObject<Env = Cloudflare.Env, Props = {}> implements Rpc.DurableObjectBranded {
         [Rpc.__DURABLE_OBJECT_BRAND]: never;
-        protected ctx: DurableObjectState;
+        protected ctx: DurableObjectState<Props>;
         protected env: Env;
         constructor(ctx: DurableObjectState, env: Env);
         fetch?(request: Request): Response | Promise<Response>;
@@ -7043,6 +7131,9 @@ declare module 'cloudflare:workers' {
     export function waitUntil(promise: Promise<unknown>): void;
     export const env: Cloudflare.Env;
 }
+declare module 'cloudflare:workers' {
+    export = CloudflareWorkersModule;
+}
 interface SecretsStoreSecret {
     /**
      * Get a secret from the Secrets Store, returning a string of the secret value
 
@@ -23,19 +23,20 @@
   },
   "dependencies": {
     "rwsdk": "workspace:*",
-    "react": "19.2.0-canary-3fb190f7-20250908",
-    "react-dom": "19.2.0-canary-3fb190f7-20250908",
-    "react-server-dom-webpack": "19.2.0-canary-3fb190f7-20250908"
+    "react": "19.2.0-canary-d415fd3e-20250919",
+    "react-dom": "19.2.0-canary-d415fd3e-20250919",
+    "react-server-dom-webpack": "19.2.0-canary-d415fd3e-20250919"
   },
   "devDependencies": {
-    "@cloudflare/vite-plugin": "1.12.4",
-    "@cloudflare/workers-types": "4.20250913.0",
+    "@cloudflare/vite-plugin": "1.13.3",
+    "@cloudflare/workers-types": "4.20250921.0",
     "@types/node": "22.14.0",
     "@types/react": "19.1.2",
     "@types/react-dom": "19.1.2",
     "typescript": "5.8.3",
-    "vite": "7.1.5",
-    "wrangler": "4.35.0"
+    "vite": "7.1.6",
+    "vitest": "^3.1.1",
+    "wrangler": "4.38.0"
   },
   "pnpm": {
     "onlyBuiltDependencies": [
 
@@ -177,7 +177,9 @@ describe("useId Playground", () => {
             page.evaluate((element: Element) => element.textContent, el),
           ),
         );
-        return statuses.every((status: string) => status.includes("Hydrated"));
+        return statuses.every(
+          (status: string | null) => status?.includes("Hydrated") ?? false,
+        );
       });
 
       // Get IDs after hydration