Skip to content

Commit 8bd1b4b

Browse files
Fixes incorrect reference checks in clone unit tests
Updates clone-related unit tests to ensure deep object comparisons use address-of operators for consistent reference checks. This prevents false positives when asserting object independence and improves test reliability.
1 parent d5ddf26 commit 8bd1b4b

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

server/pkg/property/initializer_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ func TestInitializer_Clone(t *testing.T) {
2020

2121
assert.NotSame(t, cloned, initializer)
2222
if len(cloned.Items) > 0 && len(initializer.Items) > 0 {
23-
assert.NotSame(t, cloned.Items, initializer.Items)
23+
assert.NotSame(t, &cloned.Items, &initializer.Items)
2424
assert.NotSame(t, cloned.Items[0], initializer.Items[0])
2525
}
2626
assert.Equal(t, *cloned, *initializer)
@@ -109,10 +109,10 @@ func TestInitializerItem_Clone(t *testing.T) {
109109

110110
assert.NotSame(t, cloned, item)
111111
if len(cloned.Groups) > 0 && len(item.Groups) > 0 {
112-
assert.NotSame(t, cloned.Groups, item.Groups)
112+
assert.NotSame(t, &cloned.Groups, &item.Groups)
113113
assert.NotSame(t, cloned.Groups[0], item.Groups[0])
114114
if len(cloned.Groups[0].Fields) > 0 && len(item.Groups[0].Fields) > 0 {
115-
assert.NotSame(t, cloned.Groups[0].Fields, item.Groups[0].Fields)
115+
assert.NotSame(t, &cloned.Groups[0].Fields, &item.Groups[0].Fields)
116116
assert.NotSame(t, cloned.Groups[0].Fields[0], item.Groups[0].Fields[0])
117117
}
118118
}
@@ -200,7 +200,7 @@ func TestInitializerGroup_Clone(t *testing.T) {
200200

201201
assert.NotSame(t, cloned, item)
202202
if len(cloned.Fields) > 0 && len(item.Fields) > 0 {
203-
assert.NotSame(t, cloned.Fields, item.Fields)
203+
assert.NotSame(t, &cloned.Fields, &item.Fields)
204204
assert.NotSame(t, cloned.Fields[0], item.Fields[0])
205205
}
206206
assert.Equal(t, *cloned, *item)
@@ -249,7 +249,7 @@ func TestInitializerField_Clone(t *testing.T) {
249249

250250
assert.NotSame(t, cloned, field)
251251
if len(cloned.Links) > 0 && len(field.Links) > 0 {
252-
assert.NotSame(t, cloned.Links, field.Links)
252+
assert.NotSame(t, &cloned.Links, &field.Links)
253253
}
254254
assert.Equal(t, *cloned, *field)
255255
}

0 commit comments

Comments
 (0)