Skip to content

fix(docs): correct the method name of notification provider - #6856

Merged
alicanerdurmaz merged 1 commit into
refinedev:mainfrom
clement-lta:main
Jul 2, 2025
Merged

fix(docs): correct the method name of notification provider#6856
alicanerdurmaz merged 1 commit into
refinedev:mainfrom
clement-lta:main

Conversation

@clement-lta

@clement-lta clement-lta commented Jun 28, 2025

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

At the top of the notification provider in docs. we said that a notificationProvider must include following methods:

const notificationProvider = {
  show: () => {},
  close: () => {},
};

but in the codebase, we have open instead of show

What is the new behavior?

Change to correct method name from show -> open

@clement-lta
clement-lta requested a review from a team as a code owner June 28, 2025 11:08
@changeset-bot

changeset-bot Bot commented Jun 28, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0764b49

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify

netlify Bot commented Jun 28, 2025

Copy link
Copy Markdown

Deploy Preview for refine-doc-live-previews ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0764b49
🔍 Latest deploy log https://app.netlify.com/projects/refine-doc-live-previews/deploys/685fcd23f26a190008c8fbac
😎 Deploy Preview https://deploy-preview-6856--refine-doc-live-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@alicanerdurmaz
alicanerdurmaz merged commit f455773 into refinedev:main Jul 2, 2025
4 checks passed
@alicanerdurmaz alicanerdurmaz added this to the June 2025 Release milestone Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants