Why a deprecation error, when I can make a Pyroma rating? (#110)

Author: regebro

CHANGES.txt

@@ -4,7 +4,9 @@ Changelog
 5.0 (unreleased)
 ----------------
 
-- Nothing changed yet.
+- Deprecation warnings? For the packaging configuration? What was I thinking?
+  I'm instead adding a rating telling people that they should add a
+  pyproject.toml. Much nicer.
 
 
 4.3 (2025-07-01)

Makefile

@@ -15,8 +15,7 @@ help: ## display this message
 	@python -c "$$PRINT_HELP_PYSCRIPT" < $(MAKEFILE_LIST)
 
 generate: ## generate environment for tests
-	cd pyroma/testdata/complete
-	python setup.py sdist --formats=bztar,gztar,tar,zip
+	cd pyroma/testdata/complete;python setup.py sdist --formats=bztar,gztar,tar,zip
 	cp pyroma/testdata/complete/dist/complete-1.0.dev1.* pyroma/testdata/distributions/
 
 tests: generate ## run tests

pyroma/__init__.py

@@ -16,16 +16,6 @@ def zester(data):
     if not config_files & main_files:
         return
 
-    if "setup.py" in config_files & main_files:
-        import warnings
-
-        warnings.showwarning(
-            message="Using setup.py is deprecated, and Pyroma support for setup.py will be dropped in version 5.0",
-            category=DeprecationWarning,
-            filename=__name__ + ".py",
-            lineno=19,
-        )
-
     from zest.releaser.utils import ask
 
     if ask("Run pyroma on the package before tagging?"):

pyroma/projectdata.py

@@ -59,8 +59,11 @@ def map_metadata_keys(metadata):
 
 
 def get_build_data(path, isolated=None):
-    metadata = build_metadata(path, isolated=isolated)
-    return map_metadata_keys(metadata)
+    metadata = map_metadata_keys(build_metadata(path, isolated=isolated))
+    # Check if there is a pyproject_toml
+    if "pyproject.toml" not in os.listdir(path):
+        metadata["_missing_pyproject_toml"] = True
+    return metadata
 
 
 def get_setupcfg_data(path):
@@ -240,15 +243,6 @@ def get_setuppy_data(path):
     with FakeContext(path):
         with SetupMonkey() as sm:
             if os.path.isfile("setup.py"):
-                import warnings
-
-                warnings.showwarning(
-                    message="Using setup.py is deprecated, and Pyroma support for setup.py "
-                    "will be dropped in version 5.0",
-                    category=DeprecationWarning,
-                    filename=__name__ + ".py",
-                    lineno=242,
-                )
 
                 try:
                     distro = run_setup("setup.py", stop_after="config")

pyroma/ratings.py

@@ -15,7 +15,6 @@
 #                 False for fail and None for not applicable (meaning it will
 #                 not be counted).
 import io
-import os
 import re
 from collections import defaultdict
 
@@ -463,7 +462,24 @@ def message(self):
             "    [build-system]\n"
             '    requires = ["setuptools>=42"]\n'
             '    build-backend = "setuptools.build_meta"\n\n'
-            'In the future this will become a hard failure and your package will be rated as "not cheese".'
+            'In the future this may become a hard failure and your package may be rated as "not cheese".'
+        )
+
+
+class MissingPyProjectToml(BaseTest):
+    def test(self, data):
+        if "_missing_pyproject_toml" in data:
+            # These sort of "negative only/deprecation" ratings only give you negative weight
+            self.weight = 100
+            return False
+
+    def message(self):
+        return (
+            "Your project does not have a pyproject.toml file, which is highly recommended.\n"
+            "You probably want to create one with the following configuration:\n\n"
+            "    [build-system]\n"
+            '    requires = ["setuptools>=42"]\n'
+            '    build-backend = "setuptools.build_meta"\n\n'
         )
 
 
@@ -505,6 +521,7 @@ def message(self):
     DevStatusClassifier(),
     MissingBuildSystem(),
     StoneAgeSetupPy(),
+    MissingPyProjectToml(),
 ]
 
 try:
@@ -517,10 +534,6 @@ def test(self, data):
             if "_path" not in data:
                 return None
 
-            if not os.path.exists(data["_path"]):
-                import pdb
-
-                pdb.set_trace()
             self.weight = 200
             try:
                 return check_manifest.check_manifest(data["_path"])

pyroma/testdata/complete/pyproject.toml

@@ -0,0 +1,2 @@
+[tool.black]
+line-length = 120

pyroma/testdata/custom_test/pyproject.toml

@@ -0,0 +1,2 @@
+[tool.black]
+line-length = 120