feat: upgrade to py-rattler 0.21.0 (#92)

* prod: see if latest py-rattler works

* feat: upgrade to py-rattler 0.21

* test: update tests for outdated ref

* Apply suggestion from @beckermr

* Apply suggestion from @beckermr

Author: beckermr

.pre-commit-config.yaml

@@ -26,7 +26,7 @@ repos:
     rev: v0.14.10
     hooks:
       # Run the linter.
-      - id: ruff
+      - id: ruff-check
         args: [ --fix ]
       # Run the formatter.
       - id: ruff-format

conda_forge_feedstock_check_solvable/check_solvable.py

@@ -353,6 +353,8 @@ def _is_recipe_solvable_on_platform(
             )
             timeout_timer.raise_for_timeout()
 
+            print_debug("build run exports::\n\n%s\n" % pprint.pformat(build_rx))
+
             solvable = solvable and _solvable
             if _err is not None:
                 errors.append(_err)
@@ -394,6 +396,8 @@ def _is_recipe_solvable_on_platform(
             )
             timeout_timer.raise_for_timeout()
 
+            print_debug("host run exports::\n\n%s\n" % pprint.pformat(host_rx))
+
             solvable = solvable and _solvable
             if _err is not None:
                 errors.append(_err)

conda_forge_feedstock_check_solvable/rattler_build.py

@@ -1,15 +1,18 @@
+import atexit
 import os
 import subprocess
 import tempfile
 import uuid
 
 import yaml
 
-from conda_forge_feedstock_check_solvable.utils import print_debug
+from conda_forge_feedstock_check_solvable.utils import clean_rattler_cache, print_debug
 from conda_forge_feedstock_check_solvable.virtual_packages import (
     virtual_package_repodata,
 )
 
+atexit.register(clean_rattler_cache)
+
 
 def run_rattler_build(command):
     try:
@@ -27,20 +30,6 @@ def run_rattler_build(command):
         return status_code, stdout, stderr
     except Exception as e:
         return -1, "", str(e)
-    finally:
-        try:
-            subprocess.run(
-                [
-                    "pixi",
-                    "clean",
-                    "cache",
-                    "--yes",
-                ],
-                check=False,
-                capture_output=True,
-            )
-        except Exception as e:
-            print_debug("pixi clean cache command failed: %r", e)
 
 
 def invoke_rattler_build(

conda_forge_feedstock_check_solvable/rattler_solver.py

@@ -1,4 +1,5 @@
 import asyncio
+import atexit
 import copy
 import datetime
 import os
@@ -11,12 +12,15 @@
 
 from conda_forge_feedstock_check_solvable.utils import (
     DEFAULT_RUN_EXPORTS,
+    clean_rattler_cache,
     convert_spec_to_conda_build,
     get_run_exports,
     print_debug,
     print_warning,
 )
 
+atexit.register(clean_rattler_cache)
+
 
 class RattlerSolver:
     """Run the rattler solver (resolvo).
@@ -171,7 +175,7 @@ def _get_run_exports(
         We only look up export data for things explicitly listed in the original
         specs.
         """
-        names = {s.name for s in _specs}
+        names = {s.name.as_package_name() for s in _specs}
         ign_rex_from = {s.name for s in ignore_run_exports_from}
         ign_rex = {s.name for s in ignore_run_exports}
         run_exports = copy.deepcopy(DEFAULT_RUN_EXPORTS)

conda_forge_feedstock_check_solvable/utils.py

@@ -697,3 +697,16 @@ def replace_pin_compatible(reqs, host_reqs, strict=False):
             new_reqs.append(req)
 
     return new_reqs
+
+
+def clean_rattler_cache():
+    subprocess.run(
+        [
+            "pixi",
+            "clean",
+            "cache",
+            "--yes",
+        ],
+        check=False,
+        capture_output=True,
+    )

requirements.txt

@@ -11,5 +11,5 @@ wurlitzer
 requests
 zstandard
 boltons>=23.0.0
-py-rattler>=0.9.0,<0.10a0
+py-rattler>=0.21.0,<0.22a0
 pixi

tests/test_check_solvable.py

@@ -161,7 +161,7 @@ def test_r_base_cross_solvable(solver):
 def test_xgboost_solvable(tmp_path, solver):
     feedstock_dir = clone_and_checkout_repo(
         tmp_path,
-        "https://github.com/conda-forge/arrow-cpp-feedstock",
+        "https://github.com/conda-forge/xgboost-feedstock",
         ref="main",
     )
 
@@ -303,9 +303,9 @@ def test_dftbplus_solvable(tmp_path, solver):
     assert solvable, pprint.pformat(errors)
 
 
-@flaky
-def test_cupy_solvable(tmp_path, solver):
-    """grpcio has a runtime dep on openssl which has strange pinning things in it"""
+@pytest.mark.xfail
+def test_cupy_solvable_at_commit(tmp_path, solver):
+    """cupy at a specific commit - old test so fails"""
     feedstock_dir = clone_and_checkout_repo(
         tmp_path,
         "https://github.com/conda-forge/cupy-feedstock",
@@ -327,6 +327,23 @@ def test_cupy_solvable(tmp_path, solver):
     assert solvable, pprint.pformat(errors)
 
 
+def test_cupy_solvable(tmp_path, solver):
+    feedstock_dir = clone_and_checkout_repo(
+        tmp_path,
+        "https://github.com/conda-forge/cupy-feedstock",
+        ref="main",
+    )
+    solvable, errors, solvable_by_variant = is_recipe_solvable(
+        feedstock_dir,
+        solver=solver,
+        verbosity=VERB,
+        timeout=None,
+        fail_fast=True,
+    )
+    pprint.pprint(solvable_by_variant)
+    assert solvable, pprint.pformat(errors)
+
+
 @flaky
 def test_run_exports_constrains_conflict(feedstock_dir, tmp_path_factory, solver):
     recipe_file = os.path.join(feedstock_dir, "recipe", "meta.yaml")