Replace DOMParser with template for fragment

wooorm · wooorm · commit d6df6d671004 · 2024-09-17T13:48:55.000+02:00
This brings the code in line w/: <https://github.com/syntax-tree/hast-util-from-html-isomorphic> Closes GH-23.
diff --git a/packages/rehype-dom-parse/lib/index.js b/packages/rehype-dom-parse/lib/index.js
@@ -1,7 +1,7 @@
 /**
  * @import {Root} from 'hast'
  * @import {Options} from 'rehype-dom-parse'
- * @import {Parser, Processor} from 'unified'
+ * @import {Processor} from 'unified'
  */
 
 import {fromDom} from 'hast-util-from-dom'
@@ -22,42 +22,41 @@ export default function parse(options) {
 
   self.parser = parser
 
-  /** @type {Parser<Root>} */
+  /**
+   * @param {string} value
+   *   Value to parse.
+   * @returns {Root}
+   *   Tree.
+   */
   function parser(value) {
-    const create = settings.fragment === false ? createDocument : createFragment
+    const create = settings.fragment === false ? parseDocument : parseFragment
     // Assume document/fragment in -> root out.
     return /** @type {Root} */ (fromDom(create(value)))
   }
 }
 
 /**
- * Create a fragment.
+ * Create a document.
  *
  * @param {string} value
- *   HTML.
- * @returns {DocumentFragment}
- *   Document fragment.
+ *   Value to parse.
+ * @returns {Document}
+ *   Document.
  */
-function createFragment(value) {
-  const node = createDocument('<!doctype html><body>' + value)
-
-  /**
-   * Pretend as a DocumentFragment node, which is fine for `fromDom`.
-   */
-  return /** @type {DocumentFragment} */ ({
-    nodeType: 11,
-    childNodes: node.body.childNodes
-  })
+function parseDocument(value) {
+  return new DOMParser().parseFromString(value, 'text/html')
 }
 
 /**
- * Create a document.
+ * Parse as a fragment.
  *
  * @param {string} value
- *   HTML.
- * @returns {Document}
- *   Document.
+ *   Value to parse.
+ * @returns {DocumentFragment}
+ *   Document fragment.
  */
-function createDocument(value) {
-  return new DOMParser().parseFromString(value, 'text/html')
+function parseFragment(value) {
+  const template = document.createElement('template')
+  template.innerHTML = value
+  return template.content
 }
