fix(modal): refine teleport-ready timing and test stability

Author: mhewson

src/components/modal/CdrModal.vue

@@ -269,7 +269,7 @@ const handleClosed = () => {
 const openAfterTeleportReady = async () => {
   const openToken = ++pendingOpenToken;
 
-  if (!teleportDisabled.value) {
+  if (!teleportDisabled.value && wrapperEl.value?.parentElement !== document.body) {
     // Wait for Teleport to move content to body before aria-hiding background.
     for (let i = 0; i < 3; i += 1) {
       await nextTick();
@@ -334,7 +334,7 @@ watch(
   },
 );
 
-onMounted(async () => {
+onMounted(() => {
   // Keep Teleport inline for SSR + hydration, then move to body on client.
   teleportDisabled.value = false;
   window.addEventListener('resize', handleResize);

src/components/modal/__tests__/CdrModal.spec.js

@@ -227,11 +227,13 @@ describe('CdrModal.vue', () => {
       });
 
       await wrapper.setProps({ opened: true });
-      await wrapper.vm.$nextTick();
-      await wrapper.vm.$nextTick();
-      await wrapper.vm.$nextTick();
+      let modalEl = null;
+      for (let i = 0; i < 10; i += 1) {
+        await wrapper.vm.$nextTick();
+        modalEl = document.body.querySelector('.cdr-modal');
+        if (modalEl) break;
+      }
 
-      const modalEl = document.body.querySelector('.cdr-modal');
       expect(modalEl).not.toBeNull();
       expect(modalEl.closest('[aria-hidden="true"]')).toBeNull();