You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix sarix sigma_pooling='shared' bug and update dependencies
This commit fixes a failing test for SARIX models with shared sigma pooling
and updates the sarix dependency to resolve an upstream bug.
Problem:
--------
The test `test_sarix_shared_sigma_pooling_multiple_batches` was failing with
a reshape error when using `sigma_pooling='shared'` with multiple locations.
The error occurred in the sarix library at line 392 where it incorrectly used
`theta` instead of `sigma` when reshaping arrays:
TypeError: cannot reshape array of shape (100, 5, 6) into shape (100, 1, 1)
Root Cause:
-----------
The installed sarix package (v0.0.1 from elray1/sarix) contained a bug where
the variable name was wrong in the sigma pooling code block. The reichlab/sarix
repository had already fixed this bug in v0.2.0.
Fixes:
------
1. Updated sarix dependency from elray1/sarix to reichlab/sarix (v0.2.0)
2. Updated requires-python from >=3.9 to >=3.11 (required by newer sarix)
3. Regenerated uv.lock with updated dependencies
4. Regenerated requirements.txt and requirements-dev.txt
5. Added explicit string conversion for output_type_id in CSV output
6. Fixed test assertion to handle pandas type inference for output_type_id
Test Results:
-------------
✅ test_sarix - PASSED
✅ test_sarix_shared_sigma_pooling_multiple_batches - PASSED (was failing)
✅ test_drop_level_feats - PASSED
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
0 commit comments