Skip to content

RASP Eng export doesn't have validation. #54

Description

@SparkRocketLab

When I went to export a RASP Engine file, I ran into a validation issue with 2 of the fields.

No Spaces

It turns out the RASP Eng file format does not allow spaces to be in either the motor designation or name. However, RMTS will let you input spaces without issues. I see 2 ways to solve this problem:

  1. Update PyFormGen to allow an optional validation function. This would enable custom validations for future issues and allow the user to fix the error how they see fit by displaying a validation message and canceling the save.
  2. Escape spaces with a character like an underline in the engExportWidget okPressed function. This is easier but not as transparent to the user.

Let me know what way which way you to go and I'll post a PR.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions