Skip to content

Commit 88c3173

Browse files
stack overflow fix
1 parent 8b7100f commit 88c3173

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

Reinforced.Typings/TypeResolver.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,8 @@ private RtTypeName ResolveTypeNameInner(Type t)
275275
return Cache(t, ConstructFunctionType(methodInfo));
276276
}
277277

278-
if (t.IsGenericType)
278+
279+
if (t.IsGenericType && !t.IsGenericTypeDefinition)
279280
{
280281
var def = t.GetGenericTypeDefinition();
281282
var tsFriendly = ResolveTypeNameInner(def) as RtSimpleTypeName;
@@ -288,7 +289,9 @@ private RtTypeName ResolveTypeNameInner(Type t)
288289
};
289290
return Cache(t, parametrized);
290291
}
292+
291293
}
294+
292295
_context.Warnings.Add(ErrorMessages.RTW0003_TypeUnknown.Warn(t.FullName));
293296

294297
return Cache(t, AnyType);

package/Reinforced.Typings.nuspec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<package xmlns="http://schemas.microsoft.com/packaging/2011/08/nuspec.xsd">
33
<metadata>
44
<id>Reinforced.Typings</id>
5-
<version>1.2.3</version>
5+
<version>1.2.4</version>
66
<title>Reinforced.Typings</title>
77
<authors>Pavel B. Novikov</authors>
88
<owners>Pavel B. Novikov</owners>
@@ -16,7 +16,7 @@
1616
<tags>mvc, web, typescript</tags>
1717
<licenseUrl>https://github.com/reinforced/Reinforced.Typings/blob/master/LICENSE.md</licenseUrl>
1818
<releaseNotes>
19-
- Generic type resolvation improvement
19+
- Critical stack overflow fix when trying to resolve complex generic type
2020
</releaseNotes>
2121
</metadata>
2222
</package>

0 commit comments

Comments
 (0)