Skip to content

Remove dead 'date_groups' config key #10

@ManukMinasyan

Description

@ManukMinasyan

Summary

The date_groups key in config/activity-log.php is unused. The buckets a user sees in the timeline are computed by ActivityLogLivewire::bucketFor and ignore config entirely.

Repro

grep -r "date_groups" src/
# (no matches)

The lang file resources/lang/en/messages.php only ships keys for this_week, last_week, week_of — matching what bucketFor() actually emits.

Expected vs actual

  • Documented (and currently shipped in config/activity-log.php): 6 bucket labels (today, yesterday, this_week, last_week, this_month, older).
  • Reality: 3 buckets emitted by the Livewire component (this_week, last_week, week_of <date>).

Recommended fix

Choose one:

  1. Delete the key from config/activity-log.php and document the bucketing as fixed.
  2. Wire the key into bucketFor() so users can customize bucket labels and grouping windows.

Option 1 is lower-risk and matches current behavior. Option 2 is the more ambitious feature.

Tracked by docs spec

Finding A1 in the upcoming docs restructure.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions