fixes

Author: Bala-Sakabattula

sync2jira/downstream_issue.py

@@ -1244,7 +1244,7 @@ def _update_assignee(client, existing, issue, overwrite):
                 # Overwrite the downstream assignment only if it is different
                 # from the upstream one.
                 dn = _jira_user_display_label(assignee)
-                update = un != dn and remove_diacritics(un) != dn
+                update = un != dn and remove_diacritics(un) != remove_diacritics(dn)
             else:
                 # Upstream assignee has no fullname; let assign_user() resolve
                 # via LDAP/email lookup using the login.

tests/test_downstream_issue.py

@@ -1716,7 +1716,7 @@ def test_update_assignee_all(self, mock_client, mock_assign_user):
                 (32, False),
                 #       - upstream assignee exists: called with remove_all=False
                 (33, False),
-                #       - upstream assignee has a fullname of None: called with remove_all=False
+                #       - upstream assignee has login but fullname is None: called with remove_all=False
                 (34, False),
                 #       - upstream assignee has login but no fullname key: called with remove_all=False
                 (35, False),
@@ -1732,7 +1732,7 @@ def test_update_assignee_all(self, mock_client, mock_assign_user):
                 (42, None),
                 #       - upstream assignee exists and assignments are different: not called
                 (43, None),
-                #       - upstream assignee has a fullname of None: not called
+                #       - upstream assignee has login but fullname is None: not called
                 (44, None),
                 #       - upstream assignee has login but no fullname key: not called
                 (45, None),
@@ -1747,7 +1747,7 @@ def test_update_assignee_all(self, mock_client, mock_assign_user):
                 (52, None),
                 #       - upstream assignee exists and assignments are different: not called
                 (53, None),
-                #       - upstream assignee has a fullname of None: not called
+                #       - upstream assignee has login but fullname is None: not called
                 (54, None),
                 #       - upstream assignee has login but no fullname key: not called
                 (55, None),
@@ -1762,7 +1762,7 @@ def test_update_assignee_all(self, mock_client, mock_assign_user):
                 (62, False),
                 #       - upstream assignee exists: called with remove_all=False
                 (63, False),
-                #       - upstream assignee has a fullname of None: called with remove_all=False
+                #       - upstream assignee has login but fullname is None: called with remove_all=False
                 (64, False),
                 #       - upstream assignee has login but no fullname key: called with remove_all=False
                 (65, False),