Skip to content

Commit a4b9bc3

Browse files
adding a missing case
1 parent d519d19 commit a4b9bc3

1 file changed

Lines changed: 10 additions & 8 deletions

File tree

tests/test_intermediary.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -256,20 +256,22 @@ def test_from_github_pr_flat_topic_normalizes_suffix(self, mock_matcher):
256256
mock_matcher.return_value = "JIRA-1"
257257
flat = "github.pull_request"
258258
cases = (
259-
("closed with merge", {"merged": True}, "closed", "merged"),
260-
("closed without merge", {"merged": False}, "closed", "closed"),
261-
("reopened", {}, "reopened", "reopened"),
262-
("opened", {}, "opened", "open"),
263-
("edited maps to open", {}, "edited", "open"),
264-
("missing action", {}, None, "open"),
259+
("closed with merge", {"merged": True}, "closed", "merged", flat),
260+
("closed without merge", {"merged": False}, "closed", "closed", flat),
261+
("reopened", {}, "reopened", "reopened", flat),
262+
("opened", {}, "opened", "open", flat),
263+
("edited maps to open", {}, "edited", "open", flat),
264+
("missing action flat topic", {}, None, "open", flat),
265+
("missing action preserves closed", {}, None, "closed", "closed"),
266+
("missing action preserves merged", {}, None, "merged", "merged"),
265267
)
266-
for name, pr_extra, action, expected in cases:
268+
for name, pr_extra, action, expected, suffix in cases:
267269
with self.subTest(name):
268270
pr = {**self.mock_github_pr, **pr_extra}
269271
base_kw = dict(
270272
upstream="github",
271273
pr=pr,
272-
suffix=flat,
274+
suffix=suffix,
273275
config=self.mock_config,
274276
)
275277
if action is not None:

0 commit comments

Comments
 (0)