Skip to content

Commit bffb3c7

Browse files
committed
Correct index image pullspec pass to function calls
Signed-off-by: Jan Lipovský <jlipovsk@redhat.com>
1 parent a3b8a64 commit bffb3c7

1 file changed

Lines changed: 12 additions & 7 deletions

File tree

iib/workers/tasks/build_containerized_merge.py

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,11 @@ def handle_containerized_merge_request(
129129
source_from_index_resolved = prebuild_info['source_from_index_resolved']
130130
target_index_resolved = prebuild_info['target_index_resolved']
131131

132+
main_ocp_version = (
133+
prebuild_info['target_ocp_version'] if target_index else prebuild_info['source_ocp_version']
134+
)
135+
main_index_image = target_index if target_index else source_from_index
136+
132137
# Set OPM version
133138
Opm.set_opm_version(target_index_resolved)
134139
opm_version = Opm.opm_version
@@ -144,14 +149,14 @@ def handle_containerized_merge_request(
144149

145150
with tempfile.TemporaryDirectory(prefix=f'iib-{request_id}-') as temp_dir:
146151
# Setup and clone Git repository
147-
branch = prebuild_info['target_ocp_version']
152+
branch = main_ocp_version
148153
(
149154
index_git_repo,
150155
local_git_repo_path,
151156
localized_git_catalog_path,
152157
) = prepare_git_repository_for_build(
153158
request_id=request_id,
154-
from_index=source_from_index,
159+
from_index=main_index_image,
155160
temp_dir=temp_dir,
156161
branch=branch,
157162
index_to_gitlab_push_map=index_to_gitlab_push_map or {},
@@ -201,7 +206,7 @@ def handle_containerized_merge_request(
201206
source_index_bundles=source_index_bundles,
202207
target_index_bundles=target_index_bundles,
203208
source_from_index=source_from_index_resolved,
204-
ocp_version=prebuild_info['target_ocp_version'],
209+
ocp_version=main_ocp_version,
205210
request_id=request_id,
206211
target_index=target_index_resolved,
207212
ignore_bundle_ocp_version=ignore_bundle_ocp_version,
@@ -280,7 +285,7 @@ def handle_containerized_merge_request(
280285
write_build_metadata(
281286
local_git_repo_path,
282287
opm_version,
283-
prebuild_info['target_ocp_version'],
288+
main_ocp_version,
284289
prebuild_info['distribution_scope'],
285290
prebuild_info['binary_image_resolved'],
286291
request_id,
@@ -330,7 +335,7 @@ def handle_containerized_merge_request(
330335
from_index=source_from_index,
331336
overwrite_from_index=overwrite_target_index,
332337
overwrite_from_index_token=overwrite_target_index_token,
333-
resolved_prebuild_from_index=source_from_index_resolved,
338+
resolved_prebuild_from_index=target_index_resolved,
334339
add_or_rm=False,
335340
is_image_fbc=True,
336341
# Passing an empty index_repo_map is intentional. In IIB 1.0, if
@@ -346,7 +351,7 @@ def handle_containerized_merge_request(
346351
# index.db file if the pipeline fails.
347352
original_index_db_digest = push_index_db_artifact(
348353
request_id=request_id,
349-
from_index=source_from_index,
354+
from_index=main_index_image,
350355
index_db_path=source_index_db_path,
351356
operators=operators_in_db,
352357
overwrite_from_index=overwrite_target_index,
@@ -370,7 +375,7 @@ def handle_containerized_merge_request(
370375
index_git_repo=index_git_repo,
371376
overwrite_from_index=overwrite_target_index,
372377
request_id=request_id,
373-
from_index=source_from_index,
378+
from_index=main_index_image,
374379
index_repo_map={},
375380
original_index_db_digest=original_index_db_digest,
376381
reason=f"error: {e}",

0 commit comments

Comments
 (0)