Add unit tests and Codecov coverage upload

Relates: RHELWF-14238
Assisted-by: Claude Code (claude-opus-4-6)

Author: hluk

.github/workflows/resultsdb_frontend.yml

@@ -4,10 +4,38 @@ name: ResultsDB_Frontend
 "on":
   pull_request:
   push:
+    branches:
+      - develop
   workflow_dispatch:
     inputs: {}
 
 jobs:
+  tests:
+    name: Unit tests
+    runs-on: ubuntu-latest
+    permissions:
+      id-token: write
+      contents: read
+
+    steps:
+      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
+
+      - name: Install uv
+        uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78 # v7
+        with:
+          python-version: "3.13"
+
+      - name: Test with tox
+        run: uvx --with tox-uv tox -e py3
+
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7
+        with:
+          fail_ci_if_error: true
+          verbose: true
+          use_oidc: true
+          flags: unit-tests
+
   hadolint:
     name: Hadolint
     runs-on: ubuntu-latest
@@ -17,9 +45,9 @@ jobs:
           - Dockerfile
 
     steps:
-      - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
+      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
 
-      - uses: hadolint/hadolint-action@54c9adbab1582c2ef04b2016b760714a4bfde3cf # v3.1.0
+      - uses: hadolint/hadolint-action@2332a7b74a6de0dda2e2221d575162eba76ba5e5 # v3.3.0
         with:
           dockerfile: ${{ matrix.dockerfile }}
           failure-threshold: warning

tests/conftest.py

@@ -0,0 +1,13 @@
+import os
+
+os.environ["TEST"] = "true"
+
+import pytest  # noqa: E402
+
+from resultsdb_frontend import app  # noqa: E402
+
+
+@pytest.fixture
+def client():
+    with app.test_client() as client:
+        yield client

tests/test_routes.py

@@ -0,0 +1,125 @@
+from unittest.mock import patch
+
+
+MOCK_RESULTS = {
+    "data": [
+        {
+            "id": 1,
+            "testcase": {"name": "test.case.1"},
+            "outcome": "PASSED",
+            "groups": ["group1"],
+            "data": {},
+            "note": "",
+            "submit_time": "2024-01-01T00:00:00",
+            "href": "",
+            "ref_url": "",
+        }
+    ],
+    "prev": None,
+    "next": None,
+}
+
+MOCK_RESULT = {
+    "id": 1,
+    "testcase": {"name": "test.case.1", "url": ""},
+    "outcome": "PASSED",
+    "groups": ["group1"],
+    "note": "",
+    "submit_time": "2024-01-01T00:00:00",
+    "data": {},
+    "href": "",
+    "ref_url": "",
+}
+
+MOCK_GROUPS = {
+    "data": [{"uuid": "group1", "results_count": 1}],
+    "prev": None,
+    "next": None,
+}
+
+MOCK_GROUP = {"uuid": "group1", "results_count": 1}
+
+MOCK_TESTCASES = {
+    "data": [{"name": "test.case.1"}],
+    "prev": None,
+    "next": None,
+}
+
+MOCK_TESTCASE = {"name": "test.case.1"}
+
+
+def test_index_redirects(client):
+    response = client.get("/")
+    assert response.status_code == 302
+    assert "/results" in response.headers["Location"]
+
+
+@patch("resultsdb_frontend.controllers.main.RDB_API")
+def test_results(mock_api, client):
+    mock_api.get_results.return_value = MOCK_RESULTS
+    response = client.get("/results")
+    assert response.status_code == 200
+
+
+@patch("resultsdb_frontend.controllers.main.RDB_API")
+def test_result_detail(mock_api, client):
+    mock_api.get_result.return_value = MOCK_RESULT
+    response = client.get("/results/1")
+    assert response.status_code == 200
+
+
+@patch("resultsdb_frontend.controllers.main.RDB_API")
+def test_result_detail_no_groups(mock_api, client):
+    mock_api.get_result.return_value = {
+        "id": 1,
+        "testcase": {"name": "test.case.1", "url": ""},
+        "outcome": "PASSED",
+        "note": "",
+        "submit_time": "2024-01-01T00:00:00",
+        "data": {},
+        "href": "",
+        "ref_url": "",
+    }
+    response = client.get("/results/1")
+    assert response.status_code == 200
+
+
+@patch("resultsdb_frontend.controllers.main.RDB_API")
+def test_groups(mock_api, client):
+    mock_api.get_groups.return_value = MOCK_GROUPS
+    response = client.get("/groups")
+    assert response.status_code == 200
+
+
+@patch("resultsdb_frontend.controllers.main.RDB_API")
+def test_group_detail(mock_api, client):
+    mock_api.get_group.return_value = MOCK_GROUP
+    response = client.get("/groups/group1")
+    assert response.status_code == 200
+
+
+@patch("resultsdb_frontend.controllers.main.RDB_API")
+def test_testcases(mock_api, client):
+    mock_api.get_testcases.return_value = MOCK_TESTCASES
+    response = client.get("/testcases")
+    assert response.status_code == 200
+
+
+@patch("resultsdb_frontend.controllers.main.RDB_API")
+def test_testcase_detail(mock_api, client):
+    mock_api.get_testcase.return_value = MOCK_TESTCASE
+    response = client.get("/testcases/test.case.1")
+    assert response.status_code == 200
+
+
+@patch("resultsdb_frontend.controllers.main.RDB_API")
+def test_testcase_tokenizer(mock_api, client):
+    mock_api.get_testcases.side_effect = [
+        {"data": [{"name": "b.test"}, {"name": "a.test"}]},
+        {"data": []},
+    ]
+    response = client.get("/testcase_tokenizer")
+    assert response.status_code == 200
+    assert response.content_type == "application/json"
+    data = response.get_json()
+    assert data == ["a.test", "b.test"]

tests/test_utils.py

@@ -0,0 +1,102 @@
+import json
+
+from resultsdb_frontend.proxy import ReverseProxied
+from resultsdb_frontend.requests_session import ErrorResponse
+from resultsdb_frontend.resultsdb_api import _prepare_params
+
+
+class TestPrepareParams:
+    def test_string_values(self):
+        assert _prepare_params(foo="bar") == {"foo": "bar"}
+
+    def test_list_values(self):
+        assert _prepare_params(items=["a", "b"]) == {"items": "a,b"}
+
+    def test_none_values_excluded(self):
+        assert _prepare_params(foo="bar", empty=None) == {"foo": "bar"}
+
+    def test_empty(self):
+        assert _prepare_params() == {}
+
+    def test_integer_values(self):
+        assert _prepare_params(page=1, limit=10) == {"page": "1", "limit": "10"}
+
+
+class TestErrorResponse:
+    def test_status_code(self):
+        resp = ErrorResponse(504, "timeout", "http://example.com")
+        assert resp.status_code == 504
+
+    def test_content(self):
+        resp = ErrorResponse(502, "connection error", "http://example.com")
+        data = json.loads(resp.content)
+        assert data == {"message": "connection error"}
+
+    def test_url(self):
+        resp = ErrorResponse(504, "timeout", "http://example.com/api")
+        assert resp.url == "http://example.com/api"
+
+
+class TestReverseProxied:
+    def _make_environ(self, **kwargs):
+        environ = {
+            "PATH_INFO": "/test",
+            "REQUEST_METHOD": "GET",
+            "SERVER_NAME": "localhost",
+            "SERVER_PORT": "5000",
+        }
+        environ.update(kwargs)
+        return environ
+
+    def test_script_name(self):
+        app_calls = []
+
+        def mock_app(environ, start_response):
+            app_calls.append(environ.copy())
+            return []
+
+        proxied = ReverseProxied(mock_app)
+        environ = self._make_environ(
+            HTTP_X_SCRIPT_NAME="/prefix",
+            PATH_INFO="/prefix/test",
+        )
+        proxied(environ, None)
+        assert app_calls[0]["SCRIPT_NAME"] == "/prefix"
+        assert app_calls[0]["PATH_INFO"] == "/test"
+
+    def test_forwarded_host(self):
+        app_calls = []
+
+        def mock_app(environ, start_response):
+            app_calls.append(environ.copy())
+            return []
+
+        proxied = ReverseProxied(mock_app)
+        environ = self._make_environ(HTTP_X_FORWARDED_HOST="example.com")
+        proxied(environ, None)
+        assert app_calls[0]["HTTP_HOST"] == "example.com"
+
+    def test_scheme(self):
+        app_calls = []
+
+        def mock_app(environ, start_response):
+            app_calls.append(environ.copy())
+            return []
+
+        proxied = ReverseProxied(mock_app)
+        environ = self._make_environ(HTTP_X_SCHEME="https")
+        proxied(environ, None)
+        assert app_calls[0]["wsgi.url_scheme"] == "https"
+
+    def test_no_proxy_headers(self):
+        app_calls = []
+
+        def mock_app(environ, start_response):
+            app_calls.append(environ.copy())
+            return []
+
+        proxied = ReverseProxied(mock_app)
+        environ = self._make_environ()
+        proxied(environ, None)
+        assert "SCRIPT_NAME" not in app_calls[0]
+        assert app_calls[0]["PATH_INFO"] == "/test"

tox.ini

@@ -0,0 +1,32 @@
+[tox]
+envlist = py3
+requires =
+    tox-uv
+
+[pytest]
+addopts =
+    --cov=resultsdb_frontend
+    --cov-report=term-missing
+    --cov-report=xml
+
+[coverage:run]
+branch = true
+source_pkgs =
+    resultsdb_frontend
+
+[coverage:paths]
+source =
+    resultsdb_frontend/
+    .tox/py3/lib/python*/site-packages/resultsdb_frontend/
+
+[testenv]
+basepython = python3.13
+runner = uv-venv-runner
+deps =
+    pytest
+    pytest-cov
+    -r requirements.txt
+commands =
+    pytest {posargs}
+setenv =
+    TEST = true