Fail rdump_set_oom_dump() loudly when the path copy fails

strdup() can fail right when callers reach for this API -- near the
memory_limit. Previously its NULL return went unchecked while the override
was still marked set, so the OOM auto-dump was silently disabled with no
fallback to the rdump.oom_dump INI default. Now return false with an
E_WARNING and leave the override cleared; return true on success.

https://claude.ai/code/session_017skw8BsHkF8wur7Pf4G9W5

Author: claude

README.md

@@ -124,7 +124,9 @@ rdump_set_oom_dump("/var/log/oom-" . getmypid() . ".rdump");
 ```
 
 The runtime setting applies to the current request and takes precedence over
-the `rdump.oom_dump` default.
+the `rdump.oom_dump` default. It returns `true` on success, or `false` (with an
+`E_WARNING`) if the path could not be stored, leaving the previous default in
+effect rather than silently disabling the dump.
 
 ## Analyse with reli
 

rdump.c

@@ -602,14 +602,16 @@ static void rdump_zend_error_cb(RDUMP_ERROR_CB_PARAMS)
 }
 
 /* ------------------------------------------------------------------ */
-/* PHP function: void rdump_set_oom_dump(?string $path, bool $full=false)
+/* PHP function: bool rdump_set_oom_dump(?string $path, bool $full=false)
  *
  * Runtime toggle for the OOM auto-dump, overriding the INI default for
  * the rest of the current request:
  *   - non-empty path -> enable, writing to that path (so callers can use
  *     a per-request/per-pid filename the static INI cannot express);
  *   - ""             -> force-disable even if rdump.oom_dump is set;
  *   - null           -> clear the override and fall back to the INI.
+ * Returns true on success, or false (with an E_WARNING) if the path could
+ * not be stored, in which case the override is left cleared.
  */
 /* ------------------------------------------------------------------ */
 
@@ -633,10 +635,22 @@ PHP_FUNCTION(rdump_set_oom_dump)
     rdump_clear_runtime_oom_dump();
 
     if (path != NULL) {
-        RDUMP_G(oom_dump_runtime) = strdup(path);
+        char *copy = strdup(path);
+        if (copy == NULL) {
+            /* strdup can fail exactly when callers reach for this API -- near
+             * the memory_limit. Leave the override cleared (not half-set) so
+             * resolution falls back to the rdump.oom_dump INI default rather
+             * than silently disabling the auto-dump, and signal the failure. */
+            php_error_docref(NULL, E_WARNING,
+                "rdump_set_oom_dump: out of memory copying the path");
+            RETURN_FALSE;
+        }
+        RDUMP_G(oom_dump_runtime) = copy;
         RDUMP_G(oom_dump_runtime_set) = 1;
         RDUMP_G(oom_dump_runtime_full) = full ? 1 : 0;
     }
+
+    RETURN_TRUE;
 }
 
 /* ------------------------------------------------------------------ */