Implement review feedback

Author: fwolter

Makefile

@@ -128,7 +128,7 @@ override CFLAGS	  += $(_CFLAGS) $(DEFINES) $(INCLUDES) \
 ### The object files (add further files here):
 
 OBJS = $(PLUGIN).o audio.o buf2rgb.o codec_audio.o codec_video.o config.o drmbuffer.o drmdevice.o drmplane.o grab.o h264parser.o \
-	logger.o mediaplayer.o ringbuffer.o softhddevice.o softhdmenu.o softhdosd.o threads.o videorender.o videostream.o queue.o
+	logger.o mediaplayer.o queue.o ringbuffer.o softhddevice.o softhdmenu.o softhdosd.o threads.o videorender.o videostream.o
 
 ifeq ($(GLES),1)
 OBJS += openglosd.o

queue.cpp

@@ -33,10 +33,10 @@
  *****************************************************************************/
 
 /**
- * @brief Push an element to the front of the queue
+ * Push an element to the front of the queue
  *
- * @tparam T Element type
- * @param element The element to push
+ * @tparam T       Element type
+ * @param  element The element to push
  * @return true if successfully pushed, false if queue is full
  */
 template <typename T>
@@ -54,10 +54,10 @@ bool cQueue<T>::Push(const T& element)
 }
 
 /**
- * @brief Pop an element from the back of the queue
+ * Pop an element from the back of the queue
  *
- * @tparam T Element type
- * @return T The popped element
+ * @tparam T                  Element type
+ * @return T                  The popped element
  * @throws std::runtime_error if queue is empty
  */
 template <typename T>
@@ -76,10 +76,10 @@ T cQueue<T>::Pop(void)
 }
 
 /**
- * @brief Get a reference to the front element
+ * Get a reference to the front element
  *
- * @tparam T Element type
- * @return T& Reference to the front (most recently pushed) element
+ * @tparam T                  Element type
+ * @return T                  Element at the front (most recently pushed)
  * @throws std::runtime_error if queue is empty
  */
 template <typename T>
@@ -95,10 +95,10 @@ T cQueue<T>::Head(void)
 }
 
 /**
- * @brief Get a reference to the back element
+ * Get a reference to the back element
  *
- * @tparam T Element type
- * @return T& Reference to the back (next to be popped) element
+ * @tparam T                  Element type
+ * @return T                  Element at the back (next to be popped)
  * @throws std::runtime_error if queue is empty
  */
 template <typename T>
@@ -114,7 +114,7 @@ T cQueue<T>::Peek(void)
 }
 
 /**
- * @brief Check if the queue is empty
+ * Check if the queue is empty
  *
  * @tparam T Element type
  * @return true if queue is empty, false otherwise
@@ -123,19 +123,21 @@ template <typename T>
 bool cQueue<T>::Empty(void)
 {
 	std::lock_guard<std::mutex> lock(m_mutex);
+
 	return m_deque.empty();
 }
 
 /**
- * @brief Get the current size of the queue
+ * Get the current size of the queue
  *
  * @tparam T Element type
- * @return size_t Number of elements currently in the queue
+ * @return Number of elements currently in the queue
  */
 template <typename T>
 size_t cQueue<T>::Size(void)
 {
 	std::lock_guard<std::mutex> lock(m_mutex);
+
 	return m_deque.size();
 }